hw/misc/pvpanic-mmio: Announce support for all pvpanic events

[PATCH] hw/misc/pvpanic-mmio: Announce support for all pvpanic events

Posted by Thomas Weißschuh 1 month, 3 weeks ago

The pvpanic-mmio also supports the PVPANIC_SHUTDOWN event by virtue
of using the generic pvpanic core.

Currently this is not expressed in the 'events' property,
so users can not discover this support.

Switch to the generic PVPANIC_EVENTS macro which automatically contains
all events supported by the generic pvpanic core.

Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
---
 hw/misc/pvpanic-mmio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/misc/pvpanic-mmio.c b/hw/misc/pvpanic-mmio.c
index a173a1a9a589..40b167b8d8dd 100644
--- a/hw/misc/pvpanic-mmio.c
+++ b/hw/misc/pvpanic-mmio.c
@@ -33,7 +33,7 @@ static void pvpanic_mmio_initfn(Object *obj)
 
 static const Property pvpanic_mmio_properties[] = {
     DEFINE_PROP_UINT8("events", PVPanicMMIOState, pvpanic.events,
-                      PVPANIC_PANICKED | PVPANIC_CRASH_LOADED),
+                      PVPANIC_EVENTS),
 };
 
 static void pvpanic_mmio_class_init(ObjectClass *klass, const void *data)

---
base-commit: b428fe036233cbd15d37e3c027ab6ca4d3661a80
change-id: 20260802-pvpanic-mmio-shutdown-9ad52be82b19

Best regards,
--  
Thomas Weißschuh <thomas@t-8ch.de>

Re: [PATCH] hw/misc/pvpanic-mmio: Announce support for all pvpanic events

Posted by Marc-André Lureau 1 month, 3 weeks ago

Hi

On Sun, Aug 2, 2026 at 2:08 PM Thomas Weißschuh <thomas@t-8ch.de> wrote:
>
> The pvpanic-mmio also supports the PVPANIC_SHUTDOWN event by virtue
> of using the generic pvpanic core.
>
> Currently this is not expressed in the 'events' property,
> so users can not discover this support.
>
> Switch to the generic PVPANIC_EVENTS macro which automatically contains
> all events supported by the generic pvpanic core.
>
> Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>

This changes the hardware, and should only be modified with a new machine type.

it should be enough to set it back to PVPANIC_PANICKED |
PVPANIC_CRASH_LOADED on older hw_compat.

> ---
>  hw/misc/pvpanic-mmio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/misc/pvpanic-mmio.c b/hw/misc/pvpanic-mmio.c
> index a173a1a9a589..40b167b8d8dd 100644
> --- a/hw/misc/pvpanic-mmio.c
> +++ b/hw/misc/pvpanic-mmio.c
> @@ -33,7 +33,7 @@ static void pvpanic_mmio_initfn(Object *obj)
>
>  static const Property pvpanic_mmio_properties[] = {
>      DEFINE_PROP_UINT8("events", PVPanicMMIOState, pvpanic.events,
> -                      PVPANIC_PANICKED | PVPANIC_CRASH_LOADED),
> +                      PVPANIC_EVENTS),
>  };
>
>  static void pvpanic_mmio_class_init(ObjectClass *klass, const void *data)
>
> ---
> base-commit: b428fe036233cbd15d37e3c027ab6ca4d3661a80
> change-id: 20260802-pvpanic-mmio-shutdown-9ad52be82b19
>
> Best regards,
> --
> Thomas Weißschuh <thomas@t-8ch.de>
>
>


-- 
Marc-André Lureau