[v1] IDE patches

[PULL 0/8] IDE patches

Denis V. Lunev posted 8 patches 1 month, 4 weeks ago

Diff against v1 v2 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260730081325.1816193-1-den@openvz.org

Maintainers: John Snow <jsnow@redhat.com>, "Denis V. Lunev" <den@openvz.org>, Fabiano Rosas <farosas@suse.de>, Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

There is a newer version of this series

MAINTAINERS               |   1 +
hw/ide/atapi.c            | 180 ++++++++++++++++++---------------------
tests/qtest/ahci-test.c   | 134 +++++++++++++++++++++++++++++
tests/qtest/ide-test.c    | 211 +++++++++++++++++++++++++++++-----------------
tests/qtest/libqos/ahci.c |   5 ++
tests/qtest/libqos/ahci.h |   2 +
6 files changed, 361 insertions(+), 172 deletions(-)

Expand all Fold all

[PULL 0/8] IDE patches

Posted by Denis V. Lunev 1 month, 4 weeks ago

The following changes since commit e1705a25aff35635c360bbaba4c2731d019a422a:

  Update version for v11.1.0-rc2 release (2026-07-29 06:16:08 -0400)

are available in the Git repository at:

  https://gitlab.com/dlunev/qemu tags/pull-ide-2026-07-30

for you to fetch changes up to 89d7cc4626bec53a6653a95489972d2400623e8f:

  tests/qtest/ahci: regression test for ATAPI read vs. drain (2026-07-30 09:16:45 +0200)

----------------------------------------------------------------
IDE patches

- fix a main-loop deadlock when an ATAPI PIO read spanning several
  sectors is in flight while a drain starts: the nested sector fetch
  was issued synchronously from inside the completion of the first
  read and queued behind the drain, which then never finished
- read the whole ATAPI elementary transfer in one asynchronous
  request instead, removing cd_read_sector_sync()
- extend the IDE/AHCI qtest coverage of ATAPI CD reads: parametrized
  read helper, multi-sector DMA, raw 2352-byte READ CD on both
  delivery paths, and a regression test for the deadlock above
- add myself as an IDE maintainer

Signed-off-by: Denis V. Lunev <den@openvz.org>
CC: Stefan Hajnoczi <stefanha@redhat.com>
CC: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>

----------------------------------------------------------------
Denis V. Lunev (8):
      MAINTAINERS: add myself to IDE maintainers
      tests/qtest/ide-test: parametrize the ATAPI CD-ROM read test
      tests/qtest/ide-test: add a multi-sector ATAPI DMA read test
      tests/qtest/ide-test: cover raw (2352-byte) ATAPI CD reads
      tests/qtest/libqos/ahci: support raw (2352-byte) READ CD
      tests/qtest/ahci: cover raw (2352-byte) ATAPI CD reads
      hw/ide/atapi: read the whole elementary transfer asynchronously
      tests/qtest/ahci: regression test for ATAPI read vs. drain

 MAINTAINERS               |   1 +
 hw/ide/atapi.c            | 180 ++++++++++++++++++---------------------
 tests/qtest/ahci-test.c   | 134 +++++++++++++++++++++++++++++
 tests/qtest/ide-test.c    | 211 +++++++++++++++++++++++++++++-----------------
 tests/qtest/libqos/ahci.c |   5 ++
 tests/qtest/libqos/ahci.h |   2 +
 6 files changed, 361 insertions(+), 172 deletions(-)

--
2.53.0

Re: [PULL 0/8] IDE patches

Posted by Michael Tokarev 1 month, 3 weeks ago

On 7/30/26 11:13, Denis V. Lunev wrote:

> IDE patches
> 
> - fix a main-loop deadlock when an ATAPI PIO read spanning several
>    sectors is in flight while a drain starts: the nested sector fetch
>    was issued synchronously from inside the completion of the first
>    read and queued behind the drain, which then never finished
> - read the whole ATAPI elementary transfer in one asynchronous
>    request instead, removing cd_read_sector_sync()
> - extend the IDE/AHCI qtest coverage of ATAPI CD reads: parametrized
>    read helper, multi-sector DMA, raw 2352-byte READ CD on both
>    delivery paths, and a regression test for the deadlock above

It looks like this whole pull request should be picked up for the
currently active qemu stable series (both the fixes and the tests).
Please let me know if something has to be left out.

Thanks,

/mjt