[v3] tests/functional/ppc: skip remote interrupts test if -net user not built

[PATCH v3] tests/functional/ppc: skip remote interrupts test if -net user not built

Posted by Shivang Upadhyay 4 weeks, 1 day ago

While running remote interrupts test, without libslirp-devel installed,
facing the following panic logs.

  File
    ...
    raise VMLaunchFailure(
    ...<3 lines>...
    ) from exc
    ...
        Output: qemu-system-ppc64: -netdev user,id=net0: network backend
'user' is not compiled into this binary

Adding netdev user requirement for this test.

Suggested-by: Amit Machhiwal <amachhiw@linux.ibm.com>
Reviewed-by: Amit Machhiwal <amachhiw@linux.ibm.com>
Suggested-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Fixes: 63f5ba80921 ("tests/functional: tests/functional: Add remote interrupts test for PowerNV")
Signed-off-by: Shivang Upadhyay <shivangu@linux.ibm.com>
---

Changelog:

v3:
  - rearranging the require_netdev, before set_machine. to keep all test requirements in same
    place, as suggested by Amit.
  - keeping review tags from Thomas and Amit.

v2: https://lore.kernel.org/qemu-devel/20260725174600.17683-1-shivangu@linux.ibm.com/
  - moved to require_netdev method, suggested by Amit and Thomas.
  
v1: https://lore.kernel.org/qemu-devel/20260724085440.520125-1-shivangu@linux.ibm.com/


---
 tests/functional/ppc64/test_powernv.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/functional/ppc64/test_powernv.py b/tests/functional/ppc64/test_powernv.py
index bac2017e18..f3e05e4d38 100755
--- a/tests/functional/ppc64/test_powernv.py
+++ b/tests/functional/ppc64/test_powernv.py
@@ -90,6 +90,7 @@ def test_linux_smt_boot(self):
 
     def test_linux_remote_interrupts(self):
         self.require_accelerator("tcg")
+        self.require_netdev('user')
         self.set_machine('powernv')
 
         # Have below setup in this test:
-- 
2.54.0

Re: [PATCH v3] tests/functional/ppc: skip remote interrupts test if -net user not built

Posted by Philippe Mathieu-Daudé 4 weeks, 1 day ago

On 28/7/26 09:46, Shivang Upadhyay wrote:
> While running remote interrupts test, without libslirp-devel installed,
> facing the following panic logs.
> 
>    File
>      ...
>      raise VMLaunchFailure(
>      ...<3 lines>...
>      ) from exc
>      ...
>          Output: qemu-system-ppc64: -netdev user,id=net0: network backend
> 'user' is not compiled into this binary
> 
> Adding netdev user requirement for this test.
> 
> Suggested-by: Amit Machhiwal <amachhiw@linux.ibm.com>
> Reviewed-by: Amit Machhiwal <amachhiw@linux.ibm.com>
> Suggested-by: Thomas Huth <thuth@redhat.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Fixes: 63f5ba80921 ("tests/functional: tests/functional: Add remote interrupts test for PowerNV")
> Signed-off-by: Shivang Upadhyay <shivangu@linux.ibm.com>
> ---

Queued via hw-misc, thanks.

Re: [PATCH v3] tests/functional/ppc: skip remote interrupts test if -net user not built

Posted by Amit Machhiwal 4 weeks, 1 day ago

On 2026/07/28 01:16 PM, Shivang Upadhyay wrote:
> While running remote interrupts test, without libslirp-devel installed,
> facing the following panic logs.
> 
>   File
>     ...
>     raise VMLaunchFailure(
>     ...<3 lines>...
>     ) from exc
>     ...
>         Output: qemu-system-ppc64: -netdev user,id=net0: network backend
> 'user' is not compiled into this binary
> 
> Adding netdev user requirement for this test.
> 
> Suggested-by: Amit Machhiwal <amachhiw@linux.ibm.com>
> Reviewed-by: Amit Machhiwal <amachhiw@linux.ibm.com>
> Suggested-by: Thomas Huth <thuth@redhat.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Fixes: 63f5ba80921 ("tests/functional: tests/functional: Add remote interrupts test for PowerNV")
> Signed-off-by: Shivang Upadhyay <shivangu@linux.ibm.com>
> ---

Looks like my Tested-by: from v2 got missed. Anyhow, sharing it again
here...

Tested on a system without libslirp-devel. Test is correctly skipped:

  ok 1 test_powernv.PowernvMachine.test_linux_remote_interrupts # SKIP no support for user networking
  1..1

Tested-by: Amit Machhiwal <amachhiw@linux.ibm.com>

Thanks,
Amit

> 
> Changelog:
> 
> v3:
>   - rearranging the require_netdev, before set_machine. to keep all test requirements in same
>     place, as suggested by Amit.
>   - keeping review tags from Thomas and Amit.
> 
> v2: https://lore.kernel.org/qemu-devel/20260725174600.17683-1-shivangu@linux.ibm.com/
>   - moved to require_netdev method, suggested by Amit and Thomas.
>   
> v1: https://lore.kernel.org/qemu-devel/20260724085440.520125-1-shivangu@linux.ibm.com/
> 
> 
> ---
>  tests/functional/ppc64/test_powernv.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/functional/ppc64/test_powernv.py b/tests/functional/ppc64/test_powernv.py
> index bac2017e18..f3e05e4d38 100755
> --- a/tests/functional/ppc64/test_powernv.py
> +++ b/tests/functional/ppc64/test_powernv.py
> @@ -90,6 +90,7 @@ def test_linux_smt_boot(self):
>  
>      def test_linux_remote_interrupts(self):
>          self.require_accelerator("tcg")
> +        self.require_netdev('user')
>          self.set_machine('powernv')
>  
>          # Have below setup in this test:
> -- 
> 2.54.0
> 
>

Re: [PATCH v3] tests/functional/ppc: skip remote interrupts test if -net user not built

Posted by Shivang Upadhyay 4 weeks, 1 day ago

On Tue, 2026-07-28 at 13:23 +0530, Amit Machhiwal wrote:
> > Suggested-by: Thomas Huth <thuth@redhat.com>
> > Reviewed-by: Thomas Huth <thuth@redhat.com>
> > Fixes: 63f5ba80921 ("tests/functional: tests/functional: Add remote
> > interrupts test for PowerNV")
> > Signed-off-by: Shivang Upadhyay <shivangu@linux.ibm.com>
> > ---
> 
> Looks like my Tested-by: from v2 got missed. Anyhow, sharing it again
> here...
> 
> Tested on a system without libslirp-devel. Test is correctly skipped:
> 
>   ok 1 test_powernv.PowernvMachine.test_linux_remote_interrupts #
> SKIP no support for user networking
>   1..1
> 
> Tested-by: Amit Machhiwal <amachhiw@linux.ibm.com>
> 
Thanks for posting again. I missed to pick it.

~Shivang.