accel/accel-irq: Avoid using inlined functions with external linkage

[PATCH] accel/accel-irq: Avoid using inlined functions with external linkage

Philippe Mathieu-Daudé posted 1 patch 3 days, 21 hours ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260721111201.85714-1-philmd@oss.qualcomm.com

Maintainers: Richard Henderson <richard.henderson@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, "Philippe Mathieu-Daudé" <philmd@mailo.com>

accel/accel-irq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] accel/accel-irq: Avoid using inlined functions with external linkage

Posted by Philippe Mathieu-Daudé 3 days, 21 hours ago

Similarly to commit 9de9fa5cf2 ("hw/arm/smmu-common: Avoid using
inlined functions with external linkage"):

  None of our code base require / use inlined functions with external
  linkage. Some places use internal inlining in the hot path. These
  two functions are certainly not in any hot path and don't justify
  any inlining, so these are likely oversights rather than intentional.

Signed-off-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>
---
 accel/accel-irq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/accel/accel-irq.c b/accel/accel-irq.c
index 830be27c7f9..b687f663394 100644
--- a/accel/accel-irq.c
+++ b/accel/accel-irq.c
@@ -90,7 +90,7 @@ int accel_irqchip_remove_irqfd_notifier_gsi(EventNotifier *n, int virq)
     return -ENOSYS;
 }
 
-inline AccelRouteChange accel_irqchip_begin_route_changes(void)
+AccelRouteChange accel_irqchip_begin_route_changes(void)
 {
     if (mshv_msi_via_irqfd_enabled()) {
         return (AccelRouteChange) {
-- 
2.53.0

Re: [PATCH] accel/accel-irq: Avoid using inlined functions with external linkage

Posted by Richard Henderson 3 days, 17 hours ago

On 7/21/26 04:12, Philippe Mathieu-Daudé wrote:
> Similarly to commit 9de9fa5cf2 ("hw/arm/smmu-common: Avoid using
> inlined functions with external linkage"):
> 
>    None of our code base require / use inlined functions with external
>    linkage. Some places use internal inlining in the hot path. These
>    two functions are certainly not in any hot path and don't justify
>    any inlining, so these are likely oversights rather than intentional.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>
> ---
>   accel/accel-irq.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/accel/accel-irq.c b/accel/accel-irq.c
> index 830be27c7f9..b687f663394 100644
> --- a/accel/accel-irq.c
> +++ b/accel/accel-irq.c
> @@ -90,7 +90,7 @@ int accel_irqchip_remove_irqfd_notifier_gsi(EventNotifier *n, int virq)
>       return -ENOSYS;
>   }
>   
> -inline AccelRouteChange accel_irqchip_begin_route_changes(void)
> +AccelRouteChange accel_irqchip_begin_route_changes(void)
>   {
>       if (mshv_msi_via_irqfd_enabled()) {
>           return (AccelRouteChange) {

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~