[v2] tests/qtest: aspeed_smc: Add fast-read variant test coverage

[PATCH v2 0/4] tests/qtest: aspeed_smc: Add fast-read variant test coverage

Cédric Le Goater posted 4 patches 1 week, 4 days ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260714124621.522948-1-clg@redhat.com

Maintainers: "Cédric Le Goater" <clg@kaod.org>, Peter Maydell <peter.maydell@linaro.org>, Steven Lee <steven_lee@aspeedtech.com>, Troy Lee <leetroy@gmail.com>, Jamin Lin <jamin_lin@aspeedtech.com>, Kane Chen <kane_chen@aspeedtech.com>, Andrew Jeffery <andrew@codeconstruct.com.au>, Joel Stanley <joel@jms.id.au>, Fabiano Rosas <farosas@suse.de>, Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Alistair Francis <alistair@alistair23.me>

tests/qtest/aspeed-smc-utils.h |  31 +++---
tests/qtest/aspeed-smc-utils.c | 192 ++++++++++++++++++++++++++++-----
tests/qtest/aspeed_smc-test.c  |  71 +++++++++---
tests/qtest/ast2700-smc-test.c |  12 +++
4 files changed, 247 insertions(+), 59 deletions(-)

Expand all Fold all

[PATCH v2 0/4] tests/qtest: aspeed_smc: Add fast-read variant test coverage

Posted by Cédric Le Goater 1 week, 4 days ago

Hello,

This series extends the Aspeed SMC qtest suite with coverage for
fast-read and multi-IO read commands :
  - Fast Read (single IO with dummy byte)
  - Dual Output Read (DOR, dual data IO)
  - Quad Output Read (QOR, quad data IO)

Each patch tests both the memory-mapped CTRL_FREADMODE path and the
user-mode command path, to exercise the dummy cycle handling recently
reworked in the m25p80 flash model.

Thanks,

C. 

Changes in v2:

  - Introduced spi_ctrl_set_fast_read() helper, replacing open-coded
    ctrl register setup in read_page_mem_fast_read/dor/qor()  
  - Replaced MIT license boilerplate with SPDX-License-Identifier
  - Collected Reviewed-by: Bin Meng on patches 1 and 3

Cédric Le Goater (4):
  tests/qtest: aspeed_smc: Introduce read_page_mem_fn for page read
    helpers
  tests/qtest: aspeed_smc: Add fast-read test coverage
  tests/qtest: aspeed_smc: Add Dual Output Read (DOR) test coverage
  tests/qtest: aspeed_smc: Add Quad Output Read (QOR) test coverage

 tests/qtest/aspeed-smc-utils.h |  31 +++---
 tests/qtest/aspeed-smc-utils.c | 192 ++++++++++++++++++++++++++++-----
 tests/qtest/aspeed_smc-test.c  |  71 +++++++++---
 tests/qtest/ast2700-smc-test.c |  12 +++
 4 files changed, 247 insertions(+), 59 deletions(-)

-- 
2.54.0

Re: [PATCH v2 0/4] tests/qtest: aspeed_smc: Add fast-read variant test coverage

Posted by Cédric Le Goater 1 week, 4 days ago

On 7/14/26 14:46, Cédric Le Goater wrote:
> Hello,
> 
> This series extends the Aspeed SMC qtest suite with coverage for
> fast-read and multi-IO read commands :
>    - Fast Read (single IO with dummy byte)
>    - Dual Output Read (DOR, dual data IO)
>    - Quad Output Read (QOR, quad data IO)
> 
> Each patch tests both the memory-mapped CTRL_FREADMODE path and the
> user-mode command path, to exercise the dummy cycle handling recently
> reworked in the m25p80 flash model.
> 
> Thanks,
> 
> C.
> 
> Changes in v2:
> 
>    - Introduced spi_ctrl_set_fast_read() helper, replacing open-coded
>      ctrl register setup in read_page_mem_fast_read/dor/qor()
>    - Replaced MIT license boilerplate with SPDX-License-Identifier
>    - Collected Reviewed-by: Bin Meng on patches 1 and 3
> 
> Cédric Le Goater (4):
>    tests/qtest: aspeed_smc: Introduce read_page_mem_fn for page read
>      helpers
>    tests/qtest: aspeed_smc: Add fast-read test coverage
>    tests/qtest: aspeed_smc: Add Dual Output Read (DOR) test coverage
>    tests/qtest: aspeed_smc: Add Quad Output Read (QOR) test coverage
> 
>   tests/qtest/aspeed-smc-utils.h |  31 +++---
>   tests/qtest/aspeed-smc-utils.c | 192 ++++++++++++++++++++++++++++-----
>   tests/qtest/aspeed_smc-test.c  |  71 +++++++++---
>   tests/qtest/ast2700-smc-test.c |  12 +++
>   4 files changed, 247 insertions(+), 59 deletions(-)
> 

Applied to

     https://github.com/legoater/qemu aspeed-next

Thanks,

C.