tests/functional: fix querying available machines

[PATCH] tests/functional: fix querying available machines

Posted by Vladimir Sementsov-Ogievskiy 1 day, 14 hours ago

Aliases are not handled, and that's why tests used them
are skipped, like this:

    PYTHONPATH=python:tests/functional \
    QEMU_TEST_QEMU_BINARY=$PWD/build/qemu-system-x86_64 \
    MESON_BUILD_ROOT=$PWD/build \
    ./build/pyvenv/bin/python3 tests/functional/x86_64/test_hotplug_blk.py

TAP version 13
ok 1 test_hotplug_blk.HotPlugBlk.test # SKIP no support for machine q35
1..1

Fixes: 0e7aa78b0bee50 ("tests/functional: use QMP to query available machines")
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
---
 tests/functional/qemu_test/testcase.py | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/tests/functional/qemu_test/testcase.py b/tests/functional/qemu_test/testcase.py
index 4912a47a464..e4179d165c0 100644
--- a/tests/functional/qemu_test/testcase.py
+++ b/tests/functional/qemu_test/testcase.py
@@ -325,9 +325,12 @@ def set_machine(self, machinename):
                 resp = tmp_vm.qmp('query-machines')
 
                 machines = resp.get('return', [])
-                cls._machines = [
-                    m.get('name') for m in machines if 'name' in m
-                ]
+                cls._machines = []
+                for m in machines:
+                    if 'name' in m:
+                        cls._machines.append(m['name'])
+                    if 'alias' in m:
+                        cls._machines.append(m['alias'])
 
             finally:
                 try:
-- 
2.43.0

Re: [PATCH] tests/functional: fix querying available machines

Posted by Philippe Mathieu-Daudé 1 day, 10 hours ago

On 10/7/26 11:03, Vladimir Sementsov-Ogievskiy wrote:
> Aliases are not handled, and that's why tests used them
> are skipped, like this:
> 
>      PYTHONPATH=python:tests/functional \
>      QEMU_TEST_QEMU_BINARY=$PWD/build/qemu-system-x86_64 \
>      MESON_BUILD_ROOT=$PWD/build \
>      ./build/pyvenv/bin/python3 tests/functional/x86_64/test_hotplug_blk.py
> 
> TAP version 13
> ok 1 test_hotplug_blk.HotPlugBlk.test # SKIP no support for machine q35
> 1..1
> 
> Fixes: 0e7aa78b0bee50 ("tests/functional: use QMP to query available machines")
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
>   tests/functional/qemu_test/testcase.py | 9 ++++++---
>   1 file changed, 6 insertions(+), 3 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>

Re: [PATCH] tests/functional: fix querying available machines

Posted by Daniel P. Berrangé 1 day, 13 hours ago

On Fri, Jul 10, 2026 at 12:03:17PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Aliases are not handled, and that's why tests used them
> are skipped, like this:
> 
>     PYTHONPATH=python:tests/functional \
>     QEMU_TEST_QEMU_BINARY=$PWD/build/qemu-system-x86_64 \
>     MESON_BUILD_ROOT=$PWD/build \
>     ./build/pyvenv/bin/python3 tests/functional/x86_64/test_hotplug_blk.py
> 
> TAP version 13
> ok 1 test_hotplug_blk.HotPlugBlk.test # SKIP no support for machine q35
> 1..1
> 
> Fixes: 0e7aa78b0bee50 ("tests/functional: use QMP to query available machines")
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
>  tests/functional/qemu_test/testcase.py | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|