target/sparc: remove unused helper_debug

[RFC PATCH] target/sparc: remove unused helper_debug

Alex Bennée posted 1 patch 2 weeks, 5 days ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260706105948.740881-1-alex.bennee@linaro.org

Maintainers: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Artyom Tarasenko <atar4qemu@gmail.com>

target/sparc/helper.h | 1 -
target/sparc/helper.c | 8 --------
2 files changed, 9 deletions(-)

Expand all Fold all

[RFC PATCH] target/sparc: remove unused helper_debug

Posted by Alex Bennée 2 weeks, 5 days ago

A long time ago we used to check for breakpoints within the target
loops. Since b5cf7428416 (accel/tcg: Remove
TranslatorOps.breakpoint_check) this is not longer required. Remove
the old helper.

Fixes: b5cf7428416 (accel/tcg: Remove TranslatorOps.breakpoint_check)
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 target/sparc/helper.h | 1 -
 target/sparc/helper.c | 8 --------
 2 files changed, 9 deletions(-)

diff --git a/target/sparc/helper.h b/target/sparc/helper.h
index 3a7f7dc1296..f943b6f5522 100644
--- a/target/sparc/helper.h
+++ b/target/sparc/helper.h
@@ -25,7 +25,6 @@ DEF_HELPER_FLAGS_2(tick_set_count, TCG_CALL_NO_RWG, void, ptr, i64)
 DEF_HELPER_FLAGS_3(tick_get_count, TCG_CALL_NO_WG, i64, env, ptr, int)
 DEF_HELPER_FLAGS_2(tick_set_limit, TCG_CALL_NO_RWG, void, ptr, i64)
 #endif
-DEF_HELPER_1(debug, void, env)
 DEF_HELPER_1(save, void, env)
 DEF_HELPER_1(restore, void, env)
 DEF_HELPER_FLAGS_3(udiv, TCG_CALL_NO_WG, i64, env, tl, tl)
diff --git a/target/sparc/helper.c b/target/sparc/helper.c
index 8de261b0e30..57ff395f2b3 100644
--- a/target/sparc/helper.c
+++ b/target/sparc/helper.c
@@ -41,14 +41,6 @@ void helper_raise_exception(CPUSPARCState *env, int tt)
     cpu_loop_exit(cs);
 }
 
-void helper_debug(CPUSPARCState *env)
-{
-    CPUState *cs = env_cpu(env);
-
-    cs->exception_index = EXCP_DEBUG;
-    cpu_loop_exit(cs);
-}
-
 #ifdef TARGET_SPARC64
 void helper_tick_set_count(void *opaque, uint64_t count)
 {
-- 
2.47.3

Re: [RFC PATCH] target/sparc: remove unused helper_debug

Posted by Richard Henderson 2 weeks, 4 days ago

On 7/6/26 03:59, Alex Bennée wrote:
> A long time ago we used to check for breakpoints within the target
> loops. Since b5cf7428416 (accel/tcg: Remove
> TranslatorOps.breakpoint_check) this is not longer required. Remove
> the old helper.
> 
> Fixes: b5cf7428416 (accel/tcg: Remove TranslatorOps.breakpoint_check)
> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
> ---
>   target/sparc/helper.h | 1 -
>   target/sparc/helper.c | 8 --------
>   2 files changed, 9 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~