[v1] Refactor AST2700 SCU preparation for coprocessors

[PATCH v1 0/4] Refactor AST2700 SCU preparation for coprocessors

Posted by Jamin Lin 2 weeks, 6 days ago

The original AST2700 FC support series [1] is fairly large, making it
difficult to review all changes together.

To help speed up the review process, this series extracts the SCU-related
refactoring into a standalone prerequisite series.

Compared with the original series, the SCU preparation patch has been
split into three smaller patches:

Introduce Aspeed2700SCUState.
Convert AST1700/AST27x0 users to the new SCU subclass.
Move the SCU link property into the AST27x0-specific coprocessor
implementation.

In addition, the SCUIO reset handling has been separated into an
independent patch.

This series contains no functional changes. It is purely a refactoring
to isolate AST2700-specific SCU support from the generic implementation
and prepare for the subsequent AST2700 FC support.

This series depends on:

https://patchwork.ozlabs.org/project/qemu-devel/cover/20260706052701.1141740-1-jamin_lin@aspeedtech.com/

Supersedes the following patches from the original FC support series [1]:

Patch 1:
https://patchwork.ozlabs.org/project/qemu-devel/patch/20260417032837.2664122-2-jamin_lin@aspeedtech.com/

Patch 2:
https://patchwork.ozlabs.org/project/qemu-devel/patch/20260417032837.2664122-3-jamin_lin@aspeedtech.com/

[1] Original AST2700 FC support series:
https://patchwork.ozlabs.org/project/qemu-devel/cover/20260417032837.2664122-1-jamin_lin@aspeedtech.com/

Jamin Lin (4):
  hw/misc/aspeed_scu: Introduce Aspeed2700SCUState
  hw/arm/aspeed: Use Aspeed2700SCUState for AST2700 users
  hw/arm/aspeed_ast27x0: Move SCU link into AST27x0 coprocessors
  hw/misc/aspeed_scu: Add separate reset handler for AST2700 SCUIO

 include/hw/arm/aspeed_ast1700.h     |  2 +-
 include/hw/arm/aspeed_coprocessor.h |  5 +++--
 include/hw/arm/aspeed_soc.h         |  1 +
 include/hw/misc/aspeed_scu.h        |  5 +++++
 hw/arm/aspeed_ast27x0-fc.c          |  4 ++--
 hw/arm/aspeed_ast27x0-ssp.c         | 19 +++++++++++++++----
 hw/arm/aspeed_ast27x0-tsp.c         | 19 +++++++++++++++----
 hw/arm/aspeed_ast27x0.c             | 16 ++++++++--------
 hw/arm/aspeed_coprocessor_common.c  |  2 --
 hw/misc/aspeed_scu.c                | 20 ++++++++++++++++++--
 10 files changed, 68 insertions(+), 25 deletions(-)

-- 
2.43.0

RE: [PATCH v1 0/4] Refactor AST2700 SCU preparation for coprocessors

Posted by Jamin Lin 2 weeks, 5 days ago

Sorry

I will resend v2 due to split [1] Original AST2700 FC support series

> Subject: [PATCH v1 0/4] Refactor AST2700 SCU preparation for coprocessors
> 
> The original AST2700 FC support series [1] is fairly large, making it difficult to
> review all changes together.
> 
> To help speed up the review process, this series extracts the SCU-related
> refactoring into a standalone prerequisite series.
> 
> Compared with the original series, the SCU preparation patch has been split
> into three smaller patches:
> 
> Introduce Aspeed2700SCUState.
> Convert AST1700/AST27x0 users to the new SCU subclass.
> Move the SCU link property into the AST27x0-specific coprocessor
> implementation.
> 
> In addition, the SCUIO reset handling has been separated into an independent
> patch.
> 
> This series contains no functional changes. It is purely a refactoring to isolate
> AST2700-specific SCU support from the generic implementation and prepare
> for the subsequent AST2700 FC support.
> 
> This series depends on:
> 
> https://patchwork.ozlabs.org/project/qemu-devel/cover/20260706052701.114
> 1740-1-jamin_lin@aspeedtech.com/
> 
> Supersedes the following patches from the original FC support series [1]:
> 
> Patch 1:
> https://patchwork.ozlabs.org/project/qemu-devel/patch/20260417032837.266
> 4122-2-jamin_lin@aspeedtech.com/
> 
> Patch 2:
> https://patchwork.ozlabs.org/project/qemu-devel/patch/20260417032837.266
> 4122-3-jamin_lin@aspeedtech.com/
> 
> [1] Original AST2700 FC support series:
> https://patchwork.ozlabs.org/project/qemu-devel/cover/20260417032837.266
> 4122-1-jamin_lin@aspeedtech.com/
> 
> Jamin Lin (4):
>   hw/misc/aspeed_scu: Introduce Aspeed2700SCUState
>   hw/arm/aspeed: Use Aspeed2700SCUState for AST2700 users
>   hw/arm/aspeed_ast27x0: Move SCU link into AST27x0 coprocessors
>   hw/misc/aspeed_scu: Add separate reset handler for AST2700 SCUIO
> 
>  include/hw/arm/aspeed_ast1700.h     |  2 +-
>  include/hw/arm/aspeed_coprocessor.h |  5 +++--
>  include/hw/arm/aspeed_soc.h         |  1 +
>  include/hw/misc/aspeed_scu.h        |  5 +++++
>  hw/arm/aspeed_ast27x0-fc.c          |  4 ++--
>  hw/arm/aspeed_ast27x0-ssp.c         | 19 +++++++++++++++----
>  hw/arm/aspeed_ast27x0-tsp.c         | 19 +++++++++++++++----
>  hw/arm/aspeed_ast27x0.c             | 16 ++++++++--------
>  hw/arm/aspeed_coprocessor_common.c  |  2 --
>  hw/misc/aspeed_scu.c                | 20 ++++++++++++++++++--
>  10 files changed, 68 insertions(+), 25 deletions(-)
> 
> --
> 2.43.0