[PATCH v2 0/5] hw/arm/fsl-imx8mp: Add inital FlexCAN support

Bernhard Beschow posted 5 patches 3 weeks, 2 days ago
Only 1 patches received!
docs/system/arm/imx8m.rst   |  1 +
include/hw/arm/fsl-imx8mp.h |  8 ++++
include/hw/net/flexcan.h    |  4 +-
hw/arm/fsl-imx6.c           |  5 ++-
hw/arm/fsl-imx8mp.c         | 38 ++++++++++++++++
hw/arm/imx8mp-evk.c         | 64 ++++++++++++++++++++++-----
hw/misc/imx8mp_ccm.c        |  3 ++
hw/net/can/flexcan.c        | 88 ++++++++++++++++++++++++++++++-------
hw/arm/Kconfig              |  1 +
9 files changed, 182 insertions(+), 30 deletions(-)
[PATCH v2 0/5] hw/arm/fsl-imx8mp: Add inital FlexCAN support
Posted by Bernhard Beschow 3 weeks, 2 days ago
Now that FlexCAN emulation has landed in master, let's add it to imx8mp-evk as
well. While the real i.MX8M Plus supports CAN FD which isn't emulated yet, the
non-FD mode works well under Linux: It is possible to use `cangen` and `candump`
either way on the host and on the guest, as described in
docs/system/devices/can.rst.

This series consists of five patches where the first four are preparations.
The last patch integrates FlexCAN into the i.MX8M Plus SoC and EVK board. The
first preparation addresses the review comment from [1], and could be applied
independently.

It would be nice if this series could make it into 11.1.

Testing done:
* Start imx8mp-evk and run `cangen can0` there. Observe on the host that
`candump vcan0` prints the traffic.
* `make check`

v2:
Thanks for the very helpful and super quick review, Phil! Here we go:
* Add patch "hw/net/can/flexcan: Wire clock control module via link property"
* Have separate MemoryRegionOps for 32 and 64 bit

[1] https://lore.kernel.org/qemu-devel/77d5891c-de12-467e-8746-02fe43121e3e@oss.qualcomm.com/
---
base-commit: a59157f98f0b69b0bbdb26bc15fbc4d6c8060799

Bernhard Beschow (5):
  hw/net/can/flexcan: Wire clock control module via link property
  hw/net/can/flexcan: Subclass TYPE_CAN_FLEXCAN
  hw/arm/imx8mp-evk: Open code DEFINE_MACHINE_AARCH64
  hw/arm/imx8mp-evk: Introduce FslImx8mpEvkState
  hw/arm: Add basic FlexCAN3 support to TYPE_FSL_IMX8MP and imx8mp-evk

 docs/system/arm/imx8m.rst   |  1 +
 include/hw/arm/fsl-imx8mp.h |  8 ++++
 include/hw/net/flexcan.h    |  4 +-
 hw/arm/fsl-imx6.c           |  5 ++-
 hw/arm/fsl-imx8mp.c         | 38 ++++++++++++++++
 hw/arm/imx8mp-evk.c         | 64 ++++++++++++++++++++++-----
 hw/misc/imx8mp_ccm.c        |  3 ++
 hw/net/can/flexcan.c        | 88 ++++++++++++++++++++++++++++++-------
 hw/arm/Kconfig              |  1 +
 9 files changed, 182 insertions(+), 30 deletions(-)

-- 
2.55.0
Re: [PATCH v2 0/5] hw/arm/fsl-imx8mp: Add inital FlexCAN support
Posted by Philippe Mathieu-Daudé 2 weeks, 5 days ago
On 2/7/26 20:40, Bernhard Beschow wrote:
> Now that FlexCAN emulation has landed in master, let's add it to imx8mp-evk as
> well. While the real i.MX8M Plus supports CAN FD which isn't emulated yet, the
> non-FD mode works well under Linux: It is possible to use `cangen` and `candump`
> either way on the host and on the guest, as described in
> docs/system/devices/can.rst.
> 
> This series consists of five patches where the first four are preparations.
> The last patch integrates FlexCAN into the i.MX8M Plus SoC and EVK board. The
> first preparation addresses the review comment from [1], and could be applied
> independently.
> 
> It would be nice if this series could make it into 11.1.
> 
> Testing done:
> * Start imx8mp-evk and run `cangen can0` there. Observe on the host that
> `candump vcan0` prints the traffic.
> * `make check`
> 
> v2:
> Thanks for the very helpful and super quick review, Phil! Here we go:
> * Add patch "hw/net/can/flexcan: Wire clock control module via link property"
> * Have separate MemoryRegionOps for 32 and 64 bit
> 
> [1] https://lore.kernel.org/qemu-devel/77d5891c-de12-467e-8746-02fe43121e3e@oss.qualcomm.com/
> ---
> base-commit: a59157f98f0b69b0bbdb26bc15fbc4d6c8060799
> 
> Bernhard Beschow (5):
>    hw/net/can/flexcan: Wire clock control module via link property
>    hw/net/can/flexcan: Subclass TYPE_CAN_FLEXCAN
>    hw/arm/imx8mp-evk: Open code DEFINE_MACHINE_AARCH64
>    hw/arm/imx8mp-evk: Introduce FslImx8mpEvkState
>    hw/arm: Add basic FlexCAN3 support to TYPE_FSL_IMX8MP and imx8mp-evk

Peter, you just sent your (IIUC) last target-arm PR. I'm about
to post my hw-misc one, do you mind if you take this series which
is fully reviewed/tested?

Regards,

Phil.
Re: [PATCH v2 0/5] hw/arm/fsl-imx8mp: Add inital FlexCAN support
Posted by Peter Maydell 2 weeks, 4 days ago
On Mon, 6 Jul 2026 at 14:25, Philippe Mathieu-Daudé
<philmd@oss.qualcomm.com> wrote:
>
> On 2/7/26 20:40, Bernhard Beschow wrote:
> > Now that FlexCAN emulation has landed in master, let's add it to imx8mp-evk as
> > well. While the real i.MX8M Plus supports CAN FD which isn't emulated yet, the
> > non-FD mode works well under Linux: It is possible to use `cangen` and `candump`
> > either way on the host and on the guest, as described in
> > docs/system/devices/can.rst.
> >
> > This series consists of five patches where the first four are preparations.
> > The last patch integrates FlexCAN into the i.MX8M Plus SoC and EVK board. The
> > first preparation addresses the review comment from [1], and could be applied
> > independently.
> >
> > It would be nice if this series could make it into 11.1.
> >
> > Testing done:
> > * Start imx8mp-evk and run `cangen can0` there. Observe on the host that
> > `candump vcan0` prints the traffic.
> > * `make check`
> >
> > v2:
> > Thanks for the very helpful and super quick review, Phil! Here we go:
> > * Add patch "hw/net/can/flexcan: Wire clock control module via link property"
> > * Have separate MemoryRegionOps for 32 and 64 bit
> >
> > [1] https://lore.kernel.org/qemu-devel/77d5891c-de12-467e-8746-02fe43121e3e@oss.qualcomm.com/
> > ---
> > base-commit: a59157f98f0b69b0bbdb26bc15fbc4d6c8060799
> >
> > Bernhard Beschow (5):
> >    hw/net/can/flexcan: Wire clock control module via link property
> >    hw/net/can/flexcan: Subclass TYPE_CAN_FLEXCAN
> >    hw/arm/imx8mp-evk: Open code DEFINE_MACHINE_AARCH64
> >    hw/arm/imx8mp-evk: Introduce FslImx8mpEvkState
> >    hw/arm: Add basic FlexCAN3 support to TYPE_FSL_IMX8MP and imx8mp-evk
>
> Peter, you just sent your (IIUC) last target-arm PR. I'm about
> to post my hw-misc one, do you mind if you take this series which
> is fully reviewed/tested?

As you note, I've already sent the last target-arm PR for pre-freeze
yesterday; I'm not going to do another one. So from my POV this
has just missed the deadline and will have to wait for 11.2.

thanks
-- PMM
Re: [PATCH v2 0/5] hw/arm/fsl-imx8mp: Add inital FlexCAN support
Posted by Philippe Mathieu-Daudé 2 weeks, 4 days ago
On 7/7/26 12:43, Peter Maydell wrote:
> On Mon, 6 Jul 2026 at 14:25, Philippe Mathieu-Daudé
> <philmd@oss.qualcomm.com> wrote:
>>
>> On 2/7/26 20:40, Bernhard Beschow wrote:
>>> Now that FlexCAN emulation has landed in master, let's add it to imx8mp-evk as
>>> well. While the real i.MX8M Plus supports CAN FD which isn't emulated yet, the
>>> non-FD mode works well under Linux: It is possible to use `cangen` and `candump`
>>> either way on the host and on the guest, as described in
>>> docs/system/devices/can.rst.
>>>
>>> This series consists of five patches where the first four are preparations.
>>> The last patch integrates FlexCAN into the i.MX8M Plus SoC and EVK board. The
>>> first preparation addresses the review comment from [1], and could be applied
>>> independently.
>>>
>>> It would be nice if this series could make it into 11.1.
>>>
>>> Testing done:
>>> * Start imx8mp-evk and run `cangen can0` there. Observe on the host that
>>> `candump vcan0` prints the traffic.
>>> * `make check`
>>>
>>> v2:
>>> Thanks for the very helpful and super quick review, Phil! Here we go:
>>> * Add patch "hw/net/can/flexcan: Wire clock control module via link property"
>>> * Have separate MemoryRegionOps for 32 and 64 bit
>>>
>>> [1] https://lore.kernel.org/qemu-devel/77d5891c-de12-467e-8746-02fe43121e3e@oss.qualcomm.com/
>>> ---
>>> base-commit: a59157f98f0b69b0bbdb26bc15fbc4d6c8060799
>>>
>>> Bernhard Beschow (5):
>>>     hw/net/can/flexcan: Wire clock control module via link property
>>>     hw/net/can/flexcan: Subclass TYPE_CAN_FLEXCAN
>>>     hw/arm/imx8mp-evk: Open code DEFINE_MACHINE_AARCH64
>>>     hw/arm/imx8mp-evk: Introduce FslImx8mpEvkState
>>>     hw/arm: Add basic FlexCAN3 support to TYPE_FSL_IMX8MP and imx8mp-evk
>>
>> Peter, you just sent your (IIUC) last target-arm PR. I'm about
>> to post my hw-misc one, do you mind if you take this series which
>> is fully reviewed/tested?
> 
> As you note, I've already sent the last target-arm PR for pre-freeze
> yesterday; I'm not going to do another one. So from my POV this
> has just missed the deadline and will have to wait for 11.2.

Err, I meant "do you mind if [I] take" ... :/

Re: [PATCH v2 0/5] hw/arm/fsl-imx8mp: Add inital FlexCAN support
Posted by Peter Maydell 2 weeks, 4 days ago
On Tue, 7 Jul 2026 at 13:30, Philippe Mathieu-Daudé
<philmd@oss.qualcomm.com> wrote:
>
> On 7/7/26 12:43, Peter Maydell wrote:
> > On Mon, 6 Jul 2026 at 14:25, Philippe Mathieu-Daudé
> > <philmd@oss.qualcomm.com> wrote:
> >>
> >> On 2/7/26 20:40, Bernhard Beschow wrote:
> >>> Now that FlexCAN emulation has landed in master, let's add it to imx8mp-evk as
> >>> well. While the real i.MX8M Plus supports CAN FD which isn't emulated yet, the
> >>> non-FD mode works well under Linux: It is possible to use `cangen` and `candump`
> >>> either way on the host and on the guest, as described in
> >>> docs/system/devices/can.rst.
> >>>
> >>> This series consists of five patches where the first four are preparations.
> >>> The last patch integrates FlexCAN into the i.MX8M Plus SoC and EVK board. The
> >>> first preparation addresses the review comment from [1], and could be applied
> >>> independently.
> >>>
> >>> It would be nice if this series could make it into 11.1.
> >>>
> >>> Testing done:
> >>> * Start imx8mp-evk and run `cangen can0` there. Observe on the host that
> >>> `candump vcan0` prints the traffic.
> >>> * `make check`
> >>>
> >>> v2:
> >>> Thanks for the very helpful and super quick review, Phil! Here we go:
> >>> * Add patch "hw/net/can/flexcan: Wire clock control module via link property"
> >>> * Have separate MemoryRegionOps for 32 and 64 bit
> >>>
> >>> [1] https://lore.kernel.org/qemu-devel/77d5891c-de12-467e-8746-02fe43121e3e@oss.qualcomm.com/
> >>> ---
> >>> base-commit: a59157f98f0b69b0bbdb26bc15fbc4d6c8060799
> >>>
> >>> Bernhard Beschow (5):
> >>>     hw/net/can/flexcan: Wire clock control module via link property
> >>>     hw/net/can/flexcan: Subclass TYPE_CAN_FLEXCAN
> >>>     hw/arm/imx8mp-evk: Open code DEFINE_MACHINE_AARCH64
> >>>     hw/arm/imx8mp-evk: Introduce FslImx8mpEvkState
> >>>     hw/arm: Add basic FlexCAN3 support to TYPE_FSL_IMX8MP and imx8mp-evk
> >>
> >> Peter, you just sent your (IIUC) last target-arm PR. I'm about
> >> to post my hw-misc one, do you mind if you take this series which
> >> is fully reviewed/tested?
> >
> > As you note, I've already sent the last target-arm PR for pre-freeze
> > yesterday; I'm not going to do another one. So from my POV this
> > has just missed the deadline and will have to wait for 11.2.
>
> Err, I meant "do you mind if [I] take" ... :/

Sure, if they've been reviewed and you're happy with them you can do that.

-- PMM
Re: [PATCH v2 0/5] hw/arm/fsl-imx8mp: Add inital FlexCAN support
Posted by Philippe Mathieu-Daudé 2 weeks, 4 days ago
On 7/7/26 14:47, Peter Maydell wrote:
> On Tue, 7 Jul 2026 at 13:30, Philippe Mathieu-Daudé
> <philmd@oss.qualcomm.com> wrote:
>>
>> On 7/7/26 12:43, Peter Maydell wrote:
>>> On Mon, 6 Jul 2026 at 14:25, Philippe Mathieu-Daudé
>>> <philmd@oss.qualcomm.com> wrote:
>>>>
>>>> On 2/7/26 20:40, Bernhard Beschow wrote:
>>>>> Now that FlexCAN emulation has landed in master, let's add it to imx8mp-evk as
>>>>> well. While the real i.MX8M Plus supports CAN FD which isn't emulated yet, the
>>>>> non-FD mode works well under Linux: It is possible to use `cangen` and `candump`
>>>>> either way on the host and on the guest, as described in
>>>>> docs/system/devices/can.rst.
>>>>>
>>>>> This series consists of five patches where the first four are preparations.
>>>>> The last patch integrates FlexCAN into the i.MX8M Plus SoC and EVK board. The
>>>>> first preparation addresses the review comment from [1], and could be applied
>>>>> independently.
>>>>>
>>>>> It would be nice if this series could make it into 11.1.
>>>>>
>>>>> Testing done:
>>>>> * Start imx8mp-evk and run `cangen can0` there. Observe on the host that
>>>>> `candump vcan0` prints the traffic.
>>>>> * `make check`
>>>>>
>>>>> v2:
>>>>> Thanks for the very helpful and super quick review, Phil! Here we go:
>>>>> * Add patch "hw/net/can/flexcan: Wire clock control module via link property"
>>>>> * Have separate MemoryRegionOps for 32 and 64 bit
>>>>>
>>>>> [1] https://lore.kernel.org/qemu-devel/77d5891c-de12-467e-8746-02fe43121e3e@oss.qualcomm.com/
>>>>> ---
>>>>> base-commit: a59157f98f0b69b0bbdb26bc15fbc4d6c8060799
>>>>>
>>>>> Bernhard Beschow (5):
>>>>>      hw/net/can/flexcan: Wire clock control module via link property
>>>>>      hw/net/can/flexcan: Subclass TYPE_CAN_FLEXCAN
>>>>>      hw/arm/imx8mp-evk: Open code DEFINE_MACHINE_AARCH64
>>>>>      hw/arm/imx8mp-evk: Introduce FslImx8mpEvkState
>>>>>      hw/arm: Add basic FlexCAN3 support to TYPE_FSL_IMX8MP and imx8mp-evk
>>>>
>>>> Peter, you just sent your (IIUC) last target-arm PR. I'm about
>>>> to post my hw-misc one, do you mind if you take this series which
>>>> is fully reviewed/tested?
>>>
>>> As you note, I've already sent the last target-arm PR for pre-freeze
>>> yesterday; I'm not going to do another one. So from my POV this
>>> has just missed the deadline and will have to wait for 11.2.
>>
>> Err, I meant "do you mind if [I] take" ... :/
> 
> Sure, if they've been reviewed and you're happy with them you can do that.

Thanks!


Re: [PATCH v2 0/5] hw/arm/fsl-imx8mp: Add inital FlexCAN support
Posted by Bernhard Beschow 2 weeks, 4 days ago

Am 6. Juli 2026 13:25:51 UTC schrieb "Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>:
>On 2/7/26 20:40, Bernhard Beschow wrote:
>> Now that FlexCAN emulation has landed in master, let's add it to imx8mp-evk as
>> well. While the real i.MX8M Plus supports CAN FD which isn't emulated yet, the
>> non-FD mode works well under Linux: It is possible to use `cangen` and `candump`
>> either way on the host and on the guest, as described in
>> docs/system/devices/can.rst.
>> 
>> This series consists of five patches where the first four are preparations.
>> The last patch integrates FlexCAN into the i.MX8M Plus SoC and EVK board. The
>> first preparation addresses the review comment from [1], and could be applied
>> independently.
>> 
>> It would be nice if this series could make it into 11.1.
>> 
>> Testing done:
>> * Start imx8mp-evk and run `cangen can0` there. Observe on the host that
>> `candump vcan0` prints the traffic.
>> * `make check`
>> 
>> v2:
>> Thanks for the very helpful and super quick review, Phil! Here we go:
>> * Add patch "hw/net/can/flexcan: Wire clock control module via link property"
>> * Have separate MemoryRegionOps for 32 and 64 bit
>> 
>> [1] https://lore.kernel.org/qemu-devel/77d5891c-de12-467e-8746-02fe43121e3e@oss.qualcomm.com/
>> ---
>> base-commit: a59157f98f0b69b0bbdb26bc15fbc4d6c8060799
>> 
>> Bernhard Beschow (5):
>>    hw/net/can/flexcan: Wire clock control module via link property
>>    hw/net/can/flexcan: Subclass TYPE_CAN_FLEXCAN
>>    hw/arm/imx8mp-evk: Open code DEFINE_MACHINE_AARCH64
>>    hw/arm/imx8mp-evk: Introduce FslImx8mpEvkState
>>    hw/arm: Add basic FlexCAN3 support to TYPE_FSL_IMX8MP and imx8mp-evk
>
>Peter, you just sent your (IIUC) last target-arm PR. I'm about
>to post my hw-misc one, do you mind if you take this series which
>is fully reviewed/tested?

Thanks a lot Phil for your R-b's!

Any chance we can still get this series mergend for the upcoming release?

Thanks,
Bernhard
Re: [PATCH v2 0/5] hw/arm/fsl-imx8mp: Add inital FlexCAN support
Posted by Pavel Pisa 2 weeks, 5 days ago
Dear Bernhard,

On Thursday 02 of July 2026 20:40:33 Bernhard Beschow wrote:
> Now that FlexCAN emulation has landed in master, let's add it to imx8mp-evk
> as well. While the real i.MX8M Plus supports CAN FD which isn't emulated
> yet, the non-FD mode works well under Linux: It is possible to use `cangen`
> and `candump` either way on the host and on the guest, as described in
> docs/system/devices/can.rst.
>
> This series consists of five patches where the first four are preparations.
> The last patch integrates FlexCAN into the i.MX8M Plus SoC and EVK board.
> The first preparation addresses the review comment from [1], and could be
> applied independently.
>
> It would be nice if this series could make it into 11.1.
>
> Testing done:
> * Start imx8mp-evk and run `cangen can0` there. Observe on the host that
> `candump vcan0` prints the traffic.
> * `make check`
>
> v2:
> Thanks for the very helpful and super quick review, Phil! Here we go:
> * Add patch "hw/net/can/flexcan: Wire clock control module via link
> property" * Have separate MemoryRegionOps for 32 and 64 bit
>
> [1]
> https://lore.kernel.org/qemu-devel/77d5891c-de12-467e-8746-02fe43121e3e@oss
>.qualcomm.com/ ---
> base-commit: a59157f98f0b69b0bbdb26bc15fbc4d6c8060799
>
> Bernhard Beschow (5):
>   hw/net/can/flexcan: Wire clock control module via link property
>   hw/net/can/flexcan: Subclass TYPE_CAN_FLEXCAN
>   hw/arm/imx8mp-evk: Open code DEFINE_MACHINE_AARCH64
>   hw/arm/imx8mp-evk: Introduce FslImx8mpEvkState
>   hw/arm: Add basic FlexCAN3 support to TYPE_FSL_IMX8MP and imx8mp-evk
>
>  docs/system/arm/imx8m.rst   |  1 +
>  include/hw/arm/fsl-imx8mp.h |  8 ++++
>  include/hw/net/flexcan.h    |  4 +-
>  hw/arm/fsl-imx6.c           |  5 ++-
>  hw/arm/fsl-imx8mp.c         | 38 ++++++++++++++++
>  hw/arm/imx8mp-evk.c         | 64 ++++++++++++++++++++++-----
>  hw/misc/imx8mp_ccm.c        |  3 ++
>  hw/net/can/flexcan.c        | 88 ++++++++++++++++++++++++++++++-------
>  hw/arm/Kconfig              |  1 +
>  9 files changed, 182 insertions(+), 30 deletions(-)

Thanks for the work. I have tested the series on the top
of your imx8mp-flexcan branch, commit

  3b7289419cac5b712faeadf6b4a6203579d08f76

with our test setup for iMX6

  qemu-system-arm -m 1G -M sabrelite -smp 4 ...

and it worked as intended. I have looked at all patches
from your series and I do not see anything problematic.

You can add my confirmation to the series and or individual
patches

Acked-by: Pavel Pisa <pisa@fel.cvut.cz>
Tested-by: Pavel Pisa <pisa@fel.cvut.cz>

By the way, I have noticed your iMX53 branch. We have some
old kits for this because we used it for yet another generation
of medical infusion system prototypes/instruments fully
functional demonstrators but before final HW design with
safety.

The fully realized and produced systems with iMX1 there
https://www.pikron.com/pages/devel/medinst.html

Functional demonstrators with iMX53 there
https://onimed.cz/wp-content/uploads/2021/02/medicina.png

Best wishes,

                Pavel

                Pavel Pisa
    phone:      +420 603531357
    e-mail:     pisa@cmp.felk.cvut.cz
    Department of Control Engineering FEE CVUT
    Karlovo namesti 13, 121 35, Prague 2
    university: http://control.fel.cvut.cz/
    personal:   http://cmp.felk.cvut.cz/~pisa
    social:     https://social.kernel.org/ppisa
    projects:   https://www.openhub.net/accounts/ppisa
    CAN related:http://canbus.pages.fel.cvut.cz/
    RISC-V education: https://comparch.edu.cvut.cz/
    Open Technologies Research Education and Exchange Services
    https://gitlab.fel.cvut.cz/otrees/org/-/wikis/home
Re: [PATCH v2 0/5] hw/arm/fsl-imx8mp: Add inital FlexCAN support
Posted by Bernhard Beschow 2 weeks, 4 days ago

Am 6. Juli 2026 11:44:14 UTC schrieb Pavel Pisa <pisa@fel.cvut.cz>:
>Dear Bernhard,
>
>On Thursday 02 of July 2026 20:40:33 Bernhard Beschow wrote:
>> Now that FlexCAN emulation has landed in master, let's add it to imx8mp-evk
>> as well. While the real i.MX8M Plus supports CAN FD which isn't emulated
>> yet, the non-FD mode works well under Linux: It is possible to use `cangen`
>> and `candump` either way on the host and on the guest, as described in
>> docs/system/devices/can.rst.
>>
>> This series consists of five patches where the first four are preparations.
>> The last patch integrates FlexCAN into the i.MX8M Plus SoC and EVK board.
>> The first preparation addresses the review comment from [1], and could be
>> applied independently.
>>
>> It would be nice if this series could make it into 11.1.
>>
>> Testing done:
>> * Start imx8mp-evk and run `cangen can0` there. Observe on the host that
>> `candump vcan0` prints the traffic.
>> * `make check`
>>
>> v2:
>> Thanks for the very helpful and super quick review, Phil! Here we go:
>> * Add patch "hw/net/can/flexcan: Wire clock control module via link
>> property" * Have separate MemoryRegionOps for 32 and 64 bit
>>
>> [1]
>> https://lore.kernel.org/qemu-devel/77d5891c-de12-467e-8746-02fe43121e3e@oss
>>.qualcomm.com/ ---
>> base-commit: a59157f98f0b69b0bbdb26bc15fbc4d6c8060799
>>
>> Bernhard Beschow (5):
>>   hw/net/can/flexcan: Wire clock control module via link property
>>   hw/net/can/flexcan: Subclass TYPE_CAN_FLEXCAN
>>   hw/arm/imx8mp-evk: Open code DEFINE_MACHINE_AARCH64
>>   hw/arm/imx8mp-evk: Introduce FslImx8mpEvkState
>>   hw/arm: Add basic FlexCAN3 support to TYPE_FSL_IMX8MP and imx8mp-evk
>>
>>  docs/system/arm/imx8m.rst   |  1 +
>>  include/hw/arm/fsl-imx8mp.h |  8 ++++
>>  include/hw/net/flexcan.h    |  4 +-
>>  hw/arm/fsl-imx6.c           |  5 ++-
>>  hw/arm/fsl-imx8mp.c         | 38 ++++++++++++++++
>>  hw/arm/imx8mp-evk.c         | 64 ++++++++++++++++++++++-----
>>  hw/misc/imx8mp_ccm.c        |  3 ++
>>  hw/net/can/flexcan.c        | 88 ++++++++++++++++++++++++++++++-------
>>  hw/arm/Kconfig              |  1 +
>>  9 files changed, 182 insertions(+), 30 deletions(-)
>
>Thanks for the work. I have tested the series on the top
>of your imx8mp-flexcan branch, commit
>
>  3b7289419cac5b712faeadf6b4a6203579d08f76
>
>with our test setup for iMX6
>
>  qemu-system-arm -m 1G -M sabrelite -smp 4 ...
>
>and it worked as intended. I have looked at all patches
>from your series and I do not see anything problematic.
>
>You can add my confirmation to the series and or individual
>patches
>
>Acked-by: Pavel Pisa <pisa@fel.cvut.cz>
>Tested-by: Pavel Pisa <pisa@fel.cvut.cz>

Thanks!

>
>By the way, I have noticed your iMX53 branch.

I haven't decided yet whether to upstream it because I wonder if anyone would be interested in this rather old but (IIUC) longterm SoC. For some reason I get file system corruption there which should be resolved before upstreaming can be considered.

Best regards,
Bernhard

> We have some
>old kits for this because we used it for yet another generation
>of medical infusion system prototypes/instruments fully
>functional demonstrators but before final HW design with
>safety.
>
>The fully realized and produced systems with iMX1 there
>https://www.pikron.com/pages/devel/medinst.html
>
>Functional demonstrators with iMX53 there
>https://onimed.cz/wp-content/uploads/2021/02/medicina.png
>
>Best wishes,
>
>                Pavel
>
>                Pavel Pisa
>    phone:      +420 603531357
>    e-mail:     pisa@cmp.felk.cvut.cz
>    Department of Control Engineering FEE CVUT
>    Karlovo namesti 13, 121 35, Prague 2
>    university: http://control.fel.cvut.cz/
>    personal:   http://cmp.felk.cvut.cz/~pisa
>    social:     https://social.kernel.org/ppisa
>    projects:   https://www.openhub.net/accounts/ppisa
>    CAN related:http://canbus.pages.fel.cvut.cz/
>    RISC-V education: https://comparch.edu.cvut.cz/
>    Open Technologies Research Education and Exchange Services
>    https://gitlab.fel.cvut.cz/otrees/org/-/wikis/home