Hi Peter,
That makes sense. I will add a patch to check capabilities and fail
gracefully before the testing changes in next verision.
I agree with most of the suggested changes and will integrate them in
next version. I replied to the comments on patches 3 and 6 with
clarifications.
Thanks,
Aadeshveer Singh
On Tue, Jul 7, 2026 at 12:46 AM Peter Xu <peterx@redhat.com> wrote:
>
> On Tue, Jun 30, 2026 at 01:49:33PM +0530, Aadeshveer Singh wrote:
> > Future direction:
> > - Add support for hugepages
> > - Add support for multifd
> > - Add support for vhost-user
>
> When send the formal patchset, you can add one more patch before the
> testing changes, but after the rest, to explicitly fail the migration when
> any of above was detected (e.g. update migrate_caps_check).
>
> It's just to make sure when your feature enabled (but with some unsupported
> setup) it won't crash QEMU but instead gracefully fail migrate QMP command
> (or migrate-set-parameters / migrate-set-capabilities).
>
> Thanks,
>
> --
> Peter Xu
>