amd_iommu: Fix Coverity and endianness issues

[PATCH v2 0/4] amd_iommu: Fix Coverity and endianness issues

Alejandro Jimenez posted 4 patches 1 month ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260624195925.1254462-1-alejandro.j.jimenez@oracle.com

Maintainers: Alejandro Jimenez <alejandro.j.jimenez@oracle.com>, Sairaj Kodilkar <sarunkod@amd.com>, "Michael S. Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>

hw/i386/amd_iommu.c | 164 +++++++++++++++++++++++++++++++-------------
hw/i386/amd_iommu.h |  63 -----------------
2 files changed, 118 insertions(+), 109 deletions(-)

Expand all Fold all

[PATCH v2 0/4] amd_iommu: Fix Coverity and endianness issues

Posted by Alejandro Jimenez 1 month ago

This series fixes the AMD vIOMMU issues reported from the 11.1 pull request
Coverity scan, plus follow-up review comments pointing out bitfield usage and
big-endian hosts compatibility concerns.

Although patches 3 and 4 fix correctness issues in big-endian hosts, these are
longstanding portability bugs rather than recent regressions, so I have not CC'd
qemu-stable on them.

Thank you,
Alejandro

Changes since v1:
https://lore.kernel.org/all/20260623005813.984238-1-alejandro.j.jimenez@oracle.com/
- Added Peter's Reviewed-by to patch 1.
- Dropped the standalone "Fully initialize XT interrupt message state" patch.
  Patch 2 now fixes CID 1660056 and removes the XT bitfield union.
- Added two patches to remove IRTE bitfield decoding and fix command buffer
  endianness handling.

Alejandro Jimenez (4):
  amd_iommu: Return int from page walk status helpers
  amd_iommu: Decode XT interrupt control register without bitfields
  amd_iommu: Decode IRTEs without bitfields
  amd_iommu: Fix endianness handling for command buffer entries

 hw/i386/amd_iommu.c | 164 +++++++++++++++++++++++++++++++-------------
 hw/i386/amd_iommu.h |  63 -----------------
 2 files changed, 118 insertions(+), 109 deletions(-)


base-commit: b83371668192a705b878e909c5ae9c1233cbd5fb
-- 
2.47.3

Re: [PATCH v2 0/4] amd_iommu: Fix Coverity and endianness issues

Posted by Peter Maydell 4 weeks, 1 day ago

On Wed, 24 Jun 2026 at 20:59, Alejandro Jimenez
<alejandro.j.jimenez@oracle.com> wrote:
>
> This series fixes the AMD vIOMMU issues reported from the 11.1 pull request
> Coverity scan, plus follow-up review comments pointing out bitfield usage and
> big-endian hosts compatibility concerns.
>
> Although patches 3 and 4 fix correctness issues in big-endian hosts, these are
> longstanding portability bugs rather than recent regressions, so I have not CC'd
> qemu-stable on them.
>
> Thank you,
> Alejandro

For the whole series:

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM