audio: converts malloc to g_new and free to g_free

[PATCH] audio: converts malloc to g_new and free to g_free

Posted by Christian S. Lima 1 month, 1 week ago

Following the qemu coding style change malloc to g_new, the advantage
are that g_new can catch multiplication overflowing size_t and allow
catch more type errors because it returns the type itself.

Signed-off-by: Christian S. Lima <christianslima@proton.me>
---
 hw/audio/fmopl.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c
index a63ad0f04d..19c4b388f3 100644
--- a/hw/audio/fmopl.c
+++ b/hw/audio/fmopl.c
@@ -607,24 +607,24 @@ static int OPLOpenTable( void )
 	double pom;
 
 	/* allocate dynamic tables */
-	if( (TL_TABLE = malloc(TL_MAX*2*sizeof(int32_t))) == NULL)
+	if( (TL_TABLE = g_new(int32_t, TL_MAX * 2)) == NULL)
 		return 0;
-	if( (SIN_TABLE = malloc(SIN_ENT*4 *sizeof(int32_t *))) == NULL)
+	if( (SIN_TABLE = g_new(int32_t *, SIN_ENT * 4)) == NULL)
 	{
-		free(TL_TABLE);
+		g_free(TL_TABLE);
 		return 0;
 	}
-	if( (AMS_TABLE = malloc(AMS_ENT*2 *sizeof(int32_t))) == NULL)
+	if( (AMS_TABLE = g_new(int32_t, AMS_ENT * 2)) == NULL)
 	{
-		free(TL_TABLE);
-		free(SIN_TABLE);
+		g_free(TL_TABLE);
+		g_free(SIN_TABLE);
 		return 0;
 	}
-	if( (VIB_TABLE = malloc(VIB_ENT*2 *sizeof(int32_t))) == NULL)
+	if( (VIB_TABLE = g_new(int32_t, VIB_ENT * 2)) == NULL)
 	{
-		free(TL_TABLE);
-		free(SIN_TABLE);
-		free(AMS_TABLE);
+		g_free(TL_TABLE);
+		g_free(SIN_TABLE);
+		g_free(AMS_TABLE);
 		return 0;
 	}
     ENV_CURVE = g_new(int32_t, 2 * EG_ENT + 1);
-- 
2.53.0

Re: [PATCH] audio: converts malloc to g_new and free to g_free

Posted by Peter Maydell 1 month, 1 week ago

On Fri, 19 Jun 2026 at 09:10, Christian S. Lima
<christianslima@proton.me> wrote:
>
> Following the qemu coding style change malloc to g_new, the advantage
> are that g_new can catch multiplication overflowing size_t and allow
> catch more type errors because it returns the type itself.
>
> Signed-off-by: Christian S. Lima <christianslima@proton.me>
> ---
>  hw/audio/fmopl.c | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)


Hi; we already have somebody working on updating this
set of malloc/free calls:

https://lore.kernel.org/qemu-devel/20260428162048.2995097-1-luc.fast2004@gmail.com/

thanks
-- PMM

Re: [PATCH] audio: converts malloc to g_new and free to g_free

Posted by Christian 1 month ago

> Hi; we already have somebody working on updating this
> set of malloc/free calls:
> 
> https://lore.kernel.org/qemu-devel/20260428162048.2995097-1-luc.fast2004@gmail.com/

Oh, I'm sorry. I didn't know, sorry for the inconvenience.

Thanks,
Christian.

Re: [PATCH] audio: converts malloc to g_new and free to g_free

Posted by Daniel P. Berrangé 1 month, 1 week ago

On Fri, Jun 19, 2026 at 08:09:42AM +0000, Christian S. Lima wrote:
> Following the qemu coding style change malloc to g_new, the advantage
> are that g_new can catch multiplication overflowing size_t and allow
> catch more type errors because it returns the type itself.
> 
> Signed-off-by: Christian S. Lima <christianslima@proton.me>
> ---
>  hw/audio/fmopl.c | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c
> index a63ad0f04d..19c4b388f3 100644
> --- a/hw/audio/fmopl.c
> +++ b/hw/audio/fmopl.c
> @@ -607,24 +607,24 @@ static int OPLOpenTable( void )
>  	double pom;
>  
>  	/* allocate dynamic tables */
> -	if( (TL_TABLE = malloc(TL_MAX*2*sizeof(int32_t))) == NULL)
> +	if( (TL_TABLE = g_new(int32_t, TL_MAX * 2)) == NULL)

g_new cannot fail, so all checks for NULL must be removed too.

Unless this is a performance critical path, we'll also prefer
g_new0 over g_new, so that all memory is guaranteed zero-initialized

>  		return 0;
> -	if( (SIN_TABLE = malloc(SIN_ENT*4 *sizeof(int32_t *))) == NULL)
> +	if( (SIN_TABLE = g_new(int32_t *, SIN_ENT * 4)) == NULL)
>  	{
> -		free(TL_TABLE);
> +		g_free(TL_TABLE);
>  		return 0;
>  	}
> -	if( (AMS_TABLE = malloc(AMS_ENT*2 *sizeof(int32_t))) == NULL)
> +	if( (AMS_TABLE = g_new(int32_t, AMS_ENT * 2)) == NULL)
>  	{
> -		free(TL_TABLE);
> -		free(SIN_TABLE);
> +		g_free(TL_TABLE);
> +		g_free(SIN_TABLE);
>  		return 0;
>  	}
> -	if( (VIB_TABLE = malloc(VIB_ENT*2 *sizeof(int32_t))) == NULL)
> +	if( (VIB_TABLE = g_new(int32_t, VIB_ENT * 2)) == NULL)
>  	{
> -		free(TL_TABLE);
> -		free(SIN_TABLE);
> -		free(AMS_TABLE);
> +		g_free(TL_TABLE);
> +		g_free(SIN_TABLE);
> +		g_free(AMS_TABLE);
>  		return 0;
>  	}
>      ENV_CURVE = g_new(int32_t, 2 * EG_ENT + 1);
> -- 
> 2.53.0
> 
> 
> 

With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|