accel/hvf: Reduce hvf_kernel_irqchip_override scope

[PATCH] accel/hvf: Reduce hvf_kernel_irqchip_override scope

Philippe Mathieu-Daudé posted 1 patch 1 month, 1 week ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260613145356.88410-1-philmd@oss.qualcomm.com

Maintainers: Roman Bolshakov <rbolshakov@ddn.com>, Phil Dennis-Jordan <phil@philjordan.eu>

include/system/hvf_int.h | 1 -
accel/hvf/hvf-all.c      | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)

Expand all Fold all

[PATCH] accel/hvf: Reduce hvf_kernel_irqchip_override scope

Posted by Philippe Mathieu-Daudé 1 month, 1 week ago

hvf_kernel_irqchip_override is only used within the
accel/hvf/hvf-all.c file, no need to expose the symbol.

Signed-off-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>
---
 include/system/hvf_int.h | 1 -
 accel/hvf/hvf-all.c      | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/system/hvf_int.h b/include/system/hvf_int.h
index d5eaf26dda8..58fb865ebae 100644
--- a/include/system/hvf_int.h
+++ b/include/system/hvf_int.h
@@ -113,5 +113,4 @@ bool hvf_arch_cpu_realize(CPUState *cpu, Error **errp);
 uint32_t hvf_arch_get_default_ipa_bit_size(void);
 uint32_t hvf_arch_get_max_ipa_bit_size(void);
 
-extern bool hvf_kernel_irqchip_override;
 #endif
diff --git a/accel/hvf/hvf-all.c b/accel/hvf/hvf-all.c
index 946dbca59d0..21b9b71a6df 100644
--- a/accel/hvf/hvf-all.c
+++ b/accel/hvf/hvf-all.c
@@ -25,7 +25,7 @@
 bool hvf_allowed;
 bool hvf_kernel_irqchip;
 bool hvf_nested_virt;
-bool hvf_kernel_irqchip_override;
+static bool hvf_kernel_irqchip_override;
 
 void hvf_nested_virt_enable(bool nested_virt)
 {
-- 
2.53.0

Re: [PATCH] accel/hvf: Reduce hvf_kernel_irqchip_override scope

Posted by Mohamed Mediouni 1 month, 1 week ago


> On 13. Jun 2026, at 16:53, Philippe Mathieu-Daudé <philmd@oss.qualcomm.com> wrote:
> 
> hvf_kernel_irqchip_override is only used within the
> accel/hvf/hvf-all.c file, no need to expose the symbol.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>

Reviewed-by: Mohamed Mediouni <mohamed@unpredictable.fr>
> ---
> include/system/hvf_int.h | 1 -
> accel/hvf/hvf-all.c      | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/include/system/hvf_int.h b/include/system/hvf_int.h
> index d5eaf26dda8..58fb865ebae 100644
> --- a/include/system/hvf_int.h
> +++ b/include/system/hvf_int.h
> @@ -113,5 +113,4 @@ bool hvf_arch_cpu_realize(CPUState *cpu, Error **errp);
> uint32_t hvf_arch_get_default_ipa_bit_size(void);
> uint32_t hvf_arch_get_max_ipa_bit_size(void);
> 
> -extern bool hvf_kernel_irqchip_override;
> #endif
> diff --git a/accel/hvf/hvf-all.c b/accel/hvf/hvf-all.c
> index 946dbca59d0..21b9b71a6df 100644
> --- a/accel/hvf/hvf-all.c
> +++ b/accel/hvf/hvf-all.c
> @@ -25,7 +25,7 @@
> bool hvf_allowed;
> bool hvf_kernel_irqchip;
> bool hvf_nested_virt;
> -bool hvf_kernel_irqchip_override;
> +static bool hvf_kernel_irqchip_override;
> 
> void hvf_nested_virt_enable(bool nested_virt)
> {
> -- 
> 2.53.0
> 
>