[v1] plugins: fix syscall filter return value type

[PATCH 0/1] plugins: fix syscall filter return value type

Ziyang Zhang posted 1 patch 1 month, 2 weeks ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260612055642.589337-1-functioner@sjtu.edu.cn

Maintainers: Laurent Vivier <laurent@vivier.eu>, Helge Deller <deller@gmx.de>, Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>, "Alex Bennée" <alex.bennee@linaro.org>, Alexandre Iooss <erdnaxe@crans.org>

There is a newer version of this series

include/plugins/qemu-plugin.h | 2 +-
include/qemu/plugin.h         | 4 ++--
linux-user/syscall.c          | 2 +-
plugins/core.c                | 2 +-
tests/tcg/plugins/setpc.c     | 2 +-
tests/tcg/plugins/syscall.c   | 2 +-
6 files changed, 7 insertions(+), 7 deletions(-)

Expand all Fold all

[PATCH 0/1] plugins: fix syscall filter return value type

Posted by Ziyang Zhang 1 month, 2 weeks ago

Hi,

The syscall filter plugin interface was introduced by me earlier. Its
sysret value is declared as uint64_t, but it is semantically signed --
negative values encode errno codes -- so it should be int64_t. This
also makes it consistent with the ret parameter of
qemu_plugin_vcpu_syscall_ret(), which is already int64_t.

I did not bump QEMU_PLUGIN_VERSION: this is only a signedness fix, and
a version bump is better left for the next significant plugin API
update.

Thanks for your review.

Ziyang Zhang (1):
  plugins: use int64_t for the syscall filter return value

 include/plugins/qemu-plugin.h | 2 +-
 include/qemu/plugin.h         | 4 ++--
 linux-user/syscall.c          | 2 +-
 plugins/core.c                | 2 +-
 tests/tcg/plugins/setpc.c     | 2 +-
 tests/tcg/plugins/syscall.c   | 2 +-
 6 files changed, 7 insertions(+), 7 deletions(-)

-- 
2.34.1

Re: [PATCH 0/1] plugins: fix syscall filter return value type

Posted by Ziyang Zhang 1 month, 2 weeks ago

On Fri, 12 Jun 2026 13:56:41 +0800, Ziyang Zhang wrote:
> Hi,
> 
> The syscall filter plugin interface was introduced by me earlier.

Syscall filter PATCH reference:
https://lore.kernel.org/qemu-devel/20251214144620.179282-1-functioner@sjtu.edu.cn/