iotests/108: avoid leaking FUSE mount

[PATCH] iotests/108: avoid leaking FUSE mount

Posted by Stefan Hajnoczi 1 month, 2 weeks ago

The QEMU s390x CI gitlab-runner recently broke because qemu-iotests 108
FUSE mount leaked and prevented the setup of the gitlab-runner
environment:

  chmod: cannot access '/home/gitlab-runner/builds/P3MFS4LUf/0/qemu-project/qemu/build/scratch/qcow2-file-108/fuse-export': Transport endpoint is not connected

https://gitlab.com/qemu-project/qemu/-/jobs/14796143507#L11

Always umount the FUSE export when cleaning up to prevent the leak.

Closes: https://gitlab.com/qemu-project/qemu/-/work_items/3541
Cc: Hanna Czenczek <hreitz@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 tests/qemu-iotests/108 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qemu-iotests/108 b/tests/qemu-iotests/108
index 54e935acf2..bf808b3512 100755
--- a/tests/qemu-iotests/108
+++ b/tests/qemu-iotests/108
@@ -34,8 +34,8 @@ _cleanup()
     if [ -f "$TEST_DIR/qsd.pid" ]; then
         qsd_pid=$(cat "$TEST_DIR/qsd.pid")
         kill -KILL "$qsd_pid"
-        fusermount -u "$TEST_DIR/fuse-export" &>/dev/null
     fi
+    fusermount -u "$TEST_DIR/fuse-export" &>/dev/null
     rm -f "$TEST_DIR/fuse-export"
 }
 trap "_cleanup; exit \$status" 0 1 2 3 15
-- 
2.54.0

Re: [PATCH] iotests/108: avoid leaking FUSE mount

Posted by Stefan Hajnoczi 5 days, 18 hours ago

On Thu, Jun 11, 2026 at 08:54:38AM -0400, Stefan Hajnoczi wrote:
> The QEMU s390x CI gitlab-runner recently broke because qemu-iotests 108
> FUSE mount leaked and prevented the setup of the gitlab-runner
> environment:
> 
>   chmod: cannot access '/home/gitlab-runner/builds/P3MFS4LUf/0/qemu-project/qemu/build/scratch/qcow2-file-108/fuse-export': Transport endpoint is not connected
> 
> https://gitlab.com/qemu-project/qemu/-/jobs/14796143507#L11
> 
> Always umount the FUSE export when cleaning up to prevent the leak.
> 
> Closes: https://gitlab.com/qemu-project/qemu/-/work_items/3541
> Cc: Hanna Czenczek <hreitz@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  tests/qemu-iotests/108 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks, applied to my block tree:
https://gitlab.com/stefanha/qemu/commits/block

Stefan

Re: [PATCH] iotests/108: avoid leaking FUSE mount

Posted by Daniel P. Berrangé 1 month, 2 weeks ago

On Thu, Jun 11, 2026 at 08:54:38AM -0400, Stefan Hajnoczi wrote:
> The QEMU s390x CI gitlab-runner recently broke because qemu-iotests 108
> FUSE mount leaked and prevented the setup of the gitlab-runner
> environment:
> 
>   chmod: cannot access '/home/gitlab-runner/builds/P3MFS4LUf/0/qemu-project/qemu/build/scratch/qcow2-file-108/fuse-export': Transport endpoint is not connected
> 
> https://gitlab.com/qemu-project/qemu/-/jobs/14796143507#L11
> 
> Always umount the FUSE export when cleaning up to prevent the leak.
> 
> Closes: https://gitlab.com/qemu-project/qemu/-/work_items/3541
> Cc: Hanna Czenczek <hreitz@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  tests/qemu-iotests/108 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|