1. Patchew
  2. QEMU
  3. View series

[PATCH] hw/misc/applesmc: replace DEVICE_NATIVE_ENDIAN with DEVICE_LITTLE_ENDIAN

Samyak posted 1 patch 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260531152210.264330-1-samyak.bambole07@gmail.com
There is a newer version of this series
hw/misc/applesmc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
[PATCH] hw/misc/applesmc: replace DEVICE_NATIVE_ENDIAN with DEVICE_LITTLE_ENDIAN
Posted by Samyak 1 week ago 
Use explicit DEVICE_LITTLE_ENDIAN same as other devices in /hw/i386,
since the Apple SMC is x86 only.

This was flagged by scripts/checkpatch.pl
---
 hw/misc/applesmc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/misc/applesmc.c b/hw/misc/applesmc.c
index fd96f5f245..aae7fad3a2 100644
--- a/hw/misc/applesmc.c
+++ b/hw/misc/applesmc.c
@@ -278,7 +278,7 @@ static void qdev_applesmc_isa_reset(DeviceState *dev)
 static const MemoryRegionOps applesmc_data_io_ops = {
     .write = applesmc_io_data_write,
     .read = applesmc_io_data_read,
-    .endianness = DEVICE_NATIVE_ENDIAN,
+    .endianness = DEVICE_LITTLE_ENDIAN,
     .impl = {
         .min_access_size = 1,
         .max_access_size = 1,
@@ -288,7 +288,7 @@ static const MemoryRegionOps applesmc_data_io_ops = {
 static const MemoryRegionOps applesmc_cmd_io_ops = {
     .write = applesmc_io_cmd_write,
     .read = applesmc_io_cmd_read,
-    .endianness = DEVICE_NATIVE_ENDIAN,
+    .endianness = DEVICE_LITTLE_ENDIAN,
     .impl = {
         .min_access_size = 1,
         .max_access_size = 1,
@@ -298,7 +298,7 @@ static const MemoryRegionOps applesmc_cmd_io_ops = {
 static const MemoryRegionOps applesmc_err_io_ops = {
     .write = applesmc_io_err_write,
     .read = applesmc_io_err_read,
-    .endianness = DEVICE_NATIVE_ENDIAN,
+    .endianness = DEVICE_LITTLE_ENDIAN,
     .impl = {
         .min_access_size = 1,
         .max_access_size = 1,
-- 
2.54.0
[PATCH v2] hw/misc/applesmc: replace DEVICE_NATIVE_ENDIAN with DEVICE_LITTLE_ENDIAN
Posted by Samyak 1 week ago 
Use explicit DEVICE_LITTLE_ENDIAN same as other devices in /hw/i386,
since the Apple SMC is x86 only.

This was flagged by scripts/checkpatch.pl

Signed-off-by: Samyak Bambole <samyak.bambole07@gmail.com>
---
v2: add missing Signed-off-by line

 hw/misc/applesmc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/misc/applesmc.c b/hw/misc/applesmc.c
index fd96f5f245..aae7fad3a2 100644
--- a/hw/misc/applesmc.c
+++ b/hw/misc/applesmc.c
@@ -278,7 +278,7 @@ static void qdev_applesmc_isa_reset(DeviceState *dev)
 static const MemoryRegionOps applesmc_data_io_ops = {
     .write = applesmc_io_data_write,
     .read = applesmc_io_data_read,
-    .endianness = DEVICE_NATIVE_ENDIAN,
+    .endianness = DEVICE_LITTLE_ENDIAN,
     .impl = {
         .min_access_size = 1,
         .max_access_size = 1,
@@ -288,7 +288,7 @@ static const MemoryRegionOps applesmc_data_io_ops = {
 static const MemoryRegionOps applesmc_cmd_io_ops = {
     .write = applesmc_io_cmd_write,
     .read = applesmc_io_cmd_read,
-    .endianness = DEVICE_NATIVE_ENDIAN,
+    .endianness = DEVICE_LITTLE_ENDIAN,
     .impl = {
         .min_access_size = 1,
         .max_access_size = 1,
@@ -298,7 +298,7 @@ static const MemoryRegionOps applesmc_cmd_io_ops = {
 static const MemoryRegionOps applesmc_err_io_ops = {
     .write = applesmc_io_err_write,
     .read = applesmc_io_err_read,
-    .endianness = DEVICE_NATIVE_ENDIAN,
+    .endianness = DEVICE_LITTLE_ENDIAN,
     .impl = {
         .min_access_size = 1,
         .max_access_size = 1,
-- 
2.54.0

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.