linux-user: Fix typo in function documentation for pgb_addr_set()

[PATCH] linux-user: Fix typo in function documentation for pgb_addr_set()

Posted by Helge Deller 4 days, 6 hours ago

From: Helge Deller <deller@gmx.de>

The third parameter is called guest_hiaddr.

Signed-off-by: Helge Deller <deller@gmx.de>
---
 linux-user/elfload.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index 0e757787d2..f7625c0952 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -848,7 +848,7 @@ static bool pgb_try_mmap_set(const PGBAddrs *ga, uintptr_t base, uintptr_t brk)
  * pgb_addr_set:
  * @ga: output set of guest addrs
  * @guest_loaddr: guest image low address
- * @guest_loaddr: guest image high address
+ * @guest_hiaddr: guest image high address
  * @identity: create for identity mapping
  *
  * Fill in @ga with the image, COMMPAGE and NULL page.
-- 
2.54.0

Re: [PATCH] linux-user: Fix typo in function documentation for pgb_addr_set()

Posted by Alex Bennée 4 days, 5 hours ago

Helge Deller <deller@kernel.org> writes:

> From: Helge Deller <deller@gmx.de>
>
> The third parameter is called guest_hiaddr.
>
> Signed-off-by: Helge Deller <deller@gmx.de>
> ---
>  linux-user/elfload.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/elfload.c b/linux-user/elfload.c
> index 0e757787d2..f7625c0952 100644
> --- a/linux-user/elfload.c
> +++ b/linux-user/elfload.c
> @@ -848,7 +848,7 @@ static bool pgb_try_mmap_set(const PGBAddrs *ga, uintptr_t base, uintptr_t brk)
>   * pgb_addr_set:
>   * @ga: output set of guest addrs
>   * @guest_loaddr: guest image low address
> - * @guest_loaddr: guest image high address
> + * @guest_hiaddr: guest image high address
>   * @identity: create for identity mapping
>   *
>   * Fill in @ga with the image, COMMPAGE and NULL page.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro

Re: [PATCH] linux-user: Fix typo in function documentation for pgb_addr_set()

Posted by Peter Maydell 4 days, 6 hours ago

On Tue, 26 May 2026 at 11:41, Helge Deller <deller@kernel.org> wrote:
>
> From: Helge Deller <deller@gmx.de>
>
> The third parameter is called guest_hiaddr.
>
> Signed-off-by: Helge Deller <deller@gmx.de>
> ---
>  linux-user/elfload.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/elfload.c b/linux-user/elfload.c
> index 0e757787d2..f7625c0952 100644
> --- a/linux-user/elfload.c
> +++ b/linux-user/elfload.c
> @@ -848,7 +848,7 @@ static bool pgb_try_mmap_set(const PGBAddrs *ga, uintptr_t base, uintptr_t brk)
>   * pgb_addr_set:
>   * @ga: output set of guest addrs
>   * @guest_loaddr: guest image low address
> - * @guest_loaddr: guest image high address
> + * @guest_hiaddr: guest image high address
>   * @identity: create for identity mapping
>   *
>   * Fill in @ga with the image, COMMPAGE and NULL page.
> --
> 2.54.0

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM