1. Patchew
  2. QEMU
  3. View series

[PATCH v1 00/23] hw/aspeed: Convert Aspeed devices to use Resettable interface

Kane Chen posted 23 patches 5 days, 12 hours ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260525044129.3133916-1-kane._5Fchen@aspeedtech.com
Maintainers: "Cédric Le Goater" <clg@kaod.org>, Peter Maydell <peter.maydell@linaro.org>, Steven Lee <steven_lee@aspeedtech.com>, Troy Lee <leetroy@gmail.com>, Jamin Lin <jamin_lin@aspeedtech.com>, Kane Chen <kane_chen@aspeedtech.com>, Andrew Jeffery <andrew@codeconstruct.com.au>, Joel Stanley <joel@jms.id.au>, Alistair Francis <alistair@alistair23.me>, Ninad Palsule <ninad@linux.ibm.com>, Joe Komlodi <komlodi@google.com>, Nabih Estefan <nabihestefan@google.com>, Jason Wang <jasowang@redhat.com>
hw/adc/aspeed_adc.c       |  7 ++++---
hw/fsi/aspeed_apb2opb.c   |  7 ++++---
hw/gpio/aspeed_gpio.c     |  7 ++++---
hw/i2c/aspeed_i2c.c       | 14 ++++++++------
hw/i3c/aspeed_i3c.c       |  7 ++++---
hw/intc/aspeed_intc.c     |  7 ++++---
hw/intc/aspeed_vic.c      |  7 ++++---
hw/misc/aspeed_hace.c     |  7 ++++---
hw/misc/aspeed_lpc.c      |  7 ++++---
hw/misc/aspeed_ltpi.c     |  7 ++++---
hw/misc/aspeed_peci.c     |  7 ++++---
hw/misc/aspeed_pwm.c      |  7 ++++---
hw/misc/aspeed_sbc.c      |  7 ++++---
hw/misc/aspeed_scu.c      | 39 ++++++++++++++++++++++-----------------
hw/misc/aspeed_sdmc.c     | 14 ++++++++------
hw/misc/aspeed_xdma.c     |  7 ++++---
hw/net/ftgmac100.c        | 14 ++++++++------
hw/pci-host/aspeed_pcie.c | 21 ++++++++++++---------
hw/rtc/aspeed_rtc.c       |  7 ++++---
hw/sd/aspeed_sdhci.c      |  7 ++++---
hw/ssi/aspeed_smc.c       |  7 ++++---
hw/timer/aspeed_timer.c   |  7 ++++---
hw/watchdog/wdt_aspeed.c  |  7 ++++---
23 files changed, 130 insertions(+), 98 deletions(-)
[PATCH v1 00/23] hw/aspeed: Convert Aspeed devices to use Resettable interface
Posted by Kane Chen 5 days, 12 hours ago 
Hi,

This series converts Aspeed device drivers from the legacy reset
callback registered via device_class_set_legacy_reset() to the
Resettable interface by setting rc->phases.hold directly.

Best Regards,
Kane
---

Kane-Chen-AS (23):
  hw/misc/aspeed_pwm: convert to use Resettable interface
  hw/misc/aspeed_peci: convert to use Resettable interface
  hw/misc/aspeed_hace: convert to use Resettable interface
  hw/misc/aspeed_sbc: convert to use Resettable interface
  hw/misc/aspeed_xdma: convert to use Resettable interface
  hw/misc/aspeed_lpc: convert to use Resettable interface
  hw/misc/aspeed_sdmc: convert to use Resettable interface
  hw/misc/aspeed_scu: convert to use Resettable interface
  hw/misc/aspeed_ltpi: convert to use Resettable interface
  hw/pci-host/aspeed_pcie: convert to use Resettable interface
  hw/timer/aspeed_timer: convert to use Resettable interface
  hw/gpio/aspeed_gpio: convert to use Resettable interface
  hw/sd/aspeed_sdhci: convert to use Resettable interface
  hw/ssi/aspeed_smc: convert to use Resettable interface
  hw/intc/aspeed_vic: convert to use Resettable interface
  hw/intc/aspeed_intc: convert to use Resettable interface
  hw/i3c/aspeed_i3c: convert to use Resettable interface
  hw/watchdog/wdt_aspeed: convert to use Resettable interface
  hw/net/ftgmac100: convert to use Resettable interface
  hw/fsi/aspeed_apb2opb: convert to use Resettable interface
  hw/rtc/aspeed_rtc: convert to use Resettable interface
  hw/adc/aspeed_adc: convert to use Resettable interface
  hw/i2c/aspeed_i2c: convert to use Resettable interface

 hw/adc/aspeed_adc.c       |  7 ++++---
 hw/fsi/aspeed_apb2opb.c   |  7 ++++---
 hw/gpio/aspeed_gpio.c     |  7 ++++---
 hw/i2c/aspeed_i2c.c       | 14 ++++++++------
 hw/i3c/aspeed_i3c.c       |  7 ++++---
 hw/intc/aspeed_intc.c     |  7 ++++---
 hw/intc/aspeed_vic.c      |  7 ++++---
 hw/misc/aspeed_hace.c     |  7 ++++---
 hw/misc/aspeed_lpc.c      |  7 ++++---
 hw/misc/aspeed_ltpi.c     |  7 ++++---
 hw/misc/aspeed_peci.c     |  7 ++++---
 hw/misc/aspeed_pwm.c      |  7 ++++---
 hw/misc/aspeed_sbc.c      |  7 ++++---
 hw/misc/aspeed_scu.c      | 39 ++++++++++++++++++++++-----------------
 hw/misc/aspeed_sdmc.c     | 14 ++++++++------
 hw/misc/aspeed_xdma.c     |  7 ++++---
 hw/net/ftgmac100.c        | 14 ++++++++------
 hw/pci-host/aspeed_pcie.c | 21 ++++++++++++---------
 hw/rtc/aspeed_rtc.c       |  7 ++++---
 hw/sd/aspeed_sdhci.c      |  7 ++++---
 hw/ssi/aspeed_smc.c       |  7 ++++---
 hw/timer/aspeed_timer.c   |  7 ++++---
 hw/watchdog/wdt_aspeed.c  |  7 ++++---
 23 files changed, 130 insertions(+), 98 deletions(-)

-- 
2.43.0
RE: [PATCH v1 00/23] hw/aspeed: Convert Aspeed devices to use Resettable interface
Posted by Jamin Lin 5 days, 12 hours ago 
> Subject: [PATCH v1 00/23] hw/aspeed: Convert Aspeed devices to use
> Resettable interface
> 
> Hi,
> 
> This series converts Aspeed device drivers from the legacy reset callback
> registered via device_class_set_legacy_reset() to the Resettable interface by
> setting rc->phases.hold directly.
> 
> Best Regards,
> Kane
> ---
> 
> Kane-Chen-AS (23):
>   hw/misc/aspeed_pwm: convert to use Resettable interface
>   hw/misc/aspeed_peci: convert to use Resettable interface
>   hw/misc/aspeed_hace: convert to use Resettable interface
>   hw/misc/aspeed_sbc: convert to use Resettable interface
>   hw/misc/aspeed_xdma: convert to use Resettable interface
>   hw/misc/aspeed_lpc: convert to use Resettable interface
>   hw/misc/aspeed_sdmc: convert to use Resettable interface
>   hw/misc/aspeed_scu: convert to use Resettable interface
>   hw/misc/aspeed_ltpi: convert to use Resettable interface
>   hw/pci-host/aspeed_pcie: convert to use Resettable interface
>   hw/timer/aspeed_timer: convert to use Resettable interface
>   hw/gpio/aspeed_gpio: convert to use Resettable interface
>   hw/sd/aspeed_sdhci: convert to use Resettable interface
>   hw/ssi/aspeed_smc: convert to use Resettable interface
>   hw/intc/aspeed_vic: convert to use Resettable interface
>   hw/intc/aspeed_intc: convert to use Resettable interface
>   hw/i3c/aspeed_i3c: convert to use Resettable interface
>   hw/watchdog/wdt_aspeed: convert to use Resettable interface
>   hw/net/ftgmac100: convert to use Resettable interface
>   hw/fsi/aspeed_apb2opb: convert to use Resettable interface
>   hw/rtc/aspeed_rtc: convert to use Resettable interface
>   hw/adc/aspeed_adc: convert to use Resettable interface
>   hw/i2c/aspeed_i2c: convert to use Resettable interface
> 
>  hw/adc/aspeed_adc.c       |  7 ++++---
>  hw/fsi/aspeed_apb2opb.c   |  7 ++++---
>  hw/gpio/aspeed_gpio.c     |  7 ++++---
>  hw/i2c/aspeed_i2c.c       | 14 ++++++++------
>  hw/i3c/aspeed_i3c.c       |  7 ++++---
>  hw/intc/aspeed_intc.c     |  7 ++++---
>  hw/intc/aspeed_vic.c      |  7 ++++---
>  hw/misc/aspeed_hace.c     |  7 ++++---
>  hw/misc/aspeed_lpc.c      |  7 ++++---
>  hw/misc/aspeed_ltpi.c     |  7 ++++---
>  hw/misc/aspeed_peci.c     |  7 ++++---
>  hw/misc/aspeed_pwm.c      |  7 ++++---
>  hw/misc/aspeed_sbc.c      |  7 ++++---
>  hw/misc/aspeed_scu.c      | 39 ++++++++++++++++++++++-----------------
>  hw/misc/aspeed_sdmc.c     | 14 ++++++++------
>  hw/misc/aspeed_xdma.c     |  7 ++++---
>  hw/net/ftgmac100.c        | 14 ++++++++------
>  hw/pci-host/aspeed_pcie.c | 21 ++++++++++++---------
>  hw/rtc/aspeed_rtc.c       |  7 ++++---
>  hw/sd/aspeed_sdhci.c      |  7 ++++---
>  hw/ssi/aspeed_smc.c       |  7 ++++---
>  hw/timer/aspeed_timer.c   |  7 ++++---
>  hw/watchdog/wdt_aspeed.c  |  7 ++++---
>  23 files changed, 130 insertions(+), 98 deletions(-)
> 
> --
> 2.43.0

This patch series

Reviewed-by Jamin Lin <jamin_lin@aspeedtech.com>

Thanks,
Jamin
Re: [PATCH v1 00/23] hw/aspeed: Convert Aspeed devices to use Resettable interface
Posted by Cédric Le Goater 4 days, 11 hours ago 
Jamin,

On 5/25/26 06:44, Jamin Lin wrote:
>> Subject: [PATCH v1 00/23] hw/aspeed: Convert Aspeed devices to use
>> Resettable interface
>>
>> Hi,
>>
>> This series converts Aspeed device drivers from the legacy reset callback
>> registered via device_class_set_legacy_reset() to the Resettable interface by
>> setting rc->phases.hold directly.
>>
>> Best Regards,
>> Kane
>> ---
>>
>> Kane-Chen-AS (23):
>>    hw/misc/aspeed_pwm: convert to use Resettable interface
>>    hw/misc/aspeed_peci: convert to use Resettable interface
>>    hw/misc/aspeed_hace: convert to use Resettable interface
>>    hw/misc/aspeed_sbc: convert to use Resettable interface
>>    hw/misc/aspeed_xdma: convert to use Resettable interface
>>    hw/misc/aspeed_lpc: convert to use Resettable interface
>>    hw/misc/aspeed_sdmc: convert to use Resettable interface
>>    hw/misc/aspeed_scu: convert to use Resettable interface
>>    hw/misc/aspeed_ltpi: convert to use Resettable interface
>>    hw/pci-host/aspeed_pcie: convert to use Resettable interface
>>    hw/timer/aspeed_timer: convert to use Resettable interface
>>    hw/gpio/aspeed_gpio: convert to use Resettable interface
>>    hw/sd/aspeed_sdhci: convert to use Resettable interface
>>    hw/ssi/aspeed_smc: convert to use Resettable interface
>>    hw/intc/aspeed_vic: convert to use Resettable interface
>>    hw/intc/aspeed_intc: convert to use Resettable interface
>>    hw/i3c/aspeed_i3c: convert to use Resettable interface
>>    hw/watchdog/wdt_aspeed: convert to use Resettable interface
>>    hw/net/ftgmac100: convert to use Resettable interface
>>    hw/fsi/aspeed_apb2opb: convert to use Resettable interface
>>    hw/rtc/aspeed_rtc: convert to use Resettable interface
>>    hw/adc/aspeed_adc: convert to use Resettable interface
>>    hw/i2c/aspeed_i2c: convert to use Resettable interface
>>
>>   hw/adc/aspeed_adc.c       |  7 ++++---
>>   hw/fsi/aspeed_apb2opb.c   |  7 ++++---
>>   hw/gpio/aspeed_gpio.c     |  7 ++++---
>>   hw/i2c/aspeed_i2c.c       | 14 ++++++++------
>>   hw/i3c/aspeed_i3c.c       |  7 ++++---
>>   hw/intc/aspeed_intc.c     |  7 ++++---
>>   hw/intc/aspeed_vic.c      |  7 ++++---
>>   hw/misc/aspeed_hace.c     |  7 ++++---
>>   hw/misc/aspeed_lpc.c      |  7 ++++---
>>   hw/misc/aspeed_ltpi.c     |  7 ++++---
>>   hw/misc/aspeed_peci.c     |  7 ++++---
>>   hw/misc/aspeed_pwm.c      |  7 ++++---
>>   hw/misc/aspeed_sbc.c      |  7 ++++---
>>   hw/misc/aspeed_scu.c      | 39 ++++++++++++++++++++++-----------------
>>   hw/misc/aspeed_sdmc.c     | 14 ++++++++------
>>   hw/misc/aspeed_xdma.c     |  7 ++++---
>>   hw/net/ftgmac100.c        | 14 ++++++++------
>>   hw/pci-host/aspeed_pcie.c | 21 ++++++++++++---------
>>   hw/rtc/aspeed_rtc.c       |  7 ++++---
>>   hw/sd/aspeed_sdhci.c      |  7 ++++---
>>   hw/ssi/aspeed_smc.c       |  7 ++++---
>>   hw/timer/aspeed_timer.c   |  7 ++++---
>>   hw/watchdog/wdt_aspeed.c  |  7 ++++---
>>   23 files changed, 130 insertions(+), 98 deletions(-)
>>
>> --
>> 2.43.0
> 
> This patch series
> 
> Reviewed-by Jamin Lin <jamin_lin@aspeedtech.com>
> 
> Thanks,
> Jamin


This email did not reach the mailing list for some reason. Could you resend
please ?

Thanks,

C.
RE: [PATCH v1 00/23] hw/aspeed: Convert Aspeed devices to use Resettable interface
Posted by Jamin Lin 4 days, 11 hours ago 
> From: Cédric Le Goater <clg@kaod.org>
> Sent: Tuesday, May 26, 2026 1:13 PM
> To: Jamin Lin <jamin_lin@aspeedtech.com>; Kane Chen
> <kane_chen@aspeedtech.com>; Peter Maydell <peter.maydell@linaro.org>;
> Steven Lee <steven_lee@aspeedtech.com>; Troy Lee <leetroy@gmail.com>;
> Andrew Jeffery <andrew@codeconstruct.com.au>; Joel Stanley
> <joel@jms.id.au>; Alistair Francis <alistair@alistair23.me>; Ninad Palsule
> <ninad@linux.ibm.com>; Joe Komlodi <komlodi@google.com>; Nabih Estefan
> <nabihestefan@google.com>; Jason Wang <jasowang@redhat.com>; open
> list:ASPEED BMCs <qemu-arm@nongnu.org>; open list:All patches CC here
> <qemu-devel@nongnu.org>
> Cc: Troy Lee <troy_lee@aspeedtech.com>
> Subject: Re: [PATCH v1 00/23] hw/aspeed: Convert Aspeed devices to use
> Resettable interface
> 
> Jamin,
> 
> On 5/25/26 06:44, Jamin Lin wrote:
> >> Subject: [PATCH v1 00/23] hw/aspeed: Convert Aspeed devices to use
> >> Resettable interface
> >>
> >> Hi,
> >>
> >> This series converts Aspeed device drivers from the legacy reset
> >> callback registered via device_class_set_legacy_reset() to the
> >> Resettable interface by setting rc->phases.hold directly.
> >>
> >> Best Regards,
> >> Kane
> >> ---
> >>
> >> Kane-Chen-AS (23):
> >>    hw/misc/aspeed_pwm: convert to use Resettable interface
> >>    hw/misc/aspeed_peci: convert to use Resettable interface
> >>    hw/misc/aspeed_hace: convert to use Resettable interface
> >>    hw/misc/aspeed_sbc: convert to use Resettable interface
> >>    hw/misc/aspeed_xdma: convert to use Resettable interface
> >>    hw/misc/aspeed_lpc: convert to use Resettable interface
> >>    hw/misc/aspeed_sdmc: convert to use Resettable interface
> >>    hw/misc/aspeed_scu: convert to use Resettable interface
> >>    hw/misc/aspeed_ltpi: convert to use Resettable interface
> >>    hw/pci-host/aspeed_pcie: convert to use Resettable interface
> >>    hw/timer/aspeed_timer: convert to use Resettable interface
> >>    hw/gpio/aspeed_gpio: convert to use Resettable interface
> >>    hw/sd/aspeed_sdhci: convert to use Resettable interface
> >>    hw/ssi/aspeed_smc: convert to use Resettable interface
> >>    hw/intc/aspeed_vic: convert to use Resettable interface
> >>    hw/intc/aspeed_intc: convert to use Resettable interface
> >>    hw/i3c/aspeed_i3c: convert to use Resettable interface
> >>    hw/watchdog/wdt_aspeed: convert to use Resettable interface
> >>    hw/net/ftgmac100: convert to use Resettable interface
> >>    hw/fsi/aspeed_apb2opb: convert to use Resettable interface
> >>    hw/rtc/aspeed_rtc: convert to use Resettable interface
> >>    hw/adc/aspeed_adc: convert to use Resettable interface
> >>    hw/i2c/aspeed_i2c: convert to use Resettable interface
> >>
> >>   hw/adc/aspeed_adc.c       |  7 ++++---
> >>   hw/fsi/aspeed_apb2opb.c   |  7 ++++---
> >>   hw/gpio/aspeed_gpio.c     |  7 ++++---
> >>   hw/i2c/aspeed_i2c.c       | 14 ++++++++------
> >>   hw/i3c/aspeed_i3c.c       |  7 ++++---
> >>   hw/intc/aspeed_intc.c     |  7 ++++---
> >>   hw/intc/aspeed_vic.c      |  7 ++++---
> >>   hw/misc/aspeed_hace.c     |  7 ++++---
> >>   hw/misc/aspeed_lpc.c      |  7 ++++---
> >>   hw/misc/aspeed_ltpi.c     |  7 ++++---
> >>   hw/misc/aspeed_peci.c     |  7 ++++---
> >>   hw/misc/aspeed_pwm.c      |  7 ++++---
> >>   hw/misc/aspeed_sbc.c      |  7 ++++---
> >>   hw/misc/aspeed_scu.c      | 39
> ++++++++++++++++++++++-----------------
> >>   hw/misc/aspeed_sdmc.c     | 14 ++++++++------
> >>   hw/misc/aspeed_xdma.c     |  7 ++++---
> >>   hw/net/ftgmac100.c        | 14 ++++++++------
> >>   hw/pci-host/aspeed_pcie.c | 21 ++++++++++++---------
> >>   hw/rtc/aspeed_rtc.c       |  7 ++++---
> >>   hw/sd/aspeed_sdhci.c      |  7 ++++---
> >>   hw/ssi/aspeed_smc.c       |  7 ++++---
> >>   hw/timer/aspeed_timer.c   |  7 ++++---
> >>   hw/watchdog/wdt_aspeed.c  |  7 ++++---
> >>   23 files changed, 130 insertions(+), 98 deletions(-)
> >>
> >> --
> >> 2.43.0
> >
> > This patch series
> >
> > Reviewed-by Jamin Lin <jamin_lin@aspeedtech.com>
> >
> > Thanks,
> > Jamin
> 
> 
> This email did not reach the mailing list for some reason. Could you resend
> please ?
> 

Reviewed-by Jamin Lin <jamin_lin@aspeedtech.com>

Thanks,
Jamin

> Thanks,
> 
> C.
Re: [PATCH v1 00/23] hw/aspeed: Convert Aspeed devices to use Resettable interface
Posted by Cédric Le Goater 4 days, 11 hours ago 
On 5/26/26 07:14, Jamin Lin wrote:
>> From: Cédric Le Goater <clg@kaod.org>
>> Sent: Tuesday, May 26, 2026 1:13 PM
>> To: Jamin Lin <jamin_lin@aspeedtech.com>; Kane Chen
>> <kane_chen@aspeedtech.com>; Peter Maydell <peter.maydell@linaro.org>;
>> Steven Lee <steven_lee@aspeedtech.com>; Troy Lee <leetroy@gmail.com>;
>> Andrew Jeffery <andrew@codeconstruct.com.au>; Joel Stanley
>> <joel@jms.id.au>; Alistair Francis <alistair@alistair23.me>; Ninad Palsule
>> <ninad@linux.ibm.com>; Joe Komlodi <komlodi@google.com>; Nabih Estefan
>> <nabihestefan@google.com>; Jason Wang <jasowang@redhat.com>; open
>> list:ASPEED BMCs <qemu-arm@nongnu.org>; open list:All patches CC here
>> <qemu-devel@nongnu.org>
>> Cc: Troy Lee <troy_lee@aspeedtech.com>
>> Subject: Re: [PATCH v1 00/23] hw/aspeed: Convert Aspeed devices to use
>> Resettable interface
>>
>> Jamin,
>>
>> On 5/25/26 06:44, Jamin Lin wrote:
>>>> Subject: [PATCH v1 00/23] hw/aspeed: Convert Aspeed devices to use
>>>> Resettable interface
>>>>
>>>> Hi,
>>>>
>>>> This series converts Aspeed device drivers from the legacy reset
>>>> callback registered via device_class_set_legacy_reset() to the
>>>> Resettable interface by setting rc->phases.hold directly.
>>>>
>>>> Best Regards,
>>>> Kane
>>>> ---
>>>>
>>>> Kane-Chen-AS (23):
>>>>     hw/misc/aspeed_pwm: convert to use Resettable interface
>>>>     hw/misc/aspeed_peci: convert to use Resettable interface
>>>>     hw/misc/aspeed_hace: convert to use Resettable interface
>>>>     hw/misc/aspeed_sbc: convert to use Resettable interface
>>>>     hw/misc/aspeed_xdma: convert to use Resettable interface
>>>>     hw/misc/aspeed_lpc: convert to use Resettable interface
>>>>     hw/misc/aspeed_sdmc: convert to use Resettable interface
>>>>     hw/misc/aspeed_scu: convert to use Resettable interface
>>>>     hw/misc/aspeed_ltpi: convert to use Resettable interface
>>>>     hw/pci-host/aspeed_pcie: convert to use Resettable interface
>>>>     hw/timer/aspeed_timer: convert to use Resettable interface
>>>>     hw/gpio/aspeed_gpio: convert to use Resettable interface
>>>>     hw/sd/aspeed_sdhci: convert to use Resettable interface
>>>>     hw/ssi/aspeed_smc: convert to use Resettable interface
>>>>     hw/intc/aspeed_vic: convert to use Resettable interface
>>>>     hw/intc/aspeed_intc: convert to use Resettable interface
>>>>     hw/i3c/aspeed_i3c: convert to use Resettable interface
>>>>     hw/watchdog/wdt_aspeed: convert to use Resettable interface
>>>>     hw/net/ftgmac100: convert to use Resettable interface
>>>>     hw/fsi/aspeed_apb2opb: convert to use Resettable interface
>>>>     hw/rtc/aspeed_rtc: convert to use Resettable interface
>>>>     hw/adc/aspeed_adc: convert to use Resettable interface
>>>>     hw/i2c/aspeed_i2c: convert to use Resettable interface
>>>>
>>>>    hw/adc/aspeed_adc.c       |  7 ++++---
>>>>    hw/fsi/aspeed_apb2opb.c   |  7 ++++---
>>>>    hw/gpio/aspeed_gpio.c     |  7 ++++---
>>>>    hw/i2c/aspeed_i2c.c       | 14 ++++++++------
>>>>    hw/i3c/aspeed_i3c.c       |  7 ++++---
>>>>    hw/intc/aspeed_intc.c     |  7 ++++---
>>>>    hw/intc/aspeed_vic.c      |  7 ++++---
>>>>    hw/misc/aspeed_hace.c     |  7 ++++---
>>>>    hw/misc/aspeed_lpc.c      |  7 ++++---
>>>>    hw/misc/aspeed_ltpi.c     |  7 ++++---
>>>>    hw/misc/aspeed_peci.c     |  7 ++++---
>>>>    hw/misc/aspeed_pwm.c      |  7 ++++---
>>>>    hw/misc/aspeed_sbc.c      |  7 ++++---
>>>>    hw/misc/aspeed_scu.c      | 39
>> ++++++++++++++++++++++-----------------
>>>>    hw/misc/aspeed_sdmc.c     | 14 ++++++++------
>>>>    hw/misc/aspeed_xdma.c     |  7 ++++---
>>>>    hw/net/ftgmac100.c        | 14 ++++++++------
>>>>    hw/pci-host/aspeed_pcie.c | 21 ++++++++++++---------
>>>>    hw/rtc/aspeed_rtc.c       |  7 ++++---
>>>>    hw/sd/aspeed_sdhci.c      |  7 ++++---
>>>>    hw/ssi/aspeed_smc.c       |  7 ++++---
>>>>    hw/timer/aspeed_timer.c   |  7 ++++---
>>>>    hw/watchdog/wdt_aspeed.c  |  7 ++++---
>>>>    23 files changed, 130 insertions(+), 98 deletions(-)
>>>>
>>>> --
>>>> 2.43.0
>>>
>>> This patch series
>>>
>>> Reviewed-by Jamin Lin <jamin_lin@aspeedtech.com>
>>>
>>> Thanks,
>>> Jamin
>>
>>
>> This email did not reach the mailing list for some reason. Could you resend
>> please ?
>>
> 
> Reviewed-by Jamin Lin <jamin_lin@aspeedtech.com>
> 
> Thanks,
> Jamin
> 
>> Thanks,
>>
>> C.

Reviewed-by: Jamin Lin <jamin_lin@aspeedtech.com>

C.
RE: [PATCH v1 00/23] hw/aspeed: Convert Aspeed devices to use Resettable interface
Posted by Jamin Lin 4 days, 11 hours ago 
> Subject: Re: [PATCH v1 00/23] hw/aspeed: Convert Aspeed devices to use
> Resettable interface
> 
> On 5/26/26 07:14, Jamin Lin wrote:
> >> From: Cédric Le Goater <clg@kaod.org>
> >> Sent: Tuesday, May 26, 2026 1:13 PM
> >> To: Jamin Lin <jamin_lin@aspeedtech.com>; Kane Chen
> >> <kane_chen@aspeedtech.com>; Peter Maydell <peter.maydell@linaro.org>;
> >> Steven Lee <steven_lee@aspeedtech.com>; Troy Lee
> <leetroy@gmail.com>;
> >> Andrew Jeffery <andrew@codeconstruct.com.au>; Joel Stanley
> >> <joel@jms.id.au>; Alistair Francis <alistair@alistair23.me>; Ninad
> >> Palsule <ninad@linux.ibm.com>; Joe Komlodi <komlodi@google.com>;
> >> Nabih Estefan <nabihestefan@google.com>; Jason Wang
> >> <jasowang@redhat.com>; open list:ASPEED BMCs
> <qemu-arm@nongnu.org>;
> >> open list:All patches CC here <qemu-devel@nongnu.org>
> >> Cc: Troy Lee <troy_lee@aspeedtech.com>
> >> Subject: Re: [PATCH v1 00/23] hw/aspeed: Convert Aspeed devices to
> >> use Resettable interface
> >>
> >> Jamin,
> >>
> >> On 5/25/26 06:44, Jamin Lin wrote:
> >>>> Subject: [PATCH v1 00/23] hw/aspeed: Convert Aspeed devices to use
> >>>> Resettable interface
> >>>>
> >>>> Hi,
> >>>>
> >>>> This series converts Aspeed device drivers from the legacy reset
> >>>> callback registered via device_class_set_legacy_reset() to the
> >>>> Resettable interface by setting rc->phases.hold directly.
> >>>>
> >>>> Best Regards,
> >>>> Kane
> >>>> ---
> >>>>
> >>>> Kane-Chen-AS (23):
> >>>>     hw/misc/aspeed_pwm: convert to use Resettable interface
> >>>>     hw/misc/aspeed_peci: convert to use Resettable interface
> >>>>     hw/misc/aspeed_hace: convert to use Resettable interface
> >>>>     hw/misc/aspeed_sbc: convert to use Resettable interface
> >>>>     hw/misc/aspeed_xdma: convert to use Resettable interface
> >>>>     hw/misc/aspeed_lpc: convert to use Resettable interface
> >>>>     hw/misc/aspeed_sdmc: convert to use Resettable interface
> >>>>     hw/misc/aspeed_scu: convert to use Resettable interface
> >>>>     hw/misc/aspeed_ltpi: convert to use Resettable interface
> >>>>     hw/pci-host/aspeed_pcie: convert to use Resettable interface
> >>>>     hw/timer/aspeed_timer: convert to use Resettable interface
> >>>>     hw/gpio/aspeed_gpio: convert to use Resettable interface
> >>>>     hw/sd/aspeed_sdhci: convert to use Resettable interface
> >>>>     hw/ssi/aspeed_smc: convert to use Resettable interface
> >>>>     hw/intc/aspeed_vic: convert to use Resettable interface
> >>>>     hw/intc/aspeed_intc: convert to use Resettable interface
> >>>>     hw/i3c/aspeed_i3c: convert to use Resettable interface
> >>>>     hw/watchdog/wdt_aspeed: convert to use Resettable interface
> >>>>     hw/net/ftgmac100: convert to use Resettable interface
> >>>>     hw/fsi/aspeed_apb2opb: convert to use Resettable interface
> >>>>     hw/rtc/aspeed_rtc: convert to use Resettable interface
> >>>>     hw/adc/aspeed_adc: convert to use Resettable interface
> >>>>     hw/i2c/aspeed_i2c: convert to use Resettable interface
> >>>>
> >>>>    hw/adc/aspeed_adc.c       |  7 ++++---
> >>>>    hw/fsi/aspeed_apb2opb.c   |  7 ++++---
> >>>>    hw/gpio/aspeed_gpio.c     |  7 ++++---
> >>>>    hw/i2c/aspeed_i2c.c       | 14 ++++++++------
> >>>>    hw/i3c/aspeed_i3c.c       |  7 ++++---
> >>>>    hw/intc/aspeed_intc.c     |  7 ++++---
> >>>>    hw/intc/aspeed_vic.c      |  7 ++++---
> >>>>    hw/misc/aspeed_hace.c     |  7 ++++---
> >>>>    hw/misc/aspeed_lpc.c      |  7 ++++---
> >>>>    hw/misc/aspeed_ltpi.c     |  7 ++++---
> >>>>    hw/misc/aspeed_peci.c     |  7 ++++---
> >>>>    hw/misc/aspeed_pwm.c      |  7 ++++---
> >>>>    hw/misc/aspeed_sbc.c      |  7 ++++---
> >>>>    hw/misc/aspeed_scu.c      | 39
> >> ++++++++++++++++++++++-----------------
> >>>>    hw/misc/aspeed_sdmc.c     | 14 ++++++++------
> >>>>    hw/misc/aspeed_xdma.c     |  7 ++++---
> >>>>    hw/net/ftgmac100.c        | 14 ++++++++------
> >>>>    hw/pci-host/aspeed_pcie.c | 21 ++++++++++++---------
> >>>>    hw/rtc/aspeed_rtc.c       |  7 ++++---
> >>>>    hw/sd/aspeed_sdhci.c      |  7 ++++---
> >>>>    hw/ssi/aspeed_smc.c       |  7 ++++---
> >>>>    hw/timer/aspeed_timer.c   |  7 ++++---
> >>>>    hw/watchdog/wdt_aspeed.c  |  7 ++++---
> >>>>    23 files changed, 130 insertions(+), 98 deletions(-)
> >>>>
> >>>> --
> >>>> 2.43.0
> >>>
> >>> This patch series
> >>>
> >>> Reviewed-by Jamin Lin <jamin_lin@aspeedtech.com>
> >>>
> >>> Thanks,
> >>> Jamin
> >>
> >>
> >> This email did not reach the mailing list for some reason. Could you
> >> resend please ?
> >>
> >
> > Reviewed-by Jamin Lin <jamin_lin@aspeedtech.com>
> >
> > Thanks,
> > Jamin
> >
> >> Thanks,
> >>
> >> C.
> 
> Reviewed-by: Jamin Lin <jamin_lin@aspeedtech.com>
> 


Sorry I lost ":"

Thanks for help.

Jamin
> C.
Re: [PATCH v1 00/23] hw/aspeed: Convert Aspeed devices to use Resettable interface
Posted by Cédric Le Goater 4 days, 11 hours ago 
On 5/25/26 06:41, Kane Chen wrote:
> Hi,
> 
> This series converts Aspeed device drivers from the legacy reset
> callback registered via device_class_set_legacy_reset() to the
> Resettable interface by setting rc->phases.hold directly.
> 
> Best Regards,
> Kane
> ---
> 
> Kane-Chen-AS (23):
>    hw/misc/aspeed_pwm: convert to use Resettable interface
>    hw/misc/aspeed_peci: convert to use Resettable interface
>    hw/misc/aspeed_hace: convert to use Resettable interface
>    hw/misc/aspeed_sbc: convert to use Resettable interface
>    hw/misc/aspeed_xdma: convert to use Resettable interface
>    hw/misc/aspeed_lpc: convert to use Resettable interface
>    hw/misc/aspeed_sdmc: convert to use Resettable interface
>    hw/misc/aspeed_scu: convert to use Resettable interface
>    hw/misc/aspeed_ltpi: convert to use Resettable interface
>    hw/pci-host/aspeed_pcie: convert to use Resettable interface
>    hw/timer/aspeed_timer: convert to use Resettable interface
>    hw/gpio/aspeed_gpio: convert to use Resettable interface
>    hw/sd/aspeed_sdhci: convert to use Resettable interface
>    hw/ssi/aspeed_smc: convert to use Resettable interface
>    hw/intc/aspeed_vic: convert to use Resettable interface
>    hw/intc/aspeed_intc: convert to use Resettable interface
>    hw/i3c/aspeed_i3c: convert to use Resettable interface
>    hw/watchdog/wdt_aspeed: convert to use Resettable interface
>    hw/net/ftgmac100: convert to use Resettable interface
>    hw/fsi/aspeed_apb2opb: convert to use Resettable interface
>    hw/rtc/aspeed_rtc: convert to use Resettable interface
>    hw/adc/aspeed_adc: convert to use Resettable interface
>    hw/i2c/aspeed_i2c: convert to use Resettable interface
> 
>   hw/adc/aspeed_adc.c       |  7 ++++---
>   hw/fsi/aspeed_apb2opb.c   |  7 ++++---
>   hw/gpio/aspeed_gpio.c     |  7 ++++---
>   hw/i2c/aspeed_i2c.c       | 14 ++++++++------
>   hw/i3c/aspeed_i3c.c       |  7 ++++---
>   hw/intc/aspeed_intc.c     |  7 ++++---
>   hw/intc/aspeed_vic.c      |  7 ++++---
>   hw/misc/aspeed_hace.c     |  7 ++++---
>   hw/misc/aspeed_lpc.c      |  7 ++++---
>   hw/misc/aspeed_ltpi.c     |  7 ++++---
>   hw/misc/aspeed_peci.c     |  7 ++++---
>   hw/misc/aspeed_pwm.c      |  7 ++++---
>   hw/misc/aspeed_sbc.c      |  7 ++++---
>   hw/misc/aspeed_scu.c      | 39 ++++++++++++++++++++++-----------------
>   hw/misc/aspeed_sdmc.c     | 14 ++++++++------
>   hw/misc/aspeed_xdma.c     |  7 ++++---
>   hw/net/ftgmac100.c        | 14 ++++++++------
>   hw/pci-host/aspeed_pcie.c | 21 ++++++++++++---------
>   hw/rtc/aspeed_rtc.c       |  7 ++++---
>   hw/sd/aspeed_sdhci.c      |  7 ++++---
>   hw/ssi/aspeed_smc.c       |  7 ++++---
>   hw/timer/aspeed_timer.c   |  7 ++++---
>   hw/watchdog/wdt_aspeed.c  |  7 ++++---
>   23 files changed, 130 insertions(+), 98 deletions(-)
> 



Applied to

     https://github.com/legoater/qemu aspeed-next

Thanks,

C.

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.