test/dbus-vnc-test: skip it for now

[PATCH] test/dbus-vnc-test: skip it for now

marcandre.lureau@redhat.com posted 1 patch 2 weeks, 3 days ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260513082517.1720433-1-marcandre.lureau@redhat.com

Maintainers: "Marc-André Lureau" <marcandre.lureau@redhat.com>, Fabiano Rosas <farosas@suse.de>, Laurent Vivier <lvivier@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

tests/qtest/dbus-vnc-test.c | 10 ++++++++++
1 file changed, 10 insertions(+)

Expand all Fold all

[PATCH] test/dbus-vnc-test: skip it for now

Posted by marcandre.lureau@redhat.com 2 weeks, 3 days ago

From: Marc-André Lureau <marcandre.lureau@redhat.com>

For some reason, the VNC auth setup sometime fails in CI.
Disable until it is figured out.

Reported-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 tests/qtest/dbus-vnc-test.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/tests/qtest/dbus-vnc-test.c b/tests/qtest/dbus-vnc-test.c
index 2a1bf67b9d7..8953a4b6265 100644
--- a/tests/qtest/dbus-vnc-test.c
+++ b/tests/qtest/dbus-vnc-test.c
@@ -1309,6 +1309,16 @@ main(int argc, char **argv)
 {
     g_log_set_always_fatal(G_LOG_LEVEL_WARNING | G_LOG_LEVEL_CRITICAL);
 
+    /*
+     * Flaky test:
+     * ERROR:../tests/qtest/dbus-vnc-test.c:621:test_dbus_vnc_password_auth:
+     * assertion failed (qemu_vnc1_server_get_auth(proxy) == "vnc"): ("none" ==
+     * "vnc")
+     */
+    if (!getenv("QEMU_TEST_FLAKY_TESTS")) {
+        g_test_skip("QEMU_TEST_FLAKY_TESTS not set");
+        return 0;
+    }
     if (getenv("GTK_VNC_DEBUG")) {
         vnc_util_set_debug(true);
     }
-- 
2.54.0

Re: [PATCH] test/dbus-vnc-test: skip it for now

Posted by Stefan Hajnoczi 2 weeks, 2 days ago

On Wed, May 13, 2026 at 4:26 AM <marcandre.lureau@redhat.com> wrote:
>
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> For some reason, the VNC auth setup sometime fails in CI.
> Disable until it is figured out.
>
> Reported-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  tests/qtest/dbus-vnc-test.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)

Applied, thanks!

Stefan

> diff --git a/tests/qtest/dbus-vnc-test.c b/tests/qtest/dbus-vnc-test.c
> index 2a1bf67b9d7..8953a4b6265 100644
> --- a/tests/qtest/dbus-vnc-test.c
> +++ b/tests/qtest/dbus-vnc-test.c
> @@ -1309,6 +1309,16 @@ main(int argc, char **argv)
>  {
>      g_log_set_always_fatal(G_LOG_LEVEL_WARNING | G_LOG_LEVEL_CRITICAL);
>
> +    /*
> +     * Flaky test:
> +     * ERROR:../tests/qtest/dbus-vnc-test.c:621:test_dbus_vnc_password_auth:
> +     * assertion failed (qemu_vnc1_server_get_auth(proxy) == "vnc"): ("none" ==
> +     * "vnc")
> +     */
> +    if (!getenv("QEMU_TEST_FLAKY_TESTS")) {
> +        g_test_skip("QEMU_TEST_FLAKY_TESTS not set");
> +        return 0;
> +    }
>      if (getenv("GTK_VNC_DEBUG")) {
>          vnc_util_set_debug(true);
>      }
> --
> 2.54.0
>
>