[PATCH v4 00/10] qom: misc cleanups / fixes

Daniel P. Berrangé posted 10 patches 1 week, 6 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260512122958.788097-1-berrange@redhat.com
Maintainers: "Daniel P. Berrangé" <berrange@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
authz/listfile.c                |   4 +-
include/qom/object.h            | 121 ++++++++++++++---
include/qom/object_interfaces.h |  18 ---
qom/object.c                    | 230 ++++++++++++++++++++++++++++----
qom/object_interfaces.c         | 101 +-------------
qom/trace-events                |  12 +-
system/qdev-monitor.c           |   4 +-
system/vl.c                     |   7 +-
tests/unit/check-qom-proplist.c |  97 +++++++++++---
9 files changed, 409 insertions(+), 185 deletions(-)
[PATCH v4 00/10] qom: misc cleanups / fixes
Posted by Daniel P. Berrangé 1 week, 6 days ago
The overall theme of this patch is to move some logic out of
object_interfaces.c into object.c, since it is not tied to
the user creatable interface.

Changed in v4:

 - Invoke  va_end on the correct variable
 - Fix commit message typo

Changed in v3:

 - Fix parent/child mixup in trace event param names
 - Make QDict const in new constructors

Changed in v2:

 - Ensure object creation always triggers module loading
 - Remove redundant NULL check in trace event
 - Remove double #include line

Daniel P. Berrangé (10):
  qom: add trace events for object/property lifecycle
  qom: validate ID format when creating objects
  qom: make errp last param in methods taking va_list
  qom: shorten name of object_set_properties_from_keyval
  qom: have object_set_props_keyval return bool
  qom: move object_set_prop_keyval into object.c
  qom: add object_new_with_props_from_qdict
  qom: fix ability to create objects without a parent
  qom: allow object_new_with_prop* to trigger module loading
  qom: drop user_creatable_add_type method

 authz/listfile.c                |   4 +-
 include/qom/object.h            | 121 ++++++++++++++---
 include/qom/object_interfaces.h |  18 ---
 qom/object.c                    | 230 ++++++++++++++++++++++++++++----
 qom/object_interfaces.c         | 101 +-------------
 qom/trace-events                |  12 +-
 system/qdev-monitor.c           |   4 +-
 system/vl.c                     |   7 +-
 tests/unit/check-qom-proplist.c |  97 +++++++++++---
 9 files changed, 409 insertions(+), 185 deletions(-)

-- 
2.54.0


Re: [PATCH v4 00/10] qom: misc cleanups / fixes
Posted by marcandre.lureau@redhat.com 1 week, 6 days ago
On Tue, 12 May 2026 13:29:48 +0100, Daniel P. Berrangé <berrange@redhat.com> wrote:
> qom: misc cleanups / fixes
> 
> The overall theme of this patch is to move some logic out of
> object_interfaces.c into object.c, since it is not tied to
> the user creatable interface.
> 
> Changed in v4:
> 
> [...]

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

-- 
Marc-André Lureau <marcandre.lureau@redhat.com>