[PULL 00/24] Qom patches

marcandre.lureau@redhat.com posted 24 patches 2 weeks, 4 days ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260511202111.3091440-1-marcandre.lureau@redhat.com
Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, Stefano Garzarella <sgarzare@redhat.com>, Ani Sinha <anisinha@redhat.com>, Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>, "Cédric Le Goater" <clg@kaod.org>, Peter Maydell <peter.maydell@linaro.org>, Steven Lee <steven_lee@aspeedtech.com>, Troy Lee <leetroy@gmail.com>, Jamin Lin <jamin_lin@aspeedtech.com>, Kane Chen <kane_chen@aspeedtech.com>, Andrew Jeffery <andrew@codeconstruct.com.au>, Joel Stanley <joel@jms.id.au>, Leif Lindholm <leif.lindholm@oss.qualcomm.com>, Ninad Palsule <ninad@linux.ibm.com>, Glenn Miles <milesg@linux.ibm.com>, Richard Henderson <richard.henderson@linaro.org>, "Michael S. Tsirkin" <mst@redhat.com>, Nicholas Piggin <npiggin@gmail.com>, Aditya Gupta <adityag@linux.ibm.com>, Elena Ufimtseva <elena.ufimtseva@oracle.com>, Jagannathan Raman <jag.raman@oracle.com>, Palmer Dabbelt <palmer@dabbelt.com>, Alistair Francis <alistair.francis@wdc.com>, Weiwei Li <liwei1518@gmail.com>, Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com>, Liu Zhiwei <zhiwei_liu@linux.alibaba.com>, Chao Liu <chao.liu.zevorn@gmail.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Pavel Pisa <pisa@cmp.felk.cvut.cz>, Francisco Iglesias <francisco.iglesias@amd.com>, Vikram Garhwal <vikram.garhwal@bytedance.com>, Jason Wang <jasowang@redhat.com>, Zhang Chen <zhangckid@gmail.com>, Li Zhijian <lizhijian@fujitsu.com>, Fam Zheng <fam@euphon.net>, Peter Xu <peterx@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Fabiano Rosas <farosas@suse.de>, Laurent Vivier <lvivier@redhat.com>, Ilya Leoshkevich <iii@linux.ibm.com>, David Hildenbrand <david@kernel.org>, Cornelia Huck <cohuck@redhat.com>, Eric Farman <farman@linux.ibm.com>, Matthew Rosato <mjrosato@linux.ibm.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>
docs/meson.build          | 14 +-------------
include/qom/object.h      |  8 ++++----
accel/kvm/kvm-all.c       |  8 ++++++++
backends/igvm-cfg.c       |  1 +
hw/arm/aspeed.c           |  9 +++++++++
hw/arm/sbsa-ref.c         | 12 ++++++++++++
hw/arm/virt.c             | 14 ++++++++++++++
hw/core/resetcontainer.c  |  3 +++
hw/fsi/aspeed_apb2opb.c   | 37 ++++++++++++++++++++++++-------------
hw/gpio/pca9552.c         |  2 +-
hw/i386/x86.c             |  9 +++++++++
hw/ppc/pnv.c              |  1 +
hw/remote/remote-obj.c    |  4 +++-
hw/remote/vfio-user-obj.c |  4 +++-
hw/riscv/virt.c           | 14 ++++++++++++++
io/net-listener.c         |  9 ++++++++-
net/can/can_socketcan.c   |  8 ++++++++
net/colo-compare.c        | 31 +++++++++++++++----------------
scsi/pr-manager-helper.c  |  1 +
system/ioport.c           | 11 +++++++++--
system/qtest.c            | 10 ++++++++++
ui/console.c              |  5 ++++-
target/s390x/meson.build  |  1 +
23 files changed, 163 insertions(+), 53 deletions(-)
[PULL 00/24] Qom patches
Posted by marcandre.lureau@redhat.com 2 weeks, 4 days ago
From: Marc-André Lureau <marcandre.lureau@redhat.com>

The following changes since commit 5e61afe211e82a9af15a8794a0bd29bb574e953b:

  Merge tag 'ui-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-05-11 10:49:53 -0400)

are available in the Git repository at:

  https://gitlab.com/marcandre.lureau/qemu.git tags/qom-pull-request

for you to fetch changes up to bc61a3209bf064826481a5f8f2b4feb47c70b02f:

  target/s390x: add gen-features.h dependency to s390x_system_ss (2026-05-11 23:59:33 +0400)

----------------------------------------------------------------
QOM object lifecycle fixes

----------------------------------------------------------------

Marc-André Lureau (23):
  hw/remote: check visit return in vfu_object_set_socket
  qom/object: update doc about NULL values in link properties
  hw/remote: guard listener unregister in finalize
  io/net-listener: move mutex init to instance_init
  net/colo-compare: guard finalize against uninitialized state
  ui/console: remove console from global list on finalization
  hw/i386/x86: free oem_id and oem_table_id on finalization
  hw/core/resetcontainer: free children array on finalization
  net/can: free ifname on socketcan finalization
  backends/igvm-cfg: free filename on finalization
  scsi/pr-manager-helper: free path on finalization
  accel/kvm: free device path on finalization
  system/qtest: add missing qtest_finalize()
  hw/fsi: move OPBus address space init to realize
  hw/fsi: move OPBus qbus_init() to instance_init
  hw/gpio/pca9552: fix state_str leak in pca955x_set_led
  hw/arm/aspeed: free fmc_model and spi_model on finalization
  hw/arm/sbsa-ref: free unrealized flash devices on finalization
  hw/arm/virt: free flash devices and OEM strings on finalization
  hw/ppc/pnv: drop extra ref on PHB after adding as child
  hw/riscv/virt: free flash devices and OEM strings on finalization
  meson: drop sphinx-build < 1.7 compatiblity check
  target/s390x: add gen-features.h dependency to s390x_system_ss

Peter Xu (1):
  system/ioport: Fix qom-list-properties crash on portio list obj

 docs/meson.build          | 14 +-------------
 include/qom/object.h      |  8 ++++----
 accel/kvm/kvm-all.c       |  8 ++++++++
 backends/igvm-cfg.c       |  1 +
 hw/arm/aspeed.c           |  9 +++++++++
 hw/arm/sbsa-ref.c         | 12 ++++++++++++
 hw/arm/virt.c             | 14 ++++++++++++++
 hw/core/resetcontainer.c  |  3 +++
 hw/fsi/aspeed_apb2opb.c   | 37 ++++++++++++++++++++++++-------------
 hw/gpio/pca9552.c         |  2 +-
 hw/i386/x86.c             |  9 +++++++++
 hw/ppc/pnv.c              |  1 +
 hw/remote/remote-obj.c    |  4 +++-
 hw/remote/vfio-user-obj.c |  4 +++-
 hw/riscv/virt.c           | 14 ++++++++++++++
 io/net-listener.c         |  9 ++++++++-
 net/can/can_socketcan.c   |  8 ++++++++
 net/colo-compare.c        | 31 +++++++++++++++----------------
 scsi/pr-manager-helper.c  |  1 +
 system/ioport.c           | 11 +++++++++--
 system/qtest.c            | 10 ++++++++++
 ui/console.c              |  5 ++++-
 target/s390x/meson.build  |  1 +
 23 files changed, 163 insertions(+), 53 deletions(-)

-- 
2.54.0


Re: [PULL 00/24] Qom patches
Posted by Stefan Hajnoczi 2 weeks, 3 days ago
On Mon, May 11, 2026 at 4:21 PM <marcandre.lureau@redhat.com> wrote:
>
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> The following changes since commit 5e61afe211e82a9af15a8794a0bd29bb574e953b:
>
>   Merge tag 'ui-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-05-11 10:49:53 -0400)
>
> are available in the Git repository at:
>
>   https://gitlab.com/marcandre.lureau/qemu.git tags/qom-pull-request
>
> for you to fetch changes up to bc61a3209bf064826481a5f8f2b4feb47c70b02f:
>
>   target/s390x: add gen-features.h dependency to s390x_system_ss (2026-05-11 23:59:33 +0400)
>
> ----------------------------------------------------------------
> QOM object lifecycle fixes
>
> ----------------------------------------------------------------

Hi Marc-André,
I'm not sure if this CI failure is related to this pull request, but
there is a dbus-vnc issue:

>>> ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 QTEST_QEMU_VNC_BINARY=./tools/qemu-vnc/qemu-vnc MESON_TEST_ITERATION=1 PYTHON=/home/gitlab-runner/builds/P3MFS4LUf/0/qemu-project/qemu/build/pyvenv/bin/python3 QTEST_QEMU_STORAGE_DAEMON_BINARY=./storage-daemon/qemu-storage-daemon G_TEST_DBUS_DAEMON=/home/gitlab-runner/builds/P3MFS4LUf/0/qemu-project/qemu/tests/dbus-daemon.sh QTEST_QEMU_IMG=./qemu-img QTEST_QEMU_BINARY=./qemu-system-x86_64 UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 RUST_BACKTRACE=1 MALLOC_PERTURB_=211 MSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 /home/gitlab-runner/builds/P3MFS4LUf/0/qemu-project/qemu/build/tests/qtest/dbus-vnc-test --tap -k

754/1075 /x86_64/dbus-vnc/password-auth -
ERROR:../tests/qtest/dbus-vnc-test.c:621:test_dbus_vnc_password_auth:
assertion failed (qemu_vnc1_server_get_auth(proxy) == "vnc"): ("none"
== "vnc") FAIL

https://gitlab.com/qemu-project/qemu/-/jobs/14337427774#L5512

Any ideas?

Stefan

>
> Marc-André Lureau (23):
>   hw/remote: check visit return in vfu_object_set_socket
>   qom/object: update doc about NULL values in link properties
>   hw/remote: guard listener unregister in finalize
>   io/net-listener: move mutex init to instance_init
>   net/colo-compare: guard finalize against uninitialized state
>   ui/console: remove console from global list on finalization
>   hw/i386/x86: free oem_id and oem_table_id on finalization
>   hw/core/resetcontainer: free children array on finalization
>   net/can: free ifname on socketcan finalization
>   backends/igvm-cfg: free filename on finalization
>   scsi/pr-manager-helper: free path on finalization
>   accel/kvm: free device path on finalization
>   system/qtest: add missing qtest_finalize()
>   hw/fsi: move OPBus address space init to realize
>   hw/fsi: move OPBus qbus_init() to instance_init
>   hw/gpio/pca9552: fix state_str leak in pca955x_set_led
>   hw/arm/aspeed: free fmc_model and spi_model on finalization
>   hw/arm/sbsa-ref: free unrealized flash devices on finalization
>   hw/arm/virt: free flash devices and OEM strings on finalization
>   hw/ppc/pnv: drop extra ref on PHB after adding as child
>   hw/riscv/virt: free flash devices and OEM strings on finalization
>   meson: drop sphinx-build < 1.7 compatiblity check
>   target/s390x: add gen-features.h dependency to s390x_system_ss
>
> Peter Xu (1):
>   system/ioport: Fix qom-list-properties crash on portio list obj
>
>  docs/meson.build          | 14 +-------------
>  include/qom/object.h      |  8 ++++----
>  accel/kvm/kvm-all.c       |  8 ++++++++
>  backends/igvm-cfg.c       |  1 +
>  hw/arm/aspeed.c           |  9 +++++++++
>  hw/arm/sbsa-ref.c         | 12 ++++++++++++
>  hw/arm/virt.c             | 14 ++++++++++++++
>  hw/core/resetcontainer.c  |  3 +++
>  hw/fsi/aspeed_apb2opb.c   | 37 ++++++++++++++++++++++++-------------
>  hw/gpio/pca9552.c         |  2 +-
>  hw/i386/x86.c             |  9 +++++++++
>  hw/ppc/pnv.c              |  1 +
>  hw/remote/remote-obj.c    |  4 +++-
>  hw/remote/vfio-user-obj.c |  4 +++-
>  hw/riscv/virt.c           | 14 ++++++++++++++
>  io/net-listener.c         |  9 ++++++++-
>  net/can/can_socketcan.c   |  8 ++++++++
>  net/colo-compare.c        | 31 +++++++++++++++----------------
>  scsi/pr-manager-helper.c  |  1 +
>  system/ioport.c           | 11 +++++++++--
>  system/qtest.c            | 10 ++++++++++
>  ui/console.c              |  5 ++++-
>  target/s390x/meson.build  |  1 +
>  23 files changed, 163 insertions(+), 53 deletions(-)
>
> --
> 2.54.0
>
>
Re: [PULL 00/24] Qom patches
Posted by Marc-André Lureau 2 weeks, 3 days ago
Hi Stefan

On Wed, May 13, 2026 at 3:20 AM Stefan Hajnoczi <stefanha@gmail.com> wrote:
>
> On Mon, May 11, 2026 at 4:21 PM <marcandre.lureau@redhat.com> wrote:
> >
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > The following changes since commit 5e61afe211e82a9af15a8794a0bd29bb574e953b:
> >
> >   Merge tag 'ui-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-05-11 10:49:53 -0400)
> >
> > are available in the Git repository at:
> >
> >   https://gitlab.com/marcandre.lureau/qemu.git tags/qom-pull-request
> >
> > for you to fetch changes up to bc61a3209bf064826481a5f8f2b4feb47c70b02f:
> >
> >   target/s390x: add gen-features.h dependency to s390x_system_ss (2026-05-11 23:59:33 +0400)
> >
> > ----------------------------------------------------------------
> > QOM object lifecycle fixes
> >
> > ----------------------------------------------------------------
>
> Hi Marc-André,
> I'm not sure if this CI failure is related to this pull request, but
> there is a dbus-vnc issue:
>
> >>> ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 QTEST_QEMU_VNC_BINARY=./tools/qemu-vnc/qemu-vnc MESON_TEST_ITERATION=1 PYTHON=/home/gitlab-runner/builds/P3MFS4LUf/0/qemu-project/qemu/build/pyvenv/bin/python3 QTEST_QEMU_STORAGE_DAEMON_BINARY=./storage-daemon/qemu-storage-daemon G_TEST_DBUS_DAEMON=/home/gitlab-runner/builds/P3MFS4LUf/0/qemu-project/qemu/tests/dbus-daemon.sh QTEST_QEMU_IMG=./qemu-img QTEST_QEMU_BINARY=./qemu-system-x86_64 UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 RUST_BACKTRACE=1 MALLOC_PERTURB_=211 MSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 /home/gitlab-runner/builds/P3MFS4LUf/0/qemu-project/qemu/build/tests/qtest/dbus-vnc-test --tap -k
>
> 754/1075 /x86_64/dbus-vnc/password-auth -
> ERROR:../tests/qtest/dbus-vnc-test.c:621:test_dbus_vnc_password_auth:
> assertion failed (qemu_vnc1_server_get_auth(proxy) == "vnc"): ("none"
> == "vnc") FAIL
>
> https://gitlab.com/qemu-project/qemu/-/jobs/14337427774#L5512
>
> Any ideas?

Embarrassingly, I have no idea. Before org.qemu.vnc is exposed by
qemu-vnc (and the auth is checked by the test), qemu-vnc must have
started a VNC server successfully (vnc_display_new)..

Fwiw, the tests runs quite smoothly locally with meson test --repeat
1000  (some time out sometime, due to heavy load).

Let's mark/run it as QEMU_TEST_FLAKY_TESTS until I figure out?


>
> Stefan
>
> >
> > Marc-André Lureau (23):
> >   hw/remote: check visit return in vfu_object_set_socket
> >   qom/object: update doc about NULL values in link properties
> >   hw/remote: guard listener unregister in finalize
> >   io/net-listener: move mutex init to instance_init
> >   net/colo-compare: guard finalize against uninitialized state
> >   ui/console: remove console from global list on finalization
> >   hw/i386/x86: free oem_id and oem_table_id on finalization
> >   hw/core/resetcontainer: free children array on finalization
> >   net/can: free ifname on socketcan finalization
> >   backends/igvm-cfg: free filename on finalization
> >   scsi/pr-manager-helper: free path on finalization
> >   accel/kvm: free device path on finalization
> >   system/qtest: add missing qtest_finalize()
> >   hw/fsi: move OPBus address space init to realize
> >   hw/fsi: move OPBus qbus_init() to instance_init
> >   hw/gpio/pca9552: fix state_str leak in pca955x_set_led
> >   hw/arm/aspeed: free fmc_model and spi_model on finalization
> >   hw/arm/sbsa-ref: free unrealized flash devices on finalization
> >   hw/arm/virt: free flash devices and OEM strings on finalization
> >   hw/ppc/pnv: drop extra ref on PHB after adding as child
> >   hw/riscv/virt: free flash devices and OEM strings on finalization
> >   meson: drop sphinx-build < 1.7 compatiblity check
> >   target/s390x: add gen-features.h dependency to s390x_system_ss
> >
> > Peter Xu (1):
> >   system/ioport: Fix qom-list-properties crash on portio list obj
> >
> >  docs/meson.build          | 14 +-------------
> >  include/qom/object.h      |  8 ++++----
> >  accel/kvm/kvm-all.c       |  8 ++++++++
> >  backends/igvm-cfg.c       |  1 +
> >  hw/arm/aspeed.c           |  9 +++++++++
> >  hw/arm/sbsa-ref.c         | 12 ++++++++++++
> >  hw/arm/virt.c             | 14 ++++++++++++++
> >  hw/core/resetcontainer.c  |  3 +++
> >  hw/fsi/aspeed_apb2opb.c   | 37 ++++++++++++++++++++++++-------------
> >  hw/gpio/pca9552.c         |  2 +-
> >  hw/i386/x86.c             |  9 +++++++++
> >  hw/ppc/pnv.c              |  1 +
> >  hw/remote/remote-obj.c    |  4 +++-
> >  hw/remote/vfio-user-obj.c |  4 +++-
> >  hw/riscv/virt.c           | 14 ++++++++++++++
> >  io/net-listener.c         |  9 ++++++++-
> >  net/can/can_socketcan.c   |  8 ++++++++
> >  net/colo-compare.c        | 31 +++++++++++++++----------------
> >  scsi/pr-manager-helper.c  |  1 +
> >  system/ioport.c           | 11 +++++++++--
> >  system/qtest.c            | 10 ++++++++++
> >  ui/console.c              |  5 ++++-
> >  target/s390x/meson.build  |  1 +
> >  23 files changed, 163 insertions(+), 53 deletions(-)
> >
> > --
> > 2.54.0
> >
> >
>
Re: [PULL 00/24] Qom patches
Posted by Stefan Hajnoczi 2 weeks, 2 days ago
On Wed, May 13, 2026 at 3:49 AM Marc-André Lureau
<marcandre.lureau@redhat.com> wrote:
>
> Hi Stefan
>
> On Wed, May 13, 2026 at 3:20 AM Stefan Hajnoczi <stefanha@gmail.com> wrote:
> >
> > On Mon, May 11, 2026 at 4:21 PM <marcandre.lureau@redhat.com> wrote:
> > >
> > > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> > >
> > > The following changes since commit 5e61afe211e82a9af15a8794a0bd29bb574e953b:
> > >
> > >   Merge tag 'ui-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-05-11 10:49:53 -0400)
> > >
> > > are available in the Git repository at:
> > >
> > >   https://gitlab.com/marcandre.lureau/qemu.git tags/qom-pull-request
> > >
> > > for you to fetch changes up to bc61a3209bf064826481a5f8f2b4feb47c70b02f:
> > >
> > >   target/s390x: add gen-features.h dependency to s390x_system_ss (2026-05-11 23:59:33 +0400)
> > >
> > > ----------------------------------------------------------------
> > > QOM object lifecycle fixes
> > >
> > > ----------------------------------------------------------------
> >
> > Hi Marc-André,
> > I'm not sure if this CI failure is related to this pull request, but
> > there is a dbus-vnc issue:
> >
> > >>> ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 QTEST_QEMU_VNC_BINARY=./tools/qemu-vnc/qemu-vnc MESON_TEST_ITERATION=1 PYTHON=/home/gitlab-runner/builds/P3MFS4LUf/0/qemu-project/qemu/build/pyvenv/bin/python3 QTEST_QEMU_STORAGE_DAEMON_BINARY=./storage-daemon/qemu-storage-daemon G_TEST_DBUS_DAEMON=/home/gitlab-runner/builds/P3MFS4LUf/0/qemu-project/qemu/tests/dbus-daemon.sh QTEST_QEMU_IMG=./qemu-img QTEST_QEMU_BINARY=./qemu-system-x86_64 UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 RUST_BACKTRACE=1 MALLOC_PERTURB_=211 MSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 /home/gitlab-runner/builds/P3MFS4LUf/0/qemu-project/qemu/build/tests/qtest/dbus-vnc-test --tap -k
> >
> > 754/1075 /x86_64/dbus-vnc/password-auth -
> > ERROR:../tests/qtest/dbus-vnc-test.c:621:test_dbus_vnc_password_auth:
> > assertion failed (qemu_vnc1_server_get_auth(proxy) == "vnc"): ("none"
> > == "vnc") FAIL
> >
> > https://gitlab.com/qemu-project/qemu/-/jobs/14337427774#L5512
> >
> > Any ideas?
>
> Embarrassingly, I have no idea. Before org.qemu.vnc is exposed by
> qemu-vnc (and the auth is checked by the test), qemu-vnc must have
> started a VNC server successfully (vnc_display_new)..
>
> Fwiw, the tests runs quite smoothly locally with meson test --repeat
> 1000  (some time out sometime, due to heavy load).
>
> Let's mark/run it as QEMU_TEST_FLAKY_TESTS until I figure out?

If it helps, your last ui pull request seems to be the first
occurrence of this failure:
https://gitlab.com/qemu-project/qemu/-/commit/5e61afe211e82a9af15a8794a0bd29bb574e953b

If you'd like me to run CI on a test branch, just let me know.

Stefan

>
>
> >
> > Stefan
> >
> > >
> > > Marc-André Lureau (23):
> > >   hw/remote: check visit return in vfu_object_set_socket
> > >   qom/object: update doc about NULL values in link properties
> > >   hw/remote: guard listener unregister in finalize
> > >   io/net-listener: move mutex init to instance_init
> > >   net/colo-compare: guard finalize against uninitialized state
> > >   ui/console: remove console from global list on finalization
> > >   hw/i386/x86: free oem_id and oem_table_id on finalization
> > >   hw/core/resetcontainer: free children array on finalization
> > >   net/can: free ifname on socketcan finalization
> > >   backends/igvm-cfg: free filename on finalization
> > >   scsi/pr-manager-helper: free path on finalization
> > >   accel/kvm: free device path on finalization
> > >   system/qtest: add missing qtest_finalize()
> > >   hw/fsi: move OPBus address space init to realize
> > >   hw/fsi: move OPBus qbus_init() to instance_init
> > >   hw/gpio/pca9552: fix state_str leak in pca955x_set_led
> > >   hw/arm/aspeed: free fmc_model and spi_model on finalization
> > >   hw/arm/sbsa-ref: free unrealized flash devices on finalization
> > >   hw/arm/virt: free flash devices and OEM strings on finalization
> > >   hw/ppc/pnv: drop extra ref on PHB after adding as child
> > >   hw/riscv/virt: free flash devices and OEM strings on finalization
> > >   meson: drop sphinx-build < 1.7 compatiblity check
> > >   target/s390x: add gen-features.h dependency to s390x_system_ss
> > >
> > > Peter Xu (1):
> > >   system/ioport: Fix qom-list-properties crash on portio list obj
> > >
> > >  docs/meson.build          | 14 +-------------
> > >  include/qom/object.h      |  8 ++++----
> > >  accel/kvm/kvm-all.c       |  8 ++++++++
> > >  backends/igvm-cfg.c       |  1 +
> > >  hw/arm/aspeed.c           |  9 +++++++++
> > >  hw/arm/sbsa-ref.c         | 12 ++++++++++++
> > >  hw/arm/virt.c             | 14 ++++++++++++++
> > >  hw/core/resetcontainer.c  |  3 +++
> > >  hw/fsi/aspeed_apb2opb.c   | 37 ++++++++++++++++++++++++-------------
> > >  hw/gpio/pca9552.c         |  2 +-
> > >  hw/i386/x86.c             |  9 +++++++++
> > >  hw/ppc/pnv.c              |  1 +
> > >  hw/remote/remote-obj.c    |  4 +++-
> > >  hw/remote/vfio-user-obj.c |  4 +++-
> > >  hw/riscv/virt.c           | 14 ++++++++++++++
> > >  io/net-listener.c         |  9 ++++++++-
> > >  net/can/can_socketcan.c   |  8 ++++++++
> > >  net/colo-compare.c        | 31 +++++++++++++++----------------
> > >  scsi/pr-manager-helper.c  |  1 +
> > >  system/ioport.c           | 11 +++++++++--
> > >  system/qtest.c            | 10 ++++++++++
> > >  ui/console.c              |  5 ++++-
> > >  target/s390x/meson.build  |  1 +
> > >  23 files changed, 163 insertions(+), 53 deletions(-)
> > >
> > > --
> > > 2.54.0
> > >
> > >
> >
Re: [PULL 00/24] Qom patches
Posted by Marc-André Lureau 2 weeks, 2 days ago
Hi

On Wed, May 13, 2026 at 11:05 PM Stefan Hajnoczi <stefanha@gmail.com> wrote:
>
> On Wed, May 13, 2026 at 3:49 AM Marc-André Lureau
> <marcandre.lureau@redhat.com> wrote:
> >
> > Hi Stefan
> >
> > On Wed, May 13, 2026 at 3:20 AM Stefan Hajnoczi <stefanha@gmail.com> wrote:
> > >
> > > On Mon, May 11, 2026 at 4:21 PM <marcandre.lureau@redhat.com> wrote:
> > > >
> > > > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> > > >
> > > > The following changes since commit 5e61afe211e82a9af15a8794a0bd29bb574e953b:
> > > >
> > > >   Merge tag 'ui-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2026-05-11 10:49:53 -0400)
> > > >
> > > > are available in the Git repository at:
> > > >
> > > >   https://gitlab.com/marcandre.lureau/qemu.git tags/qom-pull-request
> > > >
> > > > for you to fetch changes up to bc61a3209bf064826481a5f8f2b4feb47c70b02f:
> > > >
> > > >   target/s390x: add gen-features.h dependency to s390x_system_ss (2026-05-11 23:59:33 +0400)
> > > >
> > > > ----------------------------------------------------------------
> > > > QOM object lifecycle fixes
> > > >
> > > > ----------------------------------------------------------------
> > >
> > > Hi Marc-André,
> > > I'm not sure if this CI failure is related to this pull request, but
> > > there is a dbus-vnc issue:
> > >
> > > >>> ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1 QTEST_QEMU_VNC_BINARY=./tools/qemu-vnc/qemu-vnc MESON_TEST_ITERATION=1 PYTHON=/home/gitlab-runner/builds/P3MFS4LUf/0/qemu-project/qemu/build/pyvenv/bin/python3 QTEST_QEMU_STORAGE_DAEMON_BINARY=./storage-daemon/qemu-storage-daemon G_TEST_DBUS_DAEMON=/home/gitlab-runner/builds/P3MFS4LUf/0/qemu-project/qemu/tests/dbus-daemon.sh QTEST_QEMU_IMG=./qemu-img QTEST_QEMU_BINARY=./qemu-system-x86_64 UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 RUST_BACKTRACE=1 MALLOC_PERTURB_=211 MSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 /home/gitlab-runner/builds/P3MFS4LUf/0/qemu-project/qemu/build/tests/qtest/dbus-vnc-test --tap -k
> > >
> > > 754/1075 /x86_64/dbus-vnc/password-auth -
> > > ERROR:../tests/qtest/dbus-vnc-test.c:621:test_dbus_vnc_password_auth:
> > > assertion failed (qemu_vnc1_server_get_auth(proxy) == "vnc"): ("none"
> > > == "vnc") FAIL
> > >
> > > https://gitlab.com/qemu-project/qemu/-/jobs/14337427774#L5512
> > >
> > > Any ideas?
> >
> > Embarrassingly, I have no idea. Before org.qemu.vnc is exposed by
> > qemu-vnc (and the auth is checked by the test), qemu-vnc must have
> > started a VNC server successfully (vnc_display_new)..
> >
> > Fwiw, the tests runs quite smoothly locally with meson test --repeat
> > 1000  (some time out sometime, due to heavy load).
> >
> > Let's mark/run it as QEMU_TEST_FLAKY_TESTS until I figure out?
>
> If it helps, your last ui pull request seems to be the first
> occurrence of this failure:
> https://gitlab.com/qemu-project/qemu/-/commit/5e61afe211e82a9af15a8794a0bd29bb574e953b
>
> If you'd like me to run CI on a test branch, just let me know.

It's new code, from the patches introducing qemu-vnc & the test. Let's
just skip the test for now by default.
(https://patchew.org/QEMU/20260513082517.1720433-1-marcandre.lureau@redhat.com/)
Would you like me to send a new PR?
Re: [PULL 00/24] Qom patches
Posted by Stefan Hajnoczi 2 weeks, 2 days ago
On Wed, May 13, 2026, 15:16 Marc-André Lureau <marcandre.lureau@redhat.com>
wrote:

> Hi
>
> On Wed, May 13, 2026 at 11:05 PM Stefan Hajnoczi <stefanha@gmail.com>
> wrote:
> >
> > On Wed, May 13, 2026 at 3:49 AM Marc-André Lureau
> > <marcandre.lureau@redhat.com> wrote:
> > >
> > > Hi Stefan
> > >
> > > On Wed, May 13, 2026 at 3:20 AM Stefan Hajnoczi <stefanha@gmail.com>
> wrote:
> > > >
> > > > On Mon, May 11, 2026 at 4:21 PM <marcandre.lureau@redhat.com> wrote:
> > > > >
> > > > > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> > > > >
> > > > > The following changes since commit
> 5e61afe211e82a9af15a8794a0bd29bb574e953b:
> > > > >
> > > > >   Merge tag 'ui-pull-request' of
> https://gitlab.com/marcandre.lureau/qemu into staging (2026-05-11
> 10:49:53 -0400)
> > > > >
> > > > > are available in the Git repository at:
> > > > >
> > > > >   https://gitlab.com/marcandre.lureau/qemu.git
> tags/qom-pull-request
> > > > >
> > > > > for you to fetch changes up to
> bc61a3209bf064826481a5f8f2b4feb47c70b02f:
> > > > >
> > > > >   target/s390x: add gen-features.h dependency to s390x_system_ss
> (2026-05-11 23:59:33 +0400)
> > > > >
> > > > > ----------------------------------------------------------------
> > > > > QOM object lifecycle fixes
> > > > >
> > > > > ----------------------------------------------------------------
> > > >
> > > > Hi Marc-André,
> > > > I'm not sure if this CI failure is related to this pull request, but
> > > > there is a dbus-vnc issue:
> > > >
> > > > >>> ASAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1
> QTEST_QEMU_VNC_BINARY=./tools/qemu-vnc/qemu-vnc MESON_TEST_ITERATION=1
> PYTHON=/home/gitlab-runner/builds/P3MFS4LUf/0/qemu-project/qemu/build/pyvenv/bin/python3
> QTEST_QEMU_STORAGE_DAEMON_BINARY=./storage-daemon/qemu-storage-daemon
> G_TEST_DBUS_DAEMON=/home/gitlab-runner/builds/P3MFS4LUf/0/qemu-project/qemu/tests/dbus-daemon.sh
> QTEST_QEMU_IMG=./qemu-img QTEST_QEMU_BINARY=./qemu-system-x86_64
> UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1
> RUST_BACKTRACE=1 MALLOC_PERTURB_=211
> MSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1
> /home/gitlab-runner/builds/P3MFS4LUf/0/qemu-project/qemu/build/tests/qtest/dbus-vnc-test
> --tap -k
> > > >
> > > > 754/1075 /x86_64/dbus-vnc/password-auth -
> > > > ERROR:../tests/qtest/dbus-vnc-test.c:621:test_dbus_vnc_password_auth:
> > > > assertion failed (qemu_vnc1_server_get_auth(proxy) == "vnc"): ("none"
> > > > == "vnc") FAIL
> > > >
> > > > https://gitlab.com/qemu-project/qemu/-/jobs/14337427774#L5512
> > > >
> > > > Any ideas?
> > >
> > > Embarrassingly, I have no idea. Before org.qemu.vnc is exposed by
> > > qemu-vnc (and the auth is checked by the test), qemu-vnc must have
> > > started a VNC server successfully (vnc_display_new)..
> > >
> > > Fwiw, the tests runs quite smoothly locally with meson test --repeat
> > > 1000  (some time out sometime, due to heavy load).
> > >
> > > Let's mark/run it as QEMU_TEST_FLAKY_TESTS until I figure out?
> >
> > If it helps, your last ui pull request seems to be the first
> > occurrence of this failure:
> >
> https://gitlab.com/qemu-project/qemu/-/commit/5e61afe211e82a9af15a8794a0bd29bb574e953b
> >
> > If you'd like me to run CI on a test branch, just let me know.
>
> It's new code, from the patches introducing qemu-vnc & the test. Let's
> just skip the test for now by default.
> (
> https://patchew.org/QEMU/20260513082517.1720433-1-marcandre.lureau@redhat.com/
> )
> Would you like me to send a new PR?
>

No, it's okay. I can merge your patch directly into master.

Stefan

>
Re: [PULL 00/24] Qom patches
Posted by Stefan Hajnoczi 2 weeks, 2 days ago
Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/11.1 for any user-visible changes.