[v2] vfio: propagate IRQ notifier registration failure

[PATCH v2 0/2] vfio: propagate IRQ notifier registration failure

zhaoguohan@kylinos.cn posted 2 patches 2 weeks, 1 day ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260510084353.58263-1-zhaoguohan@kylinos.cn

Maintainers: Alex Williamson <alex@shazbot.org>, "Cédric Le Goater" <clg@redhat.com>, Tony Krowiak <akrowiak@linux.ibm.com>, Halil Pasic <pasic@linux.ibm.com>, Jason Herne <jjherne@linux.ibm.com>, Cornelia Huck <cohuck@redhat.com>, Eric Farman <farman@linux.ibm.com>, Matthew Rosato <mjrosato@linux.ibm.com>

hw/vfio/ap.c  | 1 +
hw/vfio/ccw.c | 1 +
2 files changed, 2 insertions(+)

Expand all Fold all

[PATCH v2 0/2] vfio: propagate IRQ notifier registration failure

Posted by zhaoguohan@kylinos.cn 2 weeks, 1 day ago

From: GuoHan Zhao <zhaoguohan@kylinos.cn>

vfio_ap_register_irq_notifier() and vfio_ccw_register_irq_notifier() clean
up the fd handler and EventNotifier when vfio_device_irq_set_signaling()
fails, but still return true to their callers.

Return false after cleanup so callers can handle the failed registration
path instead of treating it as a successful notifier setup.

Please ignore the previous version.

GuoHan Zhao (2):
  vfio/ap: Return false when IRQ notifier setup fails
  vfio/ccw: Return false when IRQ notifier setup fails

 hw/vfio/ap.c  | 1 +
 hw/vfio/ccw.c | 1 +
 2 files changed, 2 insertions(+)

-- 
2.43.0

Re: [PATCH v2 0/2] vfio: propagate IRQ notifier registration failure

Posted by Matthew Rosato 2 weeks ago

On 5/10/26 4:43 AM, zhaoguohan@kylinos.cn wrote:
> From: GuoHan Zhao <zhaoguohan@kylinos.cn>
> 
> vfio_ap_register_irq_notifier() and vfio_ccw_register_irq_notifier() clean
> up the fd handler and EventNotifier when vfio_device_irq_set_signaling()
> fails, but still return true to their callers.
> 
> Return false after cleanup so callers can handle the failed registration
> path instead of treating it as a successful notifier setup.
> 
> Please ignore the previous version.
> 
> GuoHan Zhao (2):
>   vfio/ap: Return false when IRQ notifier setup fails
>   vfio/ccw: Return false when IRQ notifier setup fails
> 
>  hw/vfio/ap.c  | 1 +
>  hw/vfio/ccw.c | 1 +
>  2 files changed, 2 insertions(+)
> 

For the series:

Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>

Re: [PATCH v2 0/2] vfio: propagate IRQ notifier registration failure

Posted by Cédric Le Goater 2 weeks, 1 day ago

On 5/10/26 10:43, zhaoguohan@kylinos.cn wrote:
> From: GuoHan Zhao <zhaoguohan@kylinos.cn>
> 
> vfio_ap_register_irq_notifier() and vfio_ccw_register_irq_notifier() clean
> up the fd handler and EventNotifier when vfio_device_irq_set_signaling()
> fails, but still return true to their callers.
> 
> Return false after cleanup so callers can handle the failed registration
> path instead of treating it as a successful notifier setup.
> 
> Please ignore the previous version.
> 
> GuoHan Zhao (2):
>    vfio/ap: Return false when IRQ notifier setup fails
>    vfio/ccw: Return false when IRQ notifier setup fails
> 
>   hw/vfio/ap.c  | 1 +
>   hw/vfio/ccw.c | 1 +
>   2 files changed, 2 insertions(+)
> 


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.