As discussed before, change the tests to always use -incoming
defer. Also remove one of the uris from MigrateCommon, a single uri is
enough.

CI run: https://gitlab.com/farosas/qemu/-/pipelines/2501387628

Fabiano Rosas (15):
  tests/qtest/migration: Move cpr transfer logic into cpr-tests.c
  tests/qtest/migration: Make file-tests defer by default
  tests/qtest/migration: Set file URI by default
  tests/qtest/migration: Group unix migration tests
  tests/qtest/migration: Use precopy_unix_common for ignore-shared test
  tests/qtest/migration: Use a default TCP URI for precopy
  tests/qtest/migration: Defer by default in precopy_common
  tests/qtest/migration: Set compression method in compression-tests
  tests/qtest/migration: Remove multifd compression hook
  tests/qtest/migration: Use defer for all tests
  tests/qtest/migration: Use defer for cpr-tests
  tests/qtest/migration: Use defer for auto-converge
  tests/qtest/migration: Use defer in dirty_limit test
  tests/qtest/migration: Stop passing URI into migrate_start
  tests/qtest/migration: Unify URIs

 tests/qtest/migration/colo-tests.c        |  16 ++--
 tests/qtest/migration/compression-tests.c |  34 +++----
 tests/qtest/migration/cpr-tests.c         |  85 +++++++++++++----
 tests/qtest/migration/file-tests.c        |  56 ++---------
 tests/qtest/migration/framework.c         |  91 +++++++-----------
 tests/qtest/migration/framework.h         |  26 ++---
 tests/qtest/migration/misc-tests.c        |  62 +++++-------
 tests/qtest/migration/precopy-tests.c     |  82 ++++------------
 tests/qtest/migration/tls-tests.c         | 110 +++-------------------
 9 files changed, 192 insertions(+), 370 deletions(-)

-- 
2.51.0

On Tue, May 05, 2026 at 01:08:59PM -0300, Fabiano Rosas wrote:
> As discussed before, change the tests to always use -incoming
> defer. Also remove one of the uris from MigrateCommon, a single uri is
> enough.
> 
> CI run: https://gitlab.com/farosas/qemu/-/pipelines/2501387628

queued, thanks!

-- 
Peter Xu

On Tue, May 05, 2026 at 01:08:59PM -0300, Fabiano Rosas wrote:
> As discussed before, change the tests to always use -incoming
> defer. Also remove one of the uris from MigrateCommon, a single uri is
> enough.

A quick question before reading into details: do we want to still keep
-incoming URI to work for QEMU?  If yes, do we still want still a tiny bit
of test coverage for them?

-- 
Peter Xu

Peter Xu <peterx@redhat.com> writes:

> On Tue, May 05, 2026 at 01:08:59PM -0300, Fabiano Rosas wrote:
>> As discussed before, change the tests to always use -incoming
>> defer. Also remove one of the uris from MigrateCommon, a single uri is
>> enough.
>
> A quick question before reading into details: do we want to still keep
> -incoming URI to work for QEMU?  If yes, do we still want still a tiny bit
> of test coverage for them?

I would think so. There is some coverage with the cpr tests, they're
still passing -incoming <uri> -incoming <cpr_channel>. Do you think
that's enough?

On Tue, May 05, 2026 at 04:06:49PM -0300, Fabiano Rosas wrote:
> Peter Xu <peterx@redhat.com> writes:
> 
> > On Tue, May 05, 2026 at 01:08:59PM -0300, Fabiano Rosas wrote:
> >> As discussed before, change the tests to always use -incoming
> >> defer. Also remove one of the uris from MigrateCommon, a single uri is
> >> enough.
> >
> > A quick question before reading into details: do we want to still keep
> > -incoming URI to work for QEMU?  If yes, do we still want still a tiny bit
> > of test coverage for them?
> 
> I would think so. There is some coverage with the cpr tests, they're
> still passing -incoming <uri> -incoming <cpr_channel>. Do you think
> that's enough?

Yeah, I think it'll be fine.

-- 
Peter Xu