kconfig cleanups and mypy annotations

[PATCH 0/8] kconfig cleanups and mypy annotations

Paolo Bonzini posted 8 patches 1 month ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260430090534.841894-1-pbonzini@redhat.com

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Palmer Dabbelt <palmer@dabbelt.com>, Alistair Francis <alistair.francis@wdc.com>, Weiwei Li <liwei1518@gmail.com>, Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com>, Liu Zhiwei <zhiwei_liu@linux.alibaba.com>, Chao Liu <chao.liu.zevorn@gmail.com>, John Snow <jsnow@redhat.com>, Cleber Rosa <crosa@redhat.com>

hw/Kconfig              |   1 -
hw/cxl/Kconfig          |   3 -
hw/misc/Kconfig         |   8 -
hw/riscv/Kconfig        |   4 +
python/tests/linters.py |   6 +
scripts/minikconf.py    | 465 +++++++++++++++++++++-------------------
6 files changed, 254 insertions(+), 233 deletions(-)
delete mode 100644 hw/cxl/Kconfig

Expand all Fold all

[PATCH 0/8] kconfig cleanups and mypy annotations

Posted by Paolo Bonzini 1 month ago

Modernize the code a bit and fix some issues that were found while
adding mypy annotations to minikconf.

While this stops short of adding flake8 and pylint, it already
improves the style and fixes a bug (see patches 1-2).

Paolo Bonzini (13):
  kconfig: remove duplicate declaration of CONFIG_CXL
  kconfig: remove duplicate declaration of CONFIG_MIPS_BOSTON_AIA
  minikconf: run through isort
  minikconf: small cleanups and dead code removal
  minikconf: move command-line assignment out of the parser
  minikconf: fix type mismatch in do_declaration
  minikconf: simplify self.tok
  minikconf: modernize handling of include chain
  minikconf: use .items()
  minikconf: pull main program into a function
  minikconf: remove unnecessary semicolons
  minikconf: replace else with early return and avoid unnecessary else
  minikconf: add mypy annotations

 hw/Kconfig              |   1 -
 hw/cxl/Kconfig          |   3 -
 hw/misc/Kconfig         |   8 -
 hw/riscv/Kconfig        |   4 +
 python/tests/linters.py |   6 +
 scripts/minikconf.py    | 465 +++++++++++++++++++++-------------------
 6 files changed, 254 insertions(+), 233 deletions(-)
 delete mode 100644 hw/cxl/Kconfig

-- 
2.54.0

Re: [PATCH 0/8] kconfig cleanups and mypy annotations

Posted by marcandre.lureau@redhat.com 1 month ago

On Thu, 30 Apr 2026 11:05:21 +0200, Paolo Bonzini <pbonzini@redhat.com> wrote:
> kconfig cleanups and mypy annotations
> 
> Modernize the code a bit and fix some issues that were found while
> adding mypy annotations to minikconf.
> 
> While this stops short of adding flake8 and pylint, it already
> improves the style and fixes a bug (see patches 1-2).
> 
> [...]

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

-- 
Marc-André Lureau <marcandre.lureau@redhat.com>