[PATCH 0/9] target/s390x/tcg: Compile various files once

Philippe Mathieu-Daudé posted 9 patches 1 month, 1 week ago
Failed in applying to current master (apply log)
include/tcg/tcg-op-mem.h         |  2 +
target/s390x/tcg/crypto_helper.c | 80 +++++++++++++++++---------------
target/s390x/tcg/misc_helper.c   |  7 ++-
target/s390x/tcg/translate.c     |  6 ++-
target/s390x/tcg/vec_helper.c    | 34 +++++++++-----
target/s390x/kvm/meson.build     |  2 +-
target/s390x/meson.build         | 25 +++++-----
target/s390x/tcg/meson.build     |  8 ++--
8 files changed, 96 insertions(+), 68 deletions(-)
[PATCH 0/9] target/s390x/tcg: Compile various files once
Posted by Philippe Mathieu-Daudé 1 month, 1 week ago
When a file doesn't use any target-specific knowledge, it can
be compiled once as common object. By moving the file to a
meson 'common' source set, we ensure no target-specific API
will be ever used [*]. This series move early few s390x TCG
files to common because in the current state it is cheap
enough to do so, no need to procrastinate.

[*] https://lore.kernel.org/qemu-devel/beefeef5-96ba-4645-a01a-7ca96055d93a@oss.qualcomm.com/

Philippe Mathieu-Daudé (9):
  tcg: Include missing 'tcg/tcg-op-common.h' header in 'tcg-op-mem.h'
  target/s390x: Do not compile KVM stubs for linux-user binary
  target/s390x: Introduce common system/user meson source set
  target/s390x: Compile few files as common unit
  target/s390x: Compile translate.c as common unit
  target/s390x: Compile vec_helper.c as common unit
  target/s390x: Have MSA helper pass a mmu_idx argument
  target/s390x: Compile crypto_helper.c as common unit
  target/s390x: Replace cpu_stb_data_ra -> cpu_stb_mmu in STFLE opcode

 include/tcg/tcg-op-mem.h         |  2 +
 target/s390x/tcg/crypto_helper.c | 80 +++++++++++++++++---------------
 target/s390x/tcg/misc_helper.c   |  7 ++-
 target/s390x/tcg/translate.c     |  6 ++-
 target/s390x/tcg/vec_helper.c    | 34 +++++++++-----
 target/s390x/kvm/meson.build     |  2 +-
 target/s390x/meson.build         | 25 +++++-----
 target/s390x/tcg/meson.build     |  8 ++--
 8 files changed, 96 insertions(+), 68 deletions(-)

-- 
2.53.0


Re: [PATCH 0/9] target/s390x/tcg: Compile various files once
Posted by Ilya Leoshkevich 1 month, 1 week ago
On 4/23/26 14:50, Philippe Mathieu-Daudé wrote:
> When a file doesn't use any target-specific knowledge, it can
> be compiled once as common object. By moving the file to a
> meson 'common' source set, we ensure no target-specific API
> will be ever used [*]. This series move early few s390x TCG
> files to common because in the current state it is cheap
> enough to do so, no need to procrastinate.
>
> [*] https://lore.kernel.org/qemu-devel/beefeef5-96ba-4645-a01a-7ca96055d93a@oss.qualcomm.com/
>
> Philippe Mathieu-Daudé (9):
>    tcg: Include missing 'tcg/tcg-op-common.h' header in 'tcg-op-mem.h'
>    target/s390x: Do not compile KVM stubs for linux-user binary
>    target/s390x: Introduce common system/user meson source set
>    target/s390x: Compile few files as common unit
>    target/s390x: Compile translate.c as common unit
>    target/s390x: Compile vec_helper.c as common unit
>    target/s390x: Have MSA helper pass a mmu_idx argument
>    target/s390x: Compile crypto_helper.c as common unit
>    target/s390x: Replace cpu_stb_data_ra -> cpu_stb_mmu in STFLE opcode
>
>   include/tcg/tcg-op-mem.h         |  2 +
>   target/s390x/tcg/crypto_helper.c | 80 +++++++++++++++++---------------
>   target/s390x/tcg/misc_helper.c   |  7 ++-
>   target/s390x/tcg/translate.c     |  6 ++-
>   target/s390x/tcg/vec_helper.c    | 34 +++++++++-----
>   target/s390x/kvm/meson.build     |  2 +-
>   target/s390x/meson.build         | 25 +++++-----
>   target/s390x/tcg/meson.build     |  8 ++--
>   8 files changed, 96 insertions(+), 68 deletions(-)

I assume this series is Based-on: 
<20260423100229.2941820-1-peter.maydell@linaro.org>?


Re: [PATCH 0/9] target/s390x/tcg: Compile various files once
Posted by Philippe Mathieu-Daudé 1 month, 1 week ago
On 23/4/26 16:51, Ilya Leoshkevich wrote:
> On 4/23/26 14:50, Philippe Mathieu-Daudé wrote:
>> When a file doesn't use any target-specific knowledge, it can
>> be compiled once as common object. By moving the file to a
>> meson 'common' source set, we ensure no target-specific API
>> will be ever used [*]. This series move early few s390x TCG
>> files to common because in the current state it is cheap
>> enough to do so, no need to procrastinate.
>>
>> [*] https://lore.kernel.org/qemu-devel/beefeef5-96ba-4645- 
>> a01a-7ca96055d93a@oss.qualcomm.com/
>>
>> Philippe Mathieu-Daudé (9):
>>    tcg: Include missing 'tcg/tcg-op-common.h' header in 'tcg-op-mem.h'
>>    target/s390x: Do not compile KVM stubs for linux-user binary
>>    target/s390x: Introduce common system/user meson source set
>>    target/s390x: Compile few files as common unit
>>    target/s390x: Compile translate.c as common unit
>>    target/s390x: Compile vec_helper.c as common unit
>>    target/s390x: Have MSA helper pass a mmu_idx argument
>>    target/s390x: Compile crypto_helper.c as common unit
>>    target/s390x: Replace cpu_stb_data_ra -> cpu_stb_mmu in STFLE opcode


> I assume this series is Based-on: <20260423100229.2941820-1- 
> peter.maydell@linaro.org>?

Oops yes, sorry!