1. Patchew
  2. QEMU
  3. View series

[PATCH] hw/remote: update libvfio-user subproject

John Levon posted 1 patch 1 month, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260422140244.2147400-1-john.levon@nutanix.com
Maintainers: Elena Ufimtseva <elena.ufimtseva@oracle.com>, Jagannathan Raman <jag.raman@oracle.com>, John Levon <john.levon@nutanix.com>, Thanos Makatos <thanos.makatos@nutanix.com>, "Cédric Le Goater" <clg@redhat.com>
hw/remote/vfio-user-obj.c     | 3 ++-
subprojects/libvfio-user.wrap | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
[PATCH] hw/remote: update libvfio-user subproject
Posted by John Levon 1 month, 1 week ago 
The currently wrapped version of libvfio-user has compilation issues on
newer compilers; bump the library version.

Signed-off-by: John Levon <john.levon@nutanix.com>
---
 hw/remote/vfio-user-obj.c     | 3 ++-
 subprojects/libvfio-user.wrap | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/hw/remote/vfio-user-obj.c b/hw/remote/vfio-user-obj.c
index 12ecdab6de..3c89e7a741 100644
--- a/hw/remote/vfio-user-obj.c
+++ b/hw/remote/vfio-user-obj.c
@@ -798,7 +798,8 @@ static void vfu_object_init_ctx(VfuObject *o, Error **errp)
         goto fail;
     }
 
-    ret = vfu_setup_device_dma(o->vfu_ctx, &dma_register, &dma_unregister);
+    ret = vfu_setup_device_dma(o->vfu_ctx, LIBVFIO_USER_MAX_DMA_REGIONS,
+                               &dma_register, &dma_unregister);
     if (ret < 0) {
         error_setg(errp, "vfu: Failed to setup DMA handlers for %s",
                    o->device);
diff --git a/subprojects/libvfio-user.wrap b/subprojects/libvfio-user.wrap
index 416955ca45..11db795f8a 100644
--- a/subprojects/libvfio-user.wrap
+++ b/subprojects/libvfio-user.wrap
@@ -1,4 +1,4 @@
 [wrap-git]
 url = https://gitlab.com/qemu-project/libvfio-user.git
-revision = 0b28d205572c80b568a1003db2c8f37ca333e4d7
+revision = 4d9f663450fa80ff375612dbbafe073700e3d3d8
 depth = 1
-- 
2.43.0
Re: [PATCH] hw/remote: update libvfio-user subproject
Posted by Cédric Le Goater 3 weeks, 5 days ago 
On 4/22/26 16:02, John Levon wrote:
> The currently wrapped version of libvfio-user has compilation issues on
> newer compilers; bump the library version.
> 
> Signed-off-by: John Levon <john.levon@nutanix.com>
> ---
>   hw/remote/vfio-user-obj.c     | 3 ++-
>   subprojects/libvfio-user.wrap | 2 +-
>   2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/remote/vfio-user-obj.c b/hw/remote/vfio-user-obj.c
> index 12ecdab6de..3c89e7a741 100644
> --- a/hw/remote/vfio-user-obj.c
> +++ b/hw/remote/vfio-user-obj.c
> @@ -798,7 +798,8 @@ static void vfu_object_init_ctx(VfuObject *o, Error **errp)
>           goto fail;
>       }
>   
> -    ret = vfu_setup_device_dma(o->vfu_ctx, &dma_register, &dma_unregister);
> +    ret = vfu_setup_device_dma(o->vfu_ctx, LIBVFIO_USER_MAX_DMA_REGIONS,
> +                               &dma_register, &dma_unregister);
>       if (ret < 0) {
>           error_setg(errp, "vfu: Failed to setup DMA handlers for %s",
>                      o->device);
> diff --git a/subprojects/libvfio-user.wrap b/subprojects/libvfio-user.wrap
> index 416955ca45..11db795f8a 100644
> --- a/subprojects/libvfio-user.wrap
> +++ b/subprojects/libvfio-user.wrap
> @@ -1,4 +1,4 @@
>   [wrap-git]
>   url = https://gitlab.com/qemu-project/libvfio-user.git
> -revision = 0b28d205572c80b568a1003db2c8f37ca333e4d7
> +revision = 4d9f663450fa80ff375612dbbafe073700e3d3d8
>   depth = 1


Applied to

     https://github.com/legoater/qemu vfio-next

Please base future contributions on this branch.

Thanks,

C.
Re: [PATCH] hw/remote: update libvfio-user subproject
Posted by Jagannathan Raman 1 month, 1 week ago 
On 4/22/26 10:02 AM, John Levon wrote:
> The currently wrapped version of libvfio-user has compilation issues on
> newer compilers; bump the library version.
>
> Signed-off-by: John Levon <john.levon@nutanix.com>

Looks good to me. Thanks for the patch!

Reviewed-by: Jagannathan Raman <jag.raman@oracle.com>

> ---
>   hw/remote/vfio-user-obj.c     | 3 ++-
>   subprojects/libvfio-user.wrap | 2 +-
>   2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/remote/vfio-user-obj.c b/hw/remote/vfio-user-obj.c
> index 12ecdab6de..3c89e7a741 100644
> --- a/hw/remote/vfio-user-obj.c
> +++ b/hw/remote/vfio-user-obj.c
> @@ -798,7 +798,8 @@ static void vfu_object_init_ctx(VfuObject *o, Error **errp)
>           goto fail;
>       }
>   
> -    ret = vfu_setup_device_dma(o->vfu_ctx, &dma_register, &dma_unregister);
> +    ret = vfu_setup_device_dma(o->vfu_ctx, LIBVFIO_USER_MAX_DMA_REGIONS,
> +                               &dma_register, &dma_unregister);
>       if (ret < 0) {
>           error_setg(errp, "vfu: Failed to setup DMA handlers for %s",
>                      o->device);
> diff --git a/subprojects/libvfio-user.wrap b/subprojects/libvfio-user.wrap
> index 416955ca45..11db795f8a 100644
> --- a/subprojects/libvfio-user.wrap
> +++ b/subprojects/libvfio-user.wrap
> @@ -1,4 +1,4 @@
>   [wrap-git]
>   url = https://gitlab.com/qemu-project/libvfio-user.git
> -revision = 0b28d205572c80b568a1003db2c8f37ca333e4d7
> +revision = 4d9f663450fa80ff375612dbbafe073700e3d3d8
>   depth = 1
Re: [PATCH] hw/remote: update libvfio-user subproject
Posted by Mark Cave-Ayland 1 month, 1 week ago 
On 22/04/2026 15:02, John Levon wrote:

> The currently wrapped version of libvfio-user has compilation issues on
> newer compilers; bump the library version.

I'd expect the subject to be "subprojects: update libvfio-user 
subproject" since that's really what the patch is doing. The 
hw/remote/vfio-user-obj.c update seems to be due to an API change in the 
updated library, so I'd add a sentence mentioning this in the commit 
message.

Otherwise the patch itself seems okay to me, so:

Reviewed-by: Mark Cave-Ayland <mark.caveayland@nutanix.com>

> Signed-off-by: John Levon <john.levon@nutanix.com>
> ---
>   hw/remote/vfio-user-obj.c     | 3 ++-
>   subprojects/libvfio-user.wrap | 2 +-
>   2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/remote/vfio-user-obj.c b/hw/remote/vfio-user-obj.c
> index 12ecdab6de..3c89e7a741 100644
> --- a/hw/remote/vfio-user-obj.c
> +++ b/hw/remote/vfio-user-obj.c
> @@ -798,7 +798,8 @@ static void vfu_object_init_ctx(VfuObject *o, Error **errp)
>           goto fail;
>       }
>   
> -    ret = vfu_setup_device_dma(o->vfu_ctx, &dma_register, &dma_unregister);
> +    ret = vfu_setup_device_dma(o->vfu_ctx, LIBVFIO_USER_MAX_DMA_REGIONS,
> +                               &dma_register, &dma_unregister);
>       if (ret < 0) {
>           error_setg(errp, "vfu: Failed to setup DMA handlers for %s",
>                      o->device);
> diff --git a/subprojects/libvfio-user.wrap b/subprojects/libvfio-user.wrap
> index 416955ca45..11db795f8a 100644
> --- a/subprojects/libvfio-user.wrap
> +++ b/subprojects/libvfio-user.wrap
> @@ -1,4 +1,4 @@
>   [wrap-git]
>   url = https://urldefense.proofpoint.com/v2/url?u=https-3A__gitlab.com_qemu-2Dproject_libvfio-2Duser.git&d=DwIDAg&c=s883GpUCOChKOHiocYtGcg&r=c23RpsaH4D2MKyD3EPJTDa0BAxz6tV8aUJqVSoytEiY&m=ISwI5jNoODKCfAhvIggfxoM8rCBQTgD-TrxSMkw8aq533QGLfHtgCaNaf41km6lt&s=CPF5JE7hn0XRJAOBEvH_Eajaj4chiPVUN6hCJS9bEpw&e=
> -revision = 0b28d205572c80b568a1003db2c8f37ca333e4d7
> +revision = 4d9f663450fa80ff375612dbbafe073700e3d3d8
>   depth = 1
Re: [PATCH] hw/remote: update libvfio-user subproject
Posted by John Levon 1 month, 1 week ago 
On Wed, Apr 22, 2026 at 04:33:20PM +0100, Mark Cave-Ayland wrote:

> > The currently wrapped version of libvfio-user has compilation issues on
> > newer compilers; bump the library version.
> 
> I'd expect the subject to be "subprojects: update libvfio-user subproject"
> since that's really what the patch is doing. The hw/remote/vfio-user-obj.c

hw/remote is the only consumer of the subproject though...

regards
john

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.