checkpatch: Allow spaces after all coroutine annotations

[PATCH v1] checkpatch: Allow spaces after all coroutine annotations

Posted by Fabiano Rosas 17 hours ago

The coroutine annotations may be used in the declaration of function
pointers, which triggers checkpatch due to the space before the
parentheses. E.g:

  int coroutine_fn (*run)(Job *job, Error **errp);
                  ^
The coroutine_fn annotation is already included in the list of terms
where spaces are allowed. Add the other coroutine annotations:
coroutine_mixed_fn and no_coroutine_fn.

Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
the next migration PR will trigger this
---
 scripts/checkpatch.pl | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index b77bd69328..e1cf2ff23b 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2441,6 +2441,7 @@ sub process {
 			if ($name =~ /^(?:
 				if|for|while|switch|return|case|
 				volatile|__volatile__|coroutine_fn|
+				coroutine_mixed_fn|no_coroutine_fn|
 				__attribute__|format|__extension__|
 				asm|__asm__)$/x)
 			{
-- 
2.51.0

Re: [PATCH v1] checkpatch: Allow spaces after all coroutine annotations

Posted by Markus Armbruster 6 hours ago

Fabiano Rosas <farosas@suse.de> writes:

> The coroutine annotations may be used in the declaration of function
> pointers, which triggers checkpatch due to the space before the
> parentheses. E.g:
>
>   int coroutine_fn (*run)(Job *job, Error **errp);
>                   ^
> The coroutine_fn annotation is already included in the list of terms
> where spaces are allowed. Add the other coroutine annotations:
> coroutine_mixed_fn and no_coroutine_fn.
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
> the next migration PR will trigger this
> ---
>  scripts/checkpatch.pl | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index b77bd69328..e1cf2ff23b 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2441,6 +2441,7 @@ sub process {
>  			if ($name =~ /^(?:
>  				if|for|while|switch|return|case|
>  				volatile|__volatile__|coroutine_fn|
> +				coroutine_mixed_fn|no_coroutine_fn|
>  				__attribute__|format|__extension__|
>  				asm|__asm__)$/x)
>  			{

Reviewed-by: Markus Armbruster <armbru@redhat.com>