[PATCH] hw/ppc: remove duplicate include

Osama Abdelkader posted 1 patch 20 hours ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260420164058.335872-1-osama.abdelkader@gmail.com
Maintainers: BALATON Zoltan <balaton@eik.bme.hu>
hw/ppc/amigaone.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] hw/ppc: remove duplicate include
Posted by Osama Abdelkader 20 hours ago
hw/ppc/ppc.h is included twice

Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
---
 hw/ppc/amigaone.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/ppc/amigaone.c b/hw/ppc/amigaone.c
index 8074713fbe..9fba5ca03a 100644
--- a/hw/ppc/amigaone.c
+++ b/hw/ppc/amigaone.c
@@ -20,7 +20,6 @@
 #include "hw/isa/vt82c686.h"
 #include "hw/ide/pci.h"
 #include "hw/i2c/smbus_eeprom.h"
-#include "hw/ppc/ppc.h"
 #include "exec/cpu-common.h"
 #include "system/block-backend.h"
 #include "system/qtest.h"
-- 
2.43.0
Re: [PATCH] hw/ppc: remove duplicate include
Posted by Philippe Mathieu-Daudé 4 minutes ago
On 20/4/26 18:40, Osama Abdelkader wrote:
> hw/ppc/ppc.h is included twice
> 
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
> ---
>   hw/ppc/amigaone.c | 1 -
>   1 file changed, 1 deletion(-)

Patch queued, thanks.
Re: [PATCH] hw/ppc: remove duplicate include
Posted by BALATON Zoltan 15 hours ago
On Mon, 20 Apr 2026, Osama Abdelkader wrote:
> hw/ppc/ppc.h is included twice
>
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>

Indeed, once is enough. Also cc'ing qemu-trivial list.

Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>

> ---
> hw/ppc/amigaone.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/ppc/amigaone.c b/hw/ppc/amigaone.c
> index 8074713fbe..9fba5ca03a 100644
> --- a/hw/ppc/amigaone.c
> +++ b/hw/ppc/amigaone.c
> @@ -20,7 +20,6 @@
> #include "hw/isa/vt82c686.h"
> #include "hw/ide/pci.h"
> #include "hw/i2c/smbus_eeprom.h"
> -#include "hw/ppc/ppc.h"
> #include "exec/cpu-common.h"
> #include "system/block-backend.h"
> #include "system/qtest.h"
>
Re: [PATCH] hw/ppc: remove duplicate include
Posted by Philippe Mathieu-Daudé 16 hours ago
On 20/4/26 18:40, Osama Abdelkader wrote:
> hw/ppc/ppc.h is included twice
> 
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
> ---
>   hw/ppc/amigaone.c | 1 -
>   1 file changed, 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>