[PATCH] hw/hyperv/vmbus: remove duplicate include

Osama Abdelkader posted 1 patch 20 hours ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260420163844.332663-1-osama.abdelkader@gmail.com
Maintainers: "Maciej S. Szmigiero" <maciej.szmigiero@oracle.com>
hw/hyperv/vmbus.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] hw/hyperv/vmbus: remove duplicate include
Posted by Osama Abdelkader 20 hours ago
exec/target_page.h is included twice

Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
---
 hw/hyperv/vmbus.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/hyperv/vmbus.c b/hw/hyperv/vmbus.c
index 5388f4277f..dcfce70005 100644
--- a/hw/hyperv/vmbus.c
+++ b/hw/hyperv/vmbus.c
@@ -21,7 +21,6 @@
 #include "hw/core/sysbus.h"
 #include "exec/cpu-common.h"
 #include "system/kvm.h"
-#include "exec/target_page.h"
 #include "trace.h"
 
 enum {
-- 
2.43.0
Re: [PATCH] hw/hyperv/vmbus: remove duplicate include
Posted by Philippe Mathieu-Daudé 4 hours ago
On 20/4/26 18:38, Osama Abdelkader wrote:
> exec/target_page.h is included twice
> 
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
> ---
>   hw/hyperv/vmbus.c | 1 -
>   1 file changed, 1 deletion(-)

Patch queued (squashed with other hyperv one), thanks.
Re: [PATCH] hw/hyperv/vmbus: remove duplicate include
Posted by Maciej S. Szmigiero 2 hours ago
On 21.04.2026 10:07, Philippe Mathieu-Daudé wrote:
> On 20/4/26 18:38, Osama Abdelkader wrote:
>> exec/target_page.h is included twice
>>
>> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
>> ---
>>   hw/hyperv/vmbus.c | 1 -
>>   1 file changed, 1 deletion(-)
> 
> Patch queued (squashed with other hyperv one), thanks.

Thanks Philippe.

Maciej


Re: [PATCH] hw/hyperv/vmbus: remove duplicate include
Posted by Philippe Mathieu-Daudé 16 hours ago
On 20/4/26 18:38, Osama Abdelkader wrote:
> exec/target_page.h is included twice
> 
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
> ---
>   hw/hyperv/vmbus.c | 1 -
>   1 file changed, 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH] hw/hyperv/vmbus: remove duplicate include
Posted by Maciej S. Szmigiero 17 hours ago
On 20.04.2026 18:38, Osama Abdelkader wrote:
> exec/target_page.h is included twice
> 
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
> ---
>   hw/hyperv/vmbus.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/hw/hyperv/vmbus.c b/hw/hyperv/vmbus.c
> index 5388f4277f..dcfce70005 100644
> --- a/hw/hyperv/vmbus.c
> +++ b/hw/hyperv/vmbus.c
> @@ -21,7 +21,6 @@
>   #include "hw/core/sysbus.h"
>   #include "exec/cpu-common.h"
>   #include "system/kvm.h"
> -#include "exec/target_page.h"
>   #include "trace.h"
>   
>   enum {

Reviewed-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>

Looks like it's a result of commits 4a695643a9e7 ("hw/hyperv/vmbus:
common compilation unit") and 9c2ff9cdc9b3 ("exec/cpu-all: remove
exec/target_page include") adding this include independently
within a period of 1 month.

These patches both have Pierrick as author, however they seem
to have came into git master via two different patch sets and
pull requests.

Thanks,
Maciej