Allow targets to register their legacy target_monitor_defs()
in SysemuCPUOps; check it first in get_monitor_def() otherwise
fall back to previous per-target helper.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
include/hw/core/sysemu-cpu-ops.h | 5 +++++
monitor/hmp.c | 9 +++++++--
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/include/hw/core/sysemu-cpu-ops.h b/include/hw/core/sysemu-cpu-ops.h
index 7b2d2d2610f..a96f4907d05 100644
--- a/include/hw/core/sysemu-cpu-ops.h
+++ b/include/hw/core/sysemu-cpu-ops.h
@@ -85,6 +85,11 @@ typedef struct SysemuCPUOps {
*/
bool (*internal_is_big_endian)(CPUState *cpu);
+ /**
+ * @monitor_defs: Array of MonitorDef entries. This field is legacy,
+ * use @gdb_core_xml_file to dump registers instead.
+ */
+ const MonitorDef *monitor_defs;
/**
* @legacy_vmsd: Legacy state for migration.
* Do not use in new targets, use #DeviceClass::vmsd instead.
diff --git a/monitor/hmp.c b/monitor/hmp.c
index 983048db1b9..6cf2f3e65ff 100644
--- a/monitor/hmp.c
+++ b/monitor/hmp.c
@@ -25,6 +25,7 @@
#include "qemu/osdep.h"
#include <dirent.h>
#include "hw/core/qdev.h"
+#include "hw/core/sysemu-cpu-ops.h"
#include "monitor-internal.h"
#include "monitor/hmp.h"
#include "qobject/qdict.h"
@@ -1603,13 +1604,17 @@ void monitor_register_hmp_info_hrt(const char *name,
*/
static int get_monitor_def(Monitor *mon, int64_t *pval, const char *name)
{
- const MonitorDef *md = target_monitor_defs();
CPUState *cs = mon_get_cpu(mon);
+ const MonitorDef *md;
void *ptr;
uint64_t tmp = 0;
int ret;
- if (cs == NULL || md == NULL) {
+ if (cs == NULL) {
+ return -1;
+ }
+ md = cs->cc->sysemu_ops->monitor_defs ?: target_monitor_defs();
+ if (md == NULL) {
return -1;
}
--
2.53.0