monitor: turn QMP and HMP into QOM objects

[PATCH 14/17] monitor: use dynamic cast in monitor_is_hmp_non_interactive

Daniel P. Berrangé posted 17 patches 1 day, 1 hour ago

Download mbox

Maintainers: "Marc-André Lureau" <marcandre.lureau@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>, "Dr. David Alan Gilbert" <dave@treblig.org>, Markus Armbruster <armbru@redhat.com>, "Daniel P. Berrangé" <berrange@redhat.com>, Eric Blake <eblake@redhat.com>, Kevin Wolf <kwolf@redhat.com>

Expand all Fold all

[PATCH 14/17] monitor: use dynamic cast in monitor_is_hmp_non_interactive

Posted by Daniel P. Berrangé 1 day, 1 hour ago

Rather than checking !monitor_is_qmp(), use a dynamic cast to
check for HMP.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 monitor/monitor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/monitor/monitor.c b/monitor/monitor.c
index a3e69b3cec..c08b2c2ee1 100644
--- a/monitor/monitor.c
+++ b/monitor/monitor.c
@@ -143,7 +143,7 @@ static inline bool monitor_uses_readline(const MonitorHMP *mon)
 
 static inline bool monitor_is_hmp_non_interactive(const Monitor *mon)
 {
-    if (monitor_is_qmp(mon)) {
+    if (!object_dynamic_cast(OBJECT(mon), TYPE_MONITOR_HMP)) {
         return false;
     }
 
-- 
2.53.0