[PATCH v2 1/7] linux-user/arm: Restrict regpairs_aligned

Richard Henderson posted 7 patches 2 days, 13 hours ago
Maintainers: Laurent Vivier <laurent@vivier.eu>, Pierrick Bouvier <pierrick.bouvier@linaro.org>, Peter Maydell <peter.maydell@linaro.org>
[PATCH v2 1/7] linux-user/arm: Restrict regpairs_aligned
Posted by Richard Henderson 2 days, 13 hours ago
The function regpairs_aligned is for extracting a 64-bit
quantity from a pair of 32-bit registers and does not
apply to AArch64.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 linux-user/user-internals.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-user/user-internals.h b/linux-user/user-internals.h
index 24d35998f0..e65373b204 100644
--- a/linux-user/user-internals.h
+++ b/linux-user/user-internals.h
@@ -136,7 +136,7 @@ void print_termios2(void *arg);
 #endif
 
 /* ARM EABI and MIPS expect 64bit types aligned even on pairs or registers */
-#ifdef TARGET_ARM
+#if defined(TARGET_ARM) && !defined(TARGET_AARCH64)
 static inline int regpairs_aligned(CPUArchState *cpu_env, int num)
 {
     return cpu_env->eabi;
-- 
2.43.0
Re: [PATCH v2 1/7] linux-user/arm: Restrict regpairs_aligned
Posted by Philippe Mathieu-Daudé 2 days, 12 hours ago
On 9/4/26 05:50, Richard Henderson wrote:
> The function regpairs_aligned is for extracting a 64-bit
> quantity from a pair of 32-bit registers and does not
> apply to AArch64.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   linux-user/user-internals.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>