[v10] target/arm: single-binary

[PATCH v10 11/21] target/arm/tcg/translate.c: remove MO_TE usage

Pierrick Bouvier posted 21 patches 3 days, 22 hours ago

Diff against v1 v2 v3 v4 v5 v6 v7 v8 v9 v11
Download mbox

Maintainers: Richard Henderson <richard.henderson@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Laurent Vivier <laurent@vivier.eu>, Pierrick Bouvier <pierrick.bouvier@linaro.org>, Peter Maydell <peter.maydell@linaro.org>, Michael Rolnik <mrolnik@gmail.com>, Brian Cain <brian.cain@oss.qualcomm.com>, Helge Deller <deller@gmx.de>, Song Gao <gaosong@loongson.cn>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Aurelien Jarno <aurelien@aurel32.net>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Aleksandar Rikalo <arikalo@gmail.com>, Stafford Horne <shorne@gmail.com>, Nicholas Piggin <npiggin@gmail.com>, Chinmay Rath <rathc@linux.ibm.com>, Glenn Miles <milesg@linux.ibm.com>, Palmer Dabbelt <palmer@dabbelt.com>, Alistair Francis <alistair.francis@wdc.com>, Weiwei Li <liwei1518@gmail.com>, Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com>, Liu Zhiwei <zhiwei_liu@linux.alibaba.com>, Chao Liu <chao.liu.zevorn@gmail.com>, Yoshinori Sato <yoshinori.sato@nifty.com>, Ilya Leoshkevich <iii@linux.ibm.com>, David Hildenbrand <david@kernel.org>, Cornelia Huck <cohuck@redhat.com>, Eric Farman <farman@linux.ibm.com>, Matthew Rosato <mjrosato@linux.ibm.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Artyom Tarasenko <atar4qemu@gmail.com>, Bastian Koppelmann <kbastian@rumtueddeln.de>, Max Filippov <jcmvbkbc@gmail.com>

There is a newer version of this series

Expand all Fold all

[PATCH v10 11/21] target/arm/tcg/translate.c: remove MO_TE usage

Posted by Pierrick Bouvier 3 days, 22 hours ago

dc->be_data is already set just above in the same function:
```
    dc->be_data = EX_TBFLAG_ANY(tb_flags, BE_DATA) ? MO_BE : MO_LE;
```

Cc: qemu-stable@nongnu.org
Fixes: a729a46b05a ("target/arm: Add wrapper macros for accessing tbflags")
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 target/arm/tcg/translate.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/target/arm/tcg/translate.c b/target/arm/tcg/translate.c
index 56ef1e0eb59..4546bbeeeff 100644
--- a/target/arm/tcg/translate.c
+++ b/target/arm/tcg/translate.c
@@ -6344,7 +6344,6 @@ static void arm_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cs)
 
     if (arm_feature(env, ARM_FEATURE_M)) {
         dc->vfp_enabled = 1;
-        dc->be_data = MO_TE;
         dc->v7m_handler_mode = EX_TBFLAG_M32(tb_flags, HANDLER);
         dc->v8m_secure = EX_TBFLAG_M32(tb_flags, SECURE);
         dc->v8m_stackcheck = EX_TBFLAG_M32(tb_flags, STACKCHECK);
-- 
2.47.3

Re: [PATCH v10 11/21] target/arm/tcg/translate.c: remove MO_TE usage

Posted by Philippe Mathieu-Daudé 3 days, 20 hours ago

On 7/4/26 21:59, Pierrick Bouvier wrote:
> dc->be_data is already set just above in the same function:
> ```
>      dc->be_data = EX_TBFLAG_ANY(tb_flags, BE_DATA) ? MO_BE : MO_LE;
> ```
> 
> Cc: qemu-stable@nongnu.org

Why Cc stable? This is just removing pointless code, right?

> Fixes: a729a46b05a ("target/arm: Add wrapper macros for accessing tbflags")

This commit doesn't seem to be related.

Do you mean commit 79cabf1f473 ("target/arm: Recover 4 bits from
TBFLAGs")?

     We had completely run out of TBFLAG bits.
     Split A- and M-profile bits into two overlapping buckets.
     This results in 4 free bits.

     We used to initialize all of the a32 and m32 fields in DisasContext
     by assignment, in arm_tr_init_disas_context.  Now we only initialize
     either the a32 or m32 by assignment, because the bits overlap in
     tbflags.  So zero the entire structure in gen_intermediate_code.

Since BE_DATA is in the TBFLAG_ANY set, I don't get why it
is set to MO_TE for M-profile.

At any rate this patch description deserves a better explanation IMHO.

> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   target/arm/tcg/translate.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/target/arm/tcg/translate.c b/target/arm/tcg/translate.c
> index 56ef1e0eb59..4546bbeeeff 100644
> --- a/target/arm/tcg/translate.c
> +++ b/target/arm/tcg/translate.c
> @@ -6344,7 +6344,6 @@ static void arm_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cs)
>   
>       if (arm_feature(env, ARM_FEATURE_M)) {
>           dc->vfp_enabled = 1;
> -        dc->be_data = MO_TE;
>           dc->v7m_handler_mode = EX_TBFLAG_M32(tb_flags, HANDLER);
>           dc->v8m_secure = EX_TBFLAG_M32(tb_flags, SECURE);
>           dc->v8m_stackcheck = EX_TBFLAG_M32(tb_flags, STACKCHECK);

Re: [PATCH v10 11/21] target/arm/tcg/translate.c: remove MO_TE usage

Posted by Pierrick Bouvier 3 days, 20 hours ago

On 4/7/26 2:55 PM, Philippe Mathieu-Daudé wrote:
> On 7/4/26 21:59, Pierrick Bouvier wrote:
>> dc->be_data is already set just above in the same function:
>> ```
>>       dc->be_data = EX_TBFLAG_ANY(tb_flags, BE_DATA) ? MO_BE : MO_LE;
>> ```
>>
>> Cc: qemu-stable@nongnu.org
> 
> Why Cc stable? This is just removing pointless code, right?
> 
>> Fixes: a729a46b05a ("target/arm: Add wrapper macros for accessing tbflags")
> 
> This commit doesn't seem to be related.
> 
> Do you mean commit 79cabf1f473 ("target/arm: Recover 4 bits from
> TBFLAGs")?
> 
>       We had completely run out of TBFLAG bits.
>       Split A- and M-profile bits into two overlapping buckets.
>       This results in 4 free bits.
> 
>       We used to initialize all of the a32 and m32 fields in DisasContext
>       by assignment, in arm_tr_init_disas_context.  Now we only initialize
>       either the a32 or m32 by assignment, because the bits overlap in
>       tbflags.  So zero the entire structure in gen_intermediate_code.
> 
> Since BE_DATA is in the TBFLAG_ANY set, I don't get why it
> is set to MO_TE for M-profile.
> 
> At any rate this patch description deserves a better explanation IMHO.
> 
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
>> ---
>>    target/arm/tcg/translate.c | 1 -
>>    1 file changed, 1 deletion(-)
>>
>> diff --git a/target/arm/tcg/translate.c b/target/arm/tcg/translate.c
>> index 56ef1e0eb59..4546bbeeeff 100644
>> --- a/target/arm/tcg/translate.c
>> +++ b/target/arm/tcg/translate.c
>> @@ -6344,7 +6344,6 @@ static void arm_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cs)
>>    
>>        if (arm_feature(env, ARM_FEATURE_M)) {
>>            dc->vfp_enabled = 1;
>> -        dc->be_data = MO_TE;
>>            dc->v7m_handler_mode = EX_TBFLAG_M32(tb_flags, HANDLER);
>>            dc->v8m_secure = EX_TBFLAG_M32(tb_flags, SECURE);
>>            dc->v8m_stackcheck = EX_TBFLAG_M32(tb_flags, STACKCHECK);
> 

See:
https://lore.kernel.org/qemu-devel/5fc9d07c-cd22-45c0-bb5e-8bf93d20f112@linaro.org/