[v9] target/arm: single-binary

[PATCH v9 16/20] target/arm/tcg/translate-a64.c: use translator_ldl_end instead of arm_ldl_code

Pierrick Bouvier posted 20 patches 4 days, 16 hours ago

Diff against v1 v2 v3 v4 v5 v6 v7 v8 v10 v11
Download mbox

Maintainers: Richard Henderson <richard.henderson@linaro.org>, Paolo Bonzini <pbonzini@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Michael Rolnik <mrolnik@gmail.com>, Brian Cain <brian.cain@oss.qualcomm.com>, Helge Deller <deller@gmx.de>, Song Gao <gaosong@loongson.cn>, Laurent Vivier <laurent@vivier.eu>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Aurelien Jarno <aurelien@aurel32.net>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Aleksandar Rikalo <arikalo@gmail.com>, Stafford Horne <shorne@gmail.com>, Nicholas Piggin <npiggin@gmail.com>, Chinmay Rath <rathc@linux.ibm.com>, Glenn Miles <milesg@linux.ibm.com>, Palmer Dabbelt <palmer@dabbelt.com>, Alistair Francis <alistair.francis@wdc.com>, Weiwei Li <liwei1518@gmail.com>, Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com>, Liu Zhiwei <zhiwei_liu@linux.alibaba.com>, Chao Liu <chao.liu.zevorn@gmail.com>, Yoshinori Sato <yoshinori.sato@nifty.com>, Ilya Leoshkevich <iii@linux.ibm.com>, David Hildenbrand <david@kernel.org>, Cornelia Huck <cohuck@redhat.com>, Eric Farman <farman@linux.ibm.com>, Matthew Rosato <mjrosato@linux.ibm.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Artyom Tarasenko <atar4qemu@gmail.com>, Bastian Koppelmann <kbastian@rumtueddeln.de>, Max Filippov <jcmvbkbc@gmail.com>

There is a newer version of this series

Expand all Fold all

[PATCH v9 16/20] target/arm/tcg/translate-a64.c: use translator_ldl_end instead of arm_ldl_code

Posted by Pierrick Bouvier 4 days, 16 hours ago

Allows to reduce scope of target/arm/tcg/arm_ldst.h to aarch32 only.

Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
---
 target/arm/tcg/translate-a64.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c
index f446c269dfc..567337fb40f 100644
--- a/target/arm/tcg/translate-a64.c
+++ b/target/arm/tcg/translate-a64.c
@@ -25,7 +25,6 @@
 #include "translate-a64.h"
 #include "tcg/tcg-op.h"
 #include "qemu/log.h"
-#include "arm_ldst.h"
 #include "semihosting/semihost.h"
 #include "cpregs.h"
 
@@ -10800,7 +10799,7 @@ static void aarch64_tr_translate_insn(DisasContextBase *dcbase, CPUState *cpu)
     if (pc & 3) {
         /*
          * PC alignment fault.  This has priority over the instruction abort
-         * that we would receive from a translation fault via arm_ldl_code.
+         * that we would receive from a translation fault via translator_ldl_end.
          * This should only be possible after an indirect branch, at the
          * start of the TB.
          */
@@ -10812,7 +10811,7 @@ static void aarch64_tr_translate_insn(DisasContextBase *dcbase, CPUState *cpu)
     }
 
     s->pc_curr = pc;
-    insn = arm_ldl_code(env, &s->base, pc, s->sctlr_b);
+    insn = translator_ldl_end(env, &s->base, pc, MO_LE);
     s->insn = insn;
     s->base.pc_next = pc + 4;
 
-- 
2.47.3

Re: [PATCH v9 16/20] target/arm/tcg/translate-a64.c: use translator_ldl_end instead of arm_ldl_code

Posted by Philippe Mathieu-Daudé 3 days, 23 hours ago

On 7/4/26 04:27, Pierrick Bouvier wrote:
> Allows to reduce scope of target/arm/tcg/arm_ldst.h to aarch32 only.
> 
> Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
>   target/arm/tcg/translate-a64.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)


> @@ -10812,7 +10811,7 @@ static void aarch64_tr_translate_insn(DisasContextBase *dcbase, CPUState *cpu)
>       }
>   
>       s->pc_curr = pc;
> -    insn = arm_ldl_code(env, &s->base, pc, s->sctlr_b);
> +    insn = translator_ldl_end(env, &s->base, pc, MO_LE);

Maybe worth a comment /* Code is always little-endian on Aarch64 */?

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

>       s->insn = insn;
>       s->base.pc_next = pc + 4;
>

Re: [PATCH v9 16/20] target/arm/tcg/translate-a64.c: use translator_ldl_end instead of arm_ldl_code

Posted by Pierrick Bouvier 3 days, 22 hours ago

On 4/7/26 12:13 PM, Philippe Mathieu-Daudé wrote:
> On 7/4/26 04:27, Pierrick Bouvier wrote:
>> Allows to reduce scope of target/arm/tcg/arm_ldst.h to aarch32 only.
>>
>> Suggested-by: Richard Henderson <richard.henderson@linaro.org>
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
>> ---
>>    target/arm/tcg/translate-a64.c | 5 ++---
>>    1 file changed, 2 insertions(+), 3 deletions(-)
> 
> 
>> @@ -10812,7 +10811,7 @@ static void aarch64_tr_translate_insn(DisasContextBase *dcbase, CPUState *cpu)
>>        }
>>    
>>        s->pc_curr = pc;
>> -    insn = arm_ldl_code(env, &s->base, pc, s->sctlr_b);
>> +    insn = translator_ldl_end(env, &s->base, pc, MO_LE);
> 
> Maybe worth a comment /* Code is always little-endian on Aarch64 */?
>

Just added it, thanks.

> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> 
>>        s->insn = insn;
>>        s->base.pc_next = pc + 4;
>>    
>