[v1] target/arm: Compile accelerator-related objects as common code

[PATCH-for-11.1 4/8] target/arm: Compile WHPX as common object

Philippe Mathieu-Daudé posted 8 patches 1 week, 2 days ago

Diff against v2
Download mbox

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Zhao Liu <zhao1.liu@intel.com>, Song Gao <gaosong@loongson.cn>, Bibo Mao <maobibo@loongson.cn>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Palmer Dabbelt <palmer@dabbelt.com>, Alistair Francis <alistair.francis@wdc.com>, Weiwei Li <liwei1518@gmail.com>, Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com>, Liu Zhiwei <zhiwei_liu@linux.alibaba.com>, Chao Liu <chao.liu.zevorn@gmail.com>, Cornelia Huck <cohuck@redhat.com>, Eric Farman <farman@linux.ibm.com>, Matthew Rosato <mjrosato@linux.ibm.com>, Alexander Graf <agraf@csgraf.de>, Peter Maydell <peter.maydell@linaro.org>, Pedro Barbuda <pbarbuda@microsoft.com>, Mohamed Mediouni <mohamed@unpredictable.fr>, Huacai Chen <chenhuacai@kernel.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Aurelien Jarno <aurelien@aurel32.net>, Aleksandar Rikalo <arikalo@gmail.com>

There is a newer version of this series

Expand all Fold all

[PATCH-for-11.1 4/8] target/arm: Compile WHPX as common object

Posted by Philippe Mathieu-Daudé 1 week, 2 days ago

whpx-all.c doesn't use target-specific code, move it from
arm_system_ss[] to arm_common_system_ss[] to compile it once.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/arm/whpx/meson.build | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/target/arm/whpx/meson.build b/target/arm/whpx/meson.build
index 3df632c9d30..db31e928012 100644
--- a/target/arm/whpx/meson.build
+++ b/target/arm/whpx/meson.build
@@ -1,5 +1,5 @@
-arm_system_ss.add(when: 'CONFIG_WHPX', if_true: files(
+arm_common_system_ss.add(when: 'CONFIG_WHPX', if_true: files(
   'whpx-all.c',
+), if_false: files(
+  'whpx-stub.c'
 ))
-
-arm_common_system_ss.add(when: 'CONFIG_WHPX', if_false: files('whpx-stub.c'))
-- 
2.53.0

Re: [PATCH-for-11.1 4/8] target/arm: Compile WHPX as common object

Posted by Richard Henderson 1 week ago

On 4/2/26 06:17, Philippe Mathieu-Daudé wrote:
> whpx-all.c doesn't use target-specific code, move it from
> arm_system_ss[] to arm_common_system_ss[] to compile it once.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   target/arm/whpx/meson.build | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/target/arm/whpx/meson.build b/target/arm/whpx/meson.build
> index 3df632c9d30..db31e928012 100644
> --- a/target/arm/whpx/meson.build
> +++ b/target/arm/whpx/meson.build
> @@ -1,5 +1,5 @@
> -arm_system_ss.add(when: 'CONFIG_WHPX', if_true: files(
> +arm_common_system_ss.add(when: 'CONFIG_WHPX', if_true: files(
>     'whpx-all.c',
> +), if_false: files(
> +  'whpx-stub.c'
>   ))
> -
> -arm_common_system_ss.add(when: 'CONFIG_WHPX', if_false: files('whpx-stub.c'))

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~