[v1] target/arm: Compile accelerator-related objects as common code

[PATCH-for-11.1 1/8] accel/kvm: Include missing 'exec/vaddr.h' header

Philippe Mathieu-Daudé posted 8 patches 1 week, 2 days ago

Diff against v2
Download mbox

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Zhao Liu <zhao1.liu@intel.com>, Song Gao <gaosong@loongson.cn>, Bibo Mao <maobibo@loongson.cn>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Palmer Dabbelt <palmer@dabbelt.com>, Alistair Francis <alistair.francis@wdc.com>, Weiwei Li <liwei1518@gmail.com>, Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com>, Liu Zhiwei <zhiwei_liu@linux.alibaba.com>, Chao Liu <chao.liu.zevorn@gmail.com>, Cornelia Huck <cohuck@redhat.com>, Eric Farman <farman@linux.ibm.com>, Matthew Rosato <mjrosato@linux.ibm.com>, Alexander Graf <agraf@csgraf.de>, Peter Maydell <peter.maydell@linaro.org>, Pedro Barbuda <pbarbuda@microsoft.com>, Mohamed Mediouni <mohamed@unpredictable.fr>, Huacai Chen <chenhuacai@kernel.org>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Aurelien Jarno <aurelien@aurel32.net>, Aleksandar Rikalo <arikalo@gmail.com>

There is a newer version of this series

Expand all Fold all

[PATCH-for-11.1 1/8] accel/kvm: Include missing 'exec/vaddr.h' header

Posted by Philippe Mathieu-Daudé 1 week, 2 days ago

Commit b67be03e3ac ("accel/kvm: Widen pc/saved_insn for
kvm_sw_breakpoint") used the vaddr type in the kvm_sw_breakpoint
structure but forgot to include the header defining it. Do it
now in order to avoid when refactoring unrelated headers:

  include/system/kvm.h:404:5: error: unknown type name 'vaddr'
    404 |     vaddr pc;
        |     ^~~~~
  include/system/kvm.h:405:5: error: unknown type name 'vaddr'
    405 |     vaddr saved_insn;
        |     ^~~~~

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/system/kvm.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/system/kvm.h b/include/system/kvm.h
index 5fa33eddda3..12f7fc8fb58 100644
--- a/include/system/kvm.h
+++ b/include/system/kvm.h
@@ -17,6 +17,7 @@
 #define QEMU_KVM_H
 
 #include "exec/memattrs.h"
+#include "exec/vaddr.h"
 #include "qemu/accel.h"
 #include "qom/object.h"
 
-- 
2.53.0

Re: [PATCH-for-11.1 1/8] accel/kvm: Include missing 'exec/vaddr.h' header

Posted by Richard Henderson 1 week ago

On 4/2/26 06:17, Philippe Mathieu-Daudé wrote:
> Commit b67be03e3ac ("accel/kvm: Widen pc/saved_insn for
> kvm_sw_breakpoint") used the vaddr type in the kvm_sw_breakpoint
> structure but forgot to include the header defining it. Do it
> now in order to avoid when refactoring unrelated headers:
> 
>    include/system/kvm.h:404:5: error: unknown type name 'vaddr'
>      404 |     vaddr pc;
>          |     ^~~~~
>    include/system/kvm.h:405:5: error: unknown type name 'vaddr'
>      405 |     vaddr saved_insn;
>          |     ^~~~~
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   include/system/kvm.h | 1 +
>   1 file changed, 1 insertion(+)
> 

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~

> diff --git a/include/system/kvm.h b/include/system/kvm.h
> index 5fa33eddda3..12f7fc8fb58 100644
> --- a/include/system/kvm.h
> +++ b/include/system/kvm.h
> @@ -17,6 +17,7 @@
>   #define QEMU_KVM_H
>   
>   #include "exec/memattrs.h"
> +#include "exec/vaddr.h"
>   #include "qemu/accel.h"
>   #include "qom/object.h"
>

Re: [PATCH-for-11.1 1/8] accel/kvm: Include missing 'exec/vaddr.h' header

Posted by Alistair Francis 1 week, 2 days ago

On Thu, Apr 2, 2026 at 6:18 AM Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Commit b67be03e3ac ("accel/kvm: Widen pc/saved_insn for
> kvm_sw_breakpoint") used the vaddr type in the kvm_sw_breakpoint
> structure but forgot to include the header defining it. Do it
> now in order to avoid when refactoring unrelated headers:
>
>   include/system/kvm.h:404:5: error: unknown type name 'vaddr'
>     404 |     vaddr pc;
>         |     ^~~~~
>   include/system/kvm.h:405:5: error: unknown type name 'vaddr'
>     405 |     vaddr saved_insn;
>         |     ^~~~~
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  include/system/kvm.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/system/kvm.h b/include/system/kvm.h
> index 5fa33eddda3..12f7fc8fb58 100644
> --- a/include/system/kvm.h
> +++ b/include/system/kvm.h
> @@ -17,6 +17,7 @@
>  #define QEMU_KVM_H
>
>  #include "exec/memattrs.h"
> +#include "exec/vaddr.h"
>  #include "qemu/accel.h"
>  #include "qom/object.h"
>
> --
> 2.53.0
>
>