Reentrancy fixes for lsi53c895a, and cleanups to ncr710

[PATCH 09/16] ncr710: reuse ncr710_clear_pending_irq in ncr10_do_command

Posted by Paolo Bonzini 5 days, 16 hours ago

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/scsi/ncr53c710.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/hw/scsi/ncr53c710.c b/hw/scsi/ncr53c710.c
index 9832d833b37..7503d791205 100644
--- a/hw/scsi/ncr53c710.c
+++ b/hw/scsi/ncr53c710.c
@@ -928,10 +928,7 @@ static void ncr710_do_command(NCR710State *s)
         return;
     }
 
-    if (s->current) {
-        ncr710_request_free(s, s->current);
-        s->current = NULL;
-    }
+    ncr710_clear_pending_irq(s);
 
     s->current = g_new0(NCR710Request, 1);
     s->current->tag = s->select_tag;
-- 
2.53.0

Re: [PATCH 09/16] ncr710: reuse ncr710_clear_pending_irq in ncr10_do_command

Posted by Philippe Mathieu-Daudé 5 days, 14 hours ago

On 27/3/26 22:25, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   hw/scsi/ncr53c710.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>