CI: https://gitlab.com/peterx/qemu/-/pipelines/2411892214
(1 warning, 1 error but looks irrelevant)
RFCv1->RFCv2:
- Collected tags, dropped on ones that has major changes
- Replace word 'dump' with 'save' all across the series [Fabiano]
- Patch 4
- Replaced it with a new patch to make analyze-migration.py work
- Patch 6
- Move the error_prepend() into the new helper [Fabiano]
- Patch 7
- Fix stale comments in vmsd_create_ptr_marker_field() [Fabiano]
- Recover is_null variable and around [Fabiano]
- squashed analyze-migration.py changes to make it work
- Patch 8
- Fix vmstate_check() [Fabiano]
- Fix comments / English [Fabiano]
- Introduced vmstate_load_next(), hide ptr marker details, avoid using
(void **) casts, etc. [Fabiano]
- Added one more patch from Fabiano's RFC series
This is an RFCv2 series. It is based on Fabiano's migration-staging
branch. I've pushed this tree here for easier reference:
https://gitlab.com/peterx/qemu/-/tree/vmstate-array-null
This series implements a new vmstate flag that allows real dynamic array of
pointers to be migrated, so that QEMU vmstate core will be able to identify
NULL and non-NULL pointers pointing to any kind of VMSD (or base types),
then properly allocate memory for them on dest QEMU.
The first planned user of such is Alexander's NVMe migration series here:
https://lore.kernel.org/r/20260317102708.126725-1-alexander@mihalicyn.com
This is another alternative to solve this problem.
I tested analyze-migration.py with this version and it works with an idle
dump from the nvme series (after I rebase).
Thanks,
Alexander Mikhalitsyn (1):
tests/unit/test-vmstate: add tests for VMS_ARRAY_OF_POINTER_AUTO_ALLOC
Fabiano Rosas (1):
vmstate: Stop checking size for nullptr compression
Peter Xu (9):
vmstate: Pass in struct itself for VMSTATE_ARRAY_OF_POINTER
vmstate: Pass in struct itself for VMSTATE_VARRAY_OF_POINTER_UINT32
vmstate: Do not set size for VMS_ARRAY_OF_POINTER
vmstate: Update max_elems early and check field compressable once
vmstate: Rename VMS_NULLPTR_MARKER to VMS_MARKER_PTR_NULL
vmstate: Introduce vmstate_save_field_with_vmdesc()
vmstate: Allow vmstate_info_nullptr to emit non-NULL markers
vmstate: Implement load of ptr marker in vmstate core
vmstate: Implement VMS_ARRAY_OF_POINTER_AUTO_ALLOC
include/hw/intc/riscv_aclint.h | 6 +-
include/migration/vmstate.h | 88 ++++++++++--
migration/savevm.c | 28 ++++
migration/vmstate-types.c | 36 +++--
migration/vmstate.c | 238 +++++++++++++++++++++++++--------
tests/unit/test-vmstate.c | 90 ++++++++++++-
scripts/analyze-migration.py | 22 +--
7 files changed, 408 insertions(+), 100 deletions(-)
--
2.50.1