migration: vmstate_save|load changes for peterx

[RFC PATCH v1 01/17] vmstate: fixup the use of AUTO_ALLOC flag

Posted by Fabiano Rosas 1 week, 2 days ago

Please add this fixup this somewhere

Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
 migration/savevm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/migration/savevm.c b/migration/savevm.c
index 34223de818..db0721996c 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -869,7 +869,7 @@ static void vmstate_check(const VMStateDescription *vmsd)
     if (field) {
         while (field->name) {
             if (field->flags & VMS_ARRAY_OF_POINTER) {
-                if (VMS_ARRAY_OF_POINTER_AUTO_ALLOC) {
+                if (field->flags & VMS_ARRAY_OF_POINTER_AUTO_ALLOC) {
                     /*
                      * Size must be provided because dest QEMU needs that
                      * info to know what to allocate
-- 
2.51.0

Re: [RFC PATCH v1 01/17] vmstate: fixup the use of AUTO_ALLOC flag

Posted by Peter Xu 1 week, 1 day ago

On Tue, Mar 24, 2026 at 04:43:16PM -0300, Fabiano Rosas wrote:
> Please add this fixup this somewhere
> 
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> ---
>  migration/savevm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/migration/savevm.c b/migration/savevm.c
> index 34223de818..db0721996c 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -869,7 +869,7 @@ static void vmstate_check(const VMStateDescription *vmsd)
>      if (field) {
>          while (field->name) {
>              if (field->flags & VMS_ARRAY_OF_POINTER) {
> -                if (VMS_ARRAY_OF_POINTER_AUTO_ALLOC) {
> +                if (field->flags & VMS_ARRAY_OF_POINTER_AUTO_ALLOC) {

Oops.. I'll squash this one, thanks a lot.

>                      /*
>                       * Size must be provided because dest QEMU needs that
>                       * info to know what to allocate
> -- 
> 2.51.0
> 

-- 
Peter Xu