configs/targets: Restrict the legacy ldst_phys() API on ARM / Aarch64

[PATCH-for-11.0?] configs/targets: Restrict the legacy ldst_phys() API on ARM / Aarch64

Posted by Philippe Mathieu-Daudé 2 weeks, 3 days ago

Commit d751921cffd ("hw/arm/omap1: Remove omap_badwidth_*
implementations") removed the last use of the legacy ldst_phys()
API. Set the TARGET_NOT_USING_LEGACY_LDST_PHYS_API variable to
hide the legacy API to the ARM / Aarch64 binaries, avoiding further
API uses to creep in.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 configs/targets/aarch64-softmmu.mak | 1 +
 configs/targets/arm-softmmu.mak     | 1 +
 2 files changed, 2 insertions(+)

diff --git a/configs/targets/aarch64-softmmu.mak b/configs/targets/aarch64-softmmu.mak
index 9a20187e2c1..d34aead41c4 100644
--- a/configs/targets/aarch64-softmmu.mak
+++ b/configs/targets/aarch64-softmmu.mak
@@ -5,3 +5,4 @@ TARGET_XML_FILES= aarch64-core.xml aarch64-fpu.xml arm-core.xml arm-vfp.xml arm-
 # needed by boot.c
 TARGET_NEED_FDT=y
 TARGET_LONG_BITS=64
+TARGET_NOT_USING_LEGACY_LDST_PHYS_API=y
diff --git a/configs/targets/arm-softmmu.mak b/configs/targets/arm-softmmu.mak
index 35af7da79f2..b235e34a380 100644
--- a/configs/targets/arm-softmmu.mak
+++ b/configs/targets/arm-softmmu.mak
@@ -3,3 +3,4 @@ TARGET_XML_FILES= arm-core.xml arm-vfp.xml arm-vfp3.xml arm-vfp-sysregs.xml arm-
 # needed by boot.c
 TARGET_NEED_FDT=y
 TARGET_LONG_BITS=32
+TARGET_NOT_USING_LEGACY_LDST_PHYS_API=y
-- 
2.53.0

Re: [PATCH-for-11.0?] configs/targets: Restrict the legacy ldst_phys() API on ARM / Aarch64

Posted by Peter Maydell 2 weeks, 2 days ago

On Thu, 19 Mar 2026 at 10:44, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>
> Commit d751921cffd ("hw/arm/omap1: Remove omap_badwidth_*
> implementations") removed the last use of the legacy ldst_phys()
> API. Set the TARGET_NOT_USING_LEGACY_LDST_PHYS_API variable to
> hide the legacy API to the ARM / Aarch64 binaries, avoiding further
> API uses to creep in.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  configs/targets/aarch64-softmmu.mak | 1 +
>  configs/targets/arm-softmmu.mak     | 1 +
>  2 files changed, 2 insertions(+)

We might as well take this now, it's pretty safe.



Applied to target-arm.next, thanks.

-- PMM

Re: [PATCH-for-11.0?] configs/targets: Restrict the legacy ldst_phys() API on ARM / Aarch64

Posted by Philippe Mathieu-Daudé 2 weeks, 2 days ago

On 20/3/26 11:28, Peter Maydell wrote:
> On Thu, 19 Mar 2026 at 10:44, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>>
>> Commit d751921cffd ("hw/arm/omap1: Remove omap_badwidth_*
>> implementations") removed the last use of the legacy ldst_phys()
>> API. Set the TARGET_NOT_USING_LEGACY_LDST_PHYS_API variable to
>> hide the legacy API to the ARM / Aarch64 binaries, avoiding further
>> API uses to creep in.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>>   configs/targets/aarch64-softmmu.mak | 1 +
>>   configs/targets/arm-softmmu.mak     | 1 +
>>   2 files changed, 2 insertions(+)
> 
> We might as well take this now, it's pretty safe.

Thank you, appreciated!

> Applied to target-arm.next, thanks.
> 
> -- PMM