[PATCH for-11.0 1/2] i386/pc_sysfw: stub out x86_firmware_configure

Ani Sinha posted 2 patches 2 weeks, 4 days ago
Maintainers: "Philippe Mathieu-Daudé" <philmd@linaro.org>, Gerd Hoffmann <kraxel@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Marcelo Tosatti <mtosatti@redhat.com>
There is a newer version of this series
[PATCH for-11.0 1/2] i386/pc_sysfw: stub out x86_firmware_configure
Posted by Ani Sinha 2 weeks, 4 days ago
x86_firmware_configure requires ovmf support. Add a stub for this function call
for cases where OVMF is not supported.

Reported-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Ani Sinha <anisinha@redhat.com>
---
 hw/i386/pc_sysfw_ovmf-stubs.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/hw/i386/pc_sysfw_ovmf-stubs.c b/hw/i386/pc_sysfw_ovmf-stubs.c
index aabe78b271..b53906a052 100644
--- a/hw/i386/pc_sysfw_ovmf-stubs.c
+++ b/hw/i386/pc_sysfw_ovmf-stubs.c
@@ -24,3 +24,8 @@ void pc_system_parse_ovmf_flash(uint8_t *flash_ptr, size_t flash_size)
 {
     g_assert_not_reached();
 }
+
+void x86_firmware_configure(hwaddr gpa, void *ptr, int size)
+{
+    g_assert_not_reached();
+}
-- 
2.42.0
Re: [PATCH for-11.0 1/2] i386/pc_sysfw: stub out x86_firmware_configure
Posted by Ani Sinha 2 weeks, 3 days ago

> On 19 Mar 2026, at 3:41 PM, Ani Sinha <anisinha@redhat.com> wrote:
> 
> x86_firmware_configure requires ovmf support. Add a stub for this function call
> for cases where OVMF is not supported.
> 
> Reported-by: Michael Tokarev <mjt@tls.msk.ru>
> Signed-off-by: Ani Sinha <anisinha@redhat.com>
> ---
> hw/i386/pc_sysfw_ovmf-stubs.c | 5 +++++
> 1 file changed, 5 insertions(+)
> 
> diff --git a/hw/i386/pc_sysfw_ovmf-stubs.c b/hw/i386/pc_sysfw_ovmf-stubs.c
> index aabe78b271..b53906a052 100644
> --- a/hw/i386/pc_sysfw_ovmf-stubs.c
> +++ b/hw/i386/pc_sysfw_ovmf-stubs.c
> @@ -24,3 +24,8 @@ void pc_system_parse_ovmf_flash(uint8_t *flash_ptr, size_t flash_size)
> {
>     g_assert_not_reached();
> }
> +
> +void x86_firmware_configure(hwaddr gpa, void *ptr, int size)
> +{
> +    g_assert_not_reached();
> +}

This change alone won’t work for the CONFIG_PC case. I need to move x86_firmware_configure() to pc_sysfw_ovmf.c Will fix in v2 after I run my changes through CI.

> -- 
> 2.42.0
>