1. Patchew
  2. QEMU
  3. [PATCH v3 0/4] Fix error handling for callers of load_image_targphys, get_image_size, event_notifier_init, msix_init
  4. View patch

[PATCH v3 2/4] hw/core/loader: fix error handling for get_image_size callers

Trieu Huynh posted 4 patches 2 weeks, 5 days ago
Maintainers: Richard Henderson <richard.henderson@linaro.org>, Helge Deller <deller@gmx.de>, "Maciej S. Szmigiero" <maciej.szmigiero@oracle.com>, Corey Minyard <minyard@acm.org>, Thomas Huth <th.huth+qemu@posteo.eu>, Laurent Vivier <laurent@vivier.eu>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>, Sriram Yagnaraman <sriram.yagnaraman@ericsson.com>, Jason Wang <jasowang@redhat.com>, Jiri Pirko <jiri@resnulli.us>, "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Elena Ufimtseva <elena.ufimtseva@oracle.com>, Jagannathan Raman <jag.raman@oracle.com>, Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <fam@euphon.net>, Tony Krowiak <akrowiak@linux.ibm.com>, Halil Pasic <pasic@linux.ibm.com>, Jason Herne <jjherne@linux.ibm.com>, Cornelia Huck <cohuck@redhat.com>, Eric Farman <farman@linux.ibm.com>, Matthew Rosato <mjrosato@linux.ibm.com>, Alex Williamson <alex@shazbot.org>, "Cédric Le Goater" <clg@redhat.com>, Stefano Garzarella <sgarzare@redhat.com>
[PATCH v3 2/4] hw/core/loader: fix error handling for get_image_size callers
Posted by Trieu Huynh 2 weeks, 5 days ago 
Check the return value of get_image_size() and report failures
for non-mandatory file such as FRU image.

- Use ret < 0 to detect failures in getting image size.
- No functional changes.

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/413
Signed-off-by: Trieu Huynh <vikingtc4@gmail.com>
---
 hw/ipmi/ipmi_bmc_sim.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
index 012e2ee4fe..fd875491f5 100644
--- a/hw/ipmi/ipmi_bmc_sim.c
+++ b/hw/ipmi/ipmi_bmc_sim.c
@@ -2561,6 +2561,8 @@ static void ipmi_fru_init(IPMIFru *fru)
             g_free(fru->data);
             fru->data = NULL;
         }
+    } else {
+        error_report("Could not get file size '%s'", fru->filename);
     }
 
 out:
-- 
2.43.0
Re: [PATCH v3 2/4] hw/core/loader: fix error handling for get_image_size callers
Posted by Peter Maydell 2 weeks, 4 days ago 
On Wed, 18 Mar 2026 at 14:15, Trieu Huynh <vikingtc4@gmail.com> wrote:
>
> Check the return value of get_image_size() and report failures
> for non-mandatory file such as FRU image.
>
> - Use ret < 0 to detect failures in getting image size.
> - No functional changes.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/413
> Signed-off-by: Trieu Huynh <vikingtc4@gmail.com>
> ---
>  hw/ipmi/ipmi_bmc_sim.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
> index 012e2ee4fe..fd875491f5 100644
> --- a/hw/ipmi/ipmi_bmc_sim.c
> +++ b/hw/ipmi/ipmi_bmc_sim.c
> @@ -2561,6 +2561,8 @@ static void ipmi_fru_init(IPMIFru *fru)
>              g_free(fru->data);
>              fru->data = NULL;
>          }
> +    } else {
> +        error_report("Could not get file size '%s'", fru->filename);
>      }
>
>  out:

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM
Re: [PATCH v3 2/4] hw/core/loader: fix error handling for get_image_size callers
Posted by Corey Minyard 2 weeks, 3 days ago 
On Thu, Mar 19, 2026 at 06:04:33PM +0000, Peter Maydell wrote:
> On Wed, 18 Mar 2026 at 14:15, Trieu Huynh <vikingtc4@gmail.com> wrote:
> >
> > Check the return value of get_image_size() and report failures
> > for non-mandatory file such as FRU image.

Yes, this makes sense.  You want to do this through my tree, or do you
have another way you want to get it in?

-corey

> >
> > - Use ret < 0 to detect failures in getting image size.
> > - No functional changes.
> >
> > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/413
> > Signed-off-by: Trieu Huynh <vikingtc4@gmail.com>
> > ---
> >  hw/ipmi/ipmi_bmc_sim.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
> > index 012e2ee4fe..fd875491f5 100644
> > --- a/hw/ipmi/ipmi_bmc_sim.c
> > +++ b/hw/ipmi/ipmi_bmc_sim.c
> > @@ -2561,6 +2561,8 @@ static void ipmi_fru_init(IPMIFru *fru)
> >              g_free(fru->data);
> >              fru->data = NULL;
> >          }
> > +    } else {
> > +        error_report("Could not get file size '%s'", fru->filename);
> >      }
> >
> >  out:
> 
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> 
> thanks
> -- PMM
Re: [PATCH v3 2/4] hw/core/loader: fix error handling for get_image_size callers
Posted by Philippe Mathieu-Daudé 1 week, 6 days ago 
On 19/3/26 19:29, Corey Minyard wrote:
> On Thu, Mar 19, 2026 at 06:04:33PM +0000, Peter Maydell wrote:
>> On Wed, 18 Mar 2026 at 14:15, Trieu Huynh <vikingtc4@gmail.com> wrote:
>>>
>>> Check the return value of get_image_size() and report failures
>>> for non-mandatory file such as FRU image.
> 
> Yes, this makes sense.  You want to do this through my tree, or do you
> have another way you want to get it in?
Merged via hw-misc tree, thanks!

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.