vhost-scsi: use virtio_error instead of exit for sense/CDB write

[PATCH] vhost-scsi: use virtio_error instead of exit for sense/CDB write

Razvan Ghiorghe posted 1 patch 2 weeks, 5 days ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260317210006.187234-1-razvanghiorghe16@gmail.com

Maintainers: "Michael S. Tsirkin" <mst@redhat.com>, Stefano Garzarella <sgarzare@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <fam@euphon.net>

hw/scsi/vhost-scsi-common.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Expand all Fold all

[PATCH] vhost-scsi: use virtio_error instead of exit for sense/CDB write

Posted by Razvan Ghiorghe 2 weeks, 5 days ago

Until now, writing to the SENSE or CDB size register would terminate the QEMU process,
but a guest should never be able to crash the host process. This patch replaces that
behavior with virtio_error() and marks the device as in error, allowing QEMU to continue running.This follows the same pattern as other vhost devices.

Signed-off-by: Razvan Ghiorghe <razvanghiorghe16@gmail.com>
---
 hw/scsi/vhost-scsi-common.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/scsi/vhost-scsi-common.c b/hw/scsi/vhost-scsi-common.c
index 0bb4305de6..938e9d9965 100644
--- a/hw/scsi/vhost-scsi-common.c
+++ b/hw/scsi/vhost-scsi-common.c
@@ -140,9 +140,9 @@ void vhost_scsi_common_set_config(VirtIODevice *vdev, const uint8_t *config)
 
     if ((uint32_t)virtio_ldl_p(vdev, &scsiconf->sense_size) != vs->sense_size ||
         (uint32_t)virtio_ldl_p(vdev, &scsiconf->cdb_size) != vs->cdb_size) {
-        error_report("vhost-scsi does not support changing the sense data and "
-                     "CDB sizes");
-        exit(1);
+        virtio_error(vdev, "vhost-scsi does not support changing the sense "
+                     "data and CDB sizes");
+        return;
     }
 }
 
-- 
2.43.0