hw/tpm: Remove instance @ppi_enabled field

[PATCH v3 0/5] hw/tpm: Remove instance @ppi_enabled field

Posted by Philippe Mathieu-Daudé 2 weeks, 6 days ago

The "ppi" property and @ppi_enabled field were only used
for backward compatibility during the 3.1 release. We
removed all these legacy machines: the property isn't
required anymore. Still it was how the ACPI subsystem
was checking PPI use by TPM devices. This series convert
the per-instance field exposed as QOM property as a
single class (actually QOM interface) one.

Philippe Mathieu-Daudé (5):
  hw/tpm: Factor tpm_ppi_enabled() out
  hw/tpm: Add TPMIfClass::ppi_enabled field
  hw/tpm: Remove CRBState::ppi_enabled field
  hw/tpm: Propagate @ppi_enabled to tpm_tis_reset() and remove in
    TPMState
  hw/tpm: Simplify tpm_ppi_enabled()

 hw/tpm/tpm_tis.h        |  3 +--
 include/system/tpm.h    |  9 +++++++++
 hw/acpi/tpm.c           |  2 +-
 hw/i386/acpi-build.c    |  2 +-
 hw/tpm/tpm_crb.c        | 13 ++++---------
 hw/tpm/tpm_tis_common.c |  4 ++--
 hw/tpm/tpm_tis_i2c.c    |  2 +-
 hw/tpm/tpm_tis_isa.c    | 10 ++++------
 hw/tpm/tpm_tis_sysbus.c |  2 +-
 9 files changed, 24 insertions(+), 23 deletions(-)

-- 
2.53.0

Re: [PATCH v3 0/5] hw/tpm: Remove instance @ppi_enabled field

Posted by Philippe Mathieu-Daudé 2 weeks ago

On 17/3/26 13:02, Philippe Mathieu-Daudé wrote:

> Philippe Mathieu-Daudé (5):
>    hw/tpm: Factor tpm_ppi_enabled() out
>    hw/tpm: Add TPMIfClass::ppi_enabled field
>    hw/tpm: Remove CRBState::ppi_enabled field
>    hw/tpm: Propagate @ppi_enabled to tpm_tis_reset() and remove in
>      TPMState
>    hw/tpm: Simplify tpm_ppi_enabled()

Series queued for 11.1 (typo fixed), thanks.

Re: [PATCH v3 0/5] hw/tpm: Remove instance @ppi_enabled field

Posted by Stefan Berger 1 week, 3 days ago


On 3/23/26 5:56 AM, Philippe Mathieu-Daudé wrote:
> On 17/3/26 13:02, Philippe Mathieu-Daudé wrote:
> 
>> Philippe Mathieu-Daudé (5):
>>    hw/tpm: Factor tpm_ppi_enabled() out
>>    hw/tpm: Add TPMIfClass::ppi_enabled field
>>    hw/tpm: Remove CRBState::ppi_enabled field
>>    hw/tpm: Propagate @ppi_enabled to tpm_tis_reset() and remove in
>>      TPMState
>>    hw/tpm: Simplify tpm_ppi_enabled()
> 
> Series queued for 11.1 (typo fixed), thanks.
> 

Here's another TPM PPI related series. It would make sense to upstream 
them together. Do you want to queue that one as well?

https://lore.kernel.org/qemu-devel/20260327-tpm-tis-sysbus-ppi-v2-0-d8ec84d25dbc@redhat.com/T/#t

Re: [PATCH v3 0/5] hw/tpm: Remove instance @ppi_enabled field

Posted by Stefan Berger 1 week, 3 days ago


On 3/27/26 11:18 AM, Stefan Berger wrote:
> 
> 
> On 3/23/26 5:56 AM, Philippe Mathieu-Daudé wrote:
>> On 17/3/26 13:02, Philippe Mathieu-Daudé wrote:
>>
>>> Philippe Mathieu-Daudé (5):
>>>    hw/tpm: Factor tpm_ppi_enabled() out
>>>    hw/tpm: Add TPMIfClass::ppi_enabled field
>>>    hw/tpm: Remove CRBState::ppi_enabled field
>>>    hw/tpm: Propagate @ppi_enabled to tpm_tis_reset() and remove in
>>>      TPMState
>>>    hw/tpm: Simplify tpm_ppi_enabled()
>>
>> Series queued for 11.1 (typo fixed), thanks.
>>
> 
> Here's another TPM PPI related series. It would make sense to upstream 
> them together. Do you want to queue that one as well?
> 
> https://lore.kernel.org/qemu-devel/20260327-tpm-tis-sysbus-ppi-v2-0- 
> d8ec84d25dbc@redhat.com/T/#t
> 

Actually, they will have to rebase on this series first...
>

Re: [PATCH v3 0/5] hw/tpm: Remove instance @ppi_enabled field

Posted by Stefan Berger 1 week, 3 days ago


On 3/27/26 11:21 AM, Stefan Berger wrote:
> 
> 
> On 3/27/26 11:18 AM, Stefan Berger wrote:
>>
>>
>> On 3/23/26 5:56 AM, Philippe Mathieu-Daudé wrote:
>>> On 17/3/26 13:02, Philippe Mathieu-Daudé wrote:
>>>
>>>> Philippe Mathieu-Daudé (5):
>>>>    hw/tpm: Factor tpm_ppi_enabled() out
>>>>    hw/tpm: Add TPMIfClass::ppi_enabled field
>>>>    hw/tpm: Remove CRBState::ppi_enabled field
>>>>    hw/tpm: Propagate @ppi_enabled to tpm_tis_reset() and remove in
>>>>      TPMState
>>>>    hw/tpm: Simplify tpm_ppi_enabled()
>>>
>>> Series queued for 11.1 (typo fixed), thanks.
>>>
>>
>> Here's another TPM PPI related series. It would make sense to upstream 
>> them together. Do you want to queue that one as well?
>>
>> https://lore.kernel.org/qemu-devel/20260327-tpm-tis-sysbus-ppi-v2-0- 
>> d8ec84d25dbc@redhat.com/T/#t
>>
> 
> Actually, they will have to rebase on this series first...
>>
> 

v3 is good now:

https://lore.kernel.org/qemu-devel/20260327173209.148180-1-mbawa@redhat.com/T/#t

If you want to take it let me know, otherwise I will have to wait for 
your series.

Re: [PATCH v3 0/5] hw/tpm: Remove instance @ppi_enabled field

Posted by Philippe Mathieu-Daudé 1 week, 2 days ago

On 27/3/26 19:17, Stefan Berger wrote:
> 
> 
> On 3/27/26 11:21 AM, Stefan Berger wrote:
>>
>>
>> On 3/27/26 11:18 AM, Stefan Berger wrote:
>>>
>>>
>>> On 3/23/26 5:56 AM, Philippe Mathieu-Daudé wrote:
>>>> On 17/3/26 13:02, Philippe Mathieu-Daudé wrote:
>>>>
>>>>> Philippe Mathieu-Daudé (5):
>>>>>    hw/tpm: Factor tpm_ppi_enabled() out
>>>>>    hw/tpm: Add TPMIfClass::ppi_enabled field
>>>>>    hw/tpm: Remove CRBState::ppi_enabled field
>>>>>    hw/tpm: Propagate @ppi_enabled to tpm_tis_reset() and remove in
>>>>>      TPMState
>>>>>    hw/tpm: Simplify tpm_ppi_enabled()
>>>>
>>>> Series queued for 11.1 (typo fixed), thanks.
>>>>
>>>
>>> Here's another TPM PPI related series. It would make sense to 
>>> upstream them together. Do you want to queue that one as well?
>>>
>>> https://lore.kernel.org/qemu-devel/20260327-tpm-tis-sysbus-ppi-v2-0- 
>>> d8ec84d25dbc@redhat.com/T/#t
>>>
>>
>> Actually, they will have to rebase on this series first...
>>>
>>
> 
> v3 is good now:
> 
> https://lore.kernel.org/qemu-devel/20260327173209.148180-1- 
> mbawa@redhat.com/T/#t
> 
> If you want to take it let me know, otherwise I will have to wait for 
> your series.

Thanks for the head up, I'll queue it along and send the pull
request after 11.0 is released.

Regards,

Phil.