From: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>
Introduce configure_machine, launch_source_vm and assert_dest_vm
methods to allow child classes to override some pieces of
source/dest VMs creation, start and check logic.
Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn@futurfusion.io>
---
tests/functional/migration.py | 22 +++++++++++++++++++---
1 file changed, 19 insertions(+), 3 deletions(-)
diff --git a/tests/functional/migration.py b/tests/functional/migration.py
index e995328e833..40e9c094c46 100644
--- a/tests/functional/migration.py
+++ b/tests/functional/migration.py
@@ -40,19 +40,35 @@ def assert_migration(self, src_vm, dst_vm):
self.assertEqual(dst_vm.cmd('query-status')['status'], 'running')
self.assertEqual(src_vm.cmd('query-status')['status'],'postmigrate')
+ # Can be overridden by subclasses to configure both source/dest VMs.
+ def configure_machine(self, vm):
+ vm.add_args('-nodefaults')
+
+ # Can be overridden by subclasses to prepare the source VM before migration,
+ # e.g. by running some workload inside the source VM to see if it continues
+ # to run properly after migration.
+ def launch_source_vm(self, vm):
+ vm.launch()
+
+ # Can be overridden by subclasses to check the destination VM after migration,
+ # e.g. by checking if the workload is still running after migration.
+ def assert_dest_vm(self, vm):
+ pass
+
def migrate_vms(self, dst_uri, src_uri, dst_vm, src_vm):
dst_vm.qmp('migrate-incoming', uri=dst_uri)
src_vm.qmp('migrate', uri=src_uri)
self.assert_migration(src_vm, dst_vm)
+ self.assert_dest_vm(dst_vm)
def migrate(self, dst_uri, src_uri=None):
dst_vm = self.get_vm('-incoming', 'defer', name="dst-qemu")
- dst_vm.add_args('-nodefaults')
+ self.configure_machine(dst_vm)
dst_vm.launch()
src_vm = self.get_vm(name="src-qemu")
- src_vm.add_args('-nodefaults')
- src_vm.launch()
+ self.configure_machine(src_vm)
+ self.launch_source_vm(src_vm)
if src_uri is None:
src_uri = dst_uri
--
2.47.3