[v3] add build option to disable audio subsystem

[PATCH v3 03/11] tests/qtest: remove -audio none when configured with --disable-audio

Sergei Heifetz posted 11 patches 3 weeks, 1 day ago

Diff against v1 v2
Download mbox

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, "Dr. David Alan Gilbert" <dave@treblig.org>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Yanan Wang <wangyanan55@huawei.com>, Zhao Liu <zhao1.liu@intel.com>, "Daniel P. Berrangé" <berrange@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Eric Blake <eblake@redhat.com>, Markus Armbruster <armbru@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, Fabiano Rosas <farosas@suse.de>, Laurent Vivier <lvivier@redhat.com>

Expand all Fold all

[PATCH v3 03/11] tests/qtest: remove -audio none when configured with --disable-audio

Posted by Sergei Heifetz 3 weeks, 1 day ago

It does not matter much whether `-audio none` is passed. In the future,
support for `-audio none` with `--disable-audio` will be dropped, so we
should remove it beforehand.

(We could preserve `-audio none` with `--disable-audio` for compatibility
reasons, but we choose not to because they have different meanings:
`--disable-audio` will eventually mean having no audio backend at all,
while `-audio none` means using the `none` audio backend.)

Signed-off-by: Sergei Heifetz <heifetz@yandex-team.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 tests/qtest/libqtest.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
index 051faf31e14..a59fdaf3973 100644
--- a/tests/qtest/libqtest.c
+++ b/tests/qtest/libqtest.c
@@ -464,7 +464,9 @@ gchar *qtest_qemu_args(const char *extra_args)
                       "-chardev socket,path=%s,id=char0 "
                       "-mon chardev=char0,mode=control "
                       "-display none "
+#ifdef CONFIG_AUDIO
                       "-audio none "
+#endif
                       "%s"
                       "%s"
                       " -accel qtest",
-- 
2.34.1

Re: [PATCH v3 03/11] tests/qtest: remove -audio none when configured with --disable-audio

Posted by Philippe Mathieu-Daudé 5 days, 20 hours ago

On 15/3/26 21:16, Sergei Heifetz wrote:
> It does not matter much whether `-audio none` is passed. In the future,
> support for `-audio none` with `--disable-audio` will be dropped, so we
> should remove it beforehand.
> 
> (We could preserve `-audio none` with `--disable-audio` for compatibility
> reasons, but we choose not to because they have different meanings:
> `--disable-audio` will eventually mean having no audio backend at all,
> while `-audio none` means using the `none` audio backend.)
> 
> Signed-off-by: Sergei Heifetz <heifetz@yandex-team.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>   tests/qtest/libqtest.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
> index 051faf31e14..a59fdaf3973 100644
> --- a/tests/qtest/libqtest.c
> +++ b/tests/qtest/libqtest.c
> @@ -464,7 +464,9 @@ gchar *qtest_qemu_args(const char *extra_args)
>                         "-chardev socket,path=%s,id=char0 "
>                         "-mon chardev=char0,mode=control "
>                         "-display none "
> +#ifdef CONFIG_AUDIO
>                         "-audio none "
> +#endif

IMHO if we implement using stubs as suggested in the previous patch
review, "-audio none" is stubbed code so no change needed here.