target/cpu: Do not include 'exec/cpu-defs.h' anymore

[PATCH v2 16/38] hw/misc/cpc: Include missing 'hw/core/cpu.h' header

Philippe Mathieu-Daudé posted 38 patches 3 weeks, 4 days ago

Download mbox

Maintainers: Richard Henderson <richard.henderson@linaro.org>, Peter Maydell <peter.maydell@linaro.org>, Igor Mitsyanko <i.mitsyanko@gmail.com>, Eric Auger <eric.auger@redhat.com>, Michael Rolnik <mrolnik@gmail.com>, Helge Deller <deller@gmx.de>, Paolo Bonzini <pbonzini@redhat.com>, Eduardo Habkost <eduardo@habkost.net>, "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>, Gerd Hoffmann <kraxel@redhat.com>, Laurent Vivier <laurent@vivier.eu>, Yoshinori Sato <yoshinori.sato@nifty.com>, Magnus Damm <magnus.damm@gmail.com>, Thomas Huth <th.huth+qemu@posteo.eu>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Alistair Francis <alistair@alistair23.me>, Huacai Chen <chenhuacai@kernel.org>, Jiaxun Yang <jiaxun.yang@flygoat.com>, "Hervé Poussineau" <hpoussin@reactos.org>, Aleksandar Rikalo <arikalo@gmail.com>, Aurelien Jarno <aurelien@aurel32.net>, Stafford Horne <shorne@gmail.com>, Jia Liu <proljc@gmail.com>, Bernhard Beschow <shentey@gmail.com>, BALATON Zoltan <balaton@eik.bme.hu>, Nicholas Piggin <npiggin@gmail.com>, Chinmay Rath <rathc@linux.ibm.com>, Glenn Miles <milesg@linux.ibm.com>, Harsh Prateek Bora <harshpb@linux.ibm.com>, Sai Pavan Boddu <sai.pavan.boddu@amd.com>, Palmer Dabbelt <palmer@dabbelt.com>, Weiwei Li <liwei1518@gmail.com>, Daniel Henrique Barboza <dbarboza@ventanamicro.com>, Liu Zhiwei <zhiwei_liu@linux.alibaba.com>, Tony Krowiak <akrowiak@linux.ibm.com>, Halil Pasic <pasic@linux.ibm.com>, Jason Herne <jjherne@linux.ibm.com>, Christian Borntraeger <borntraeger@linux.ibm.com>, Eric Farman <farman@linux.ibm.com>, Matthew Rosato <mjrosato@linux.ibm.com>, Ilya Leoshkevich <iii@linux.ibm.com>, David Hildenbrand <david@kernel.org>, Jared Rossi <jrossi@linux.ibm.com>, Zhuoying Cai <zycai@linux.ibm.com>, Farhan Ali <alifm@linux.ibm.com>, "Clément Chigot" <chigot@adacore.com>, Frederic Konrad <konrad.frederic@yahoo.fr>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Artyom Tarasenko <atar4qemu@gmail.com>, Bastian Koppelmann <kbastian@rumtueddeln.de>, Max Filippov <jcmvbkbc@gmail.com>, Antony Pavlov <antonynpavlov@gmail.com>, Jean-Christophe Dubois <jcd@tribudubois.net>, Andrey Smirnov <andrew.smirnov@gmail.com>, Aditya Gupta <adityag@linux.ibm.com>, Sourabh Jain <sourabhjain@linux.ibm.com>, "Dr. David Alan Gilbert" <dave@treblig.org>, David Woodhouse <dwmw2@infradead.org>, Paul Durrant <paul@xen.org>, Pierrick Bouvier <pierrick.bouvier@linaro.org>, Alexander Graf <agraf@csgraf.de>, Brian Cain <brian.cain@oss.qualcomm.com>, Zhao Liu <zhao1.liu@intel.com>, Song Gao <gaosong@loongson.cn>

Expand all Fold all

[PATCH v2 16/38] hw/misc/cpc: Include missing 'hw/core/cpu.h' header

Posted by Philippe Mathieu-Daudé 3 weeks, 4 days ago

The "hw/core/cpu.h" header is indirectly included. Include it
explicitly otherwise we get when refactoring unrelated headers:

  ../hw/misc/mips_cpc.c:36:53: error: unknown type name 'run_on_cpu_data'
     36 | static void mips_cpu_reset_async_work(CPUState *cs, run_on_cpu_data data)
        |                                                     ^
  ../hw/misc/mips_cpc.c:40:5: error: call to undeclared function 'cpu_reset'
       40 |     cpu_reset(cs);
          |     ^
  ../hw/misc/riscv_cpc.c:34:54: error: unknown type name 'run_on_cpu_data'
     34 | static void riscv_cpu_reset_async_work(CPUState *cs, run_on_cpu_data data)
        |                                                      ^
  ../hw/misc/riscv_cpc.c:39:5: error: call to undeclared function 'cpu_reset'
     39 |     cpu_reset(cs);
        |     ^

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/misc/mips_cpc.c  | 1 +
 hw/misc/riscv_cpc.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/hw/misc/mips_cpc.c b/hw/misc/mips_cpc.c
index 924de855ee2..d092f76f44d 100644
--- a/hw/misc/mips_cpc.c
+++ b/hw/misc/mips_cpc.c
@@ -22,6 +22,7 @@
 #include "cpu.h"
 #include "qemu/log.h"
 #include "qemu/module.h"
+#include "hw/core/cpu.h"
 #include "hw/core/sysbus.h"
 #include "migration/vmstate.h"
 
diff --git a/hw/misc/riscv_cpc.c b/hw/misc/riscv_cpc.c
index 4bf2fd8db16..e04ccdf54fa 100644
--- a/hw/misc/riscv_cpc.c
+++ b/hw/misc/riscv_cpc.c
@@ -18,6 +18,7 @@
 #include "qemu/module.h"
 #include "qemu/timer.h"
 #include "qemu/bitops.h"
+#include "hw/core/cpu.h"
 #include "hw/core/sysbus.h"
 #include "migration/vmstate.h"
 
-- 
2.53.0

Re: [PATCH v2 16/38] hw/misc/cpc: Include missing 'hw/core/cpu.h' header

Posted by Pierrick Bouvier 3 weeks, 3 days ago

On 3/12/26 11:20 PM, Philippe Mathieu-Daudé wrote:
> The "hw/core/cpu.h" header is indirectly included. Include it
> explicitly otherwise we get when refactoring unrelated headers:
> 
>    ../hw/misc/mips_cpc.c:36:53: error: unknown type name 'run_on_cpu_data'
>       36 | static void mips_cpu_reset_async_work(CPUState *cs, run_on_cpu_data data)
>          |                                                     ^
>    ../hw/misc/mips_cpc.c:40:5: error: call to undeclared function 'cpu_reset'
>         40 |     cpu_reset(cs);
>            |     ^
>    ../hw/misc/riscv_cpc.c:34:54: error: unknown type name 'run_on_cpu_data'
>       34 | static void riscv_cpu_reset_async_work(CPUState *cs, run_on_cpu_data data)
>          |                                                      ^
>    ../hw/misc/riscv_cpc.c:39:5: error: call to undeclared function 'cpu_reset'
>       39 |     cpu_reset(cs);
>          |     ^
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   hw/misc/mips_cpc.c  | 1 +
>   hw/misc/riscv_cpc.c | 1 +
>   2 files changed, 2 insertions(+)
> 

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>

Re: [PATCH v2 16/38] hw/misc/cpc: Include missing 'hw/core/cpu.h' header

Posted by Thomas Huth 3 weeks, 4 days ago

On 13/03/2026 07.20, Philippe Mathieu-Daudé wrote:
> The "hw/core/cpu.h" header is indirectly included. Include it
> explicitly otherwise we get when refactoring unrelated headers:
> 
>    ../hw/misc/mips_cpc.c:36:53: error: unknown type name 'run_on_cpu_data'
>       36 | static void mips_cpu_reset_async_work(CPUState *cs, run_on_cpu_data data)
>          |                                                     ^
>    ../hw/misc/mips_cpc.c:40:5: error: call to undeclared function 'cpu_reset'
>         40 |     cpu_reset(cs);
>            |     ^
>    ../hw/misc/riscv_cpc.c:34:54: error: unknown type name 'run_on_cpu_data'
>       34 | static void riscv_cpu_reset_async_work(CPUState *cs, run_on_cpu_data data)
>          |                                                      ^
>    ../hw/misc/riscv_cpc.c:39:5: error: call to undeclared function 'cpu_reset'
>       39 |     cpu_reset(cs);
>          |     ^
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   hw/misc/mips_cpc.c  | 1 +
>   hw/misc/riscv_cpc.c | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/hw/misc/mips_cpc.c b/hw/misc/mips_cpc.c
> index 924de855ee2..d092f76f44d 100644
> --- a/hw/misc/mips_cpc.c
> +++ b/hw/misc/mips_cpc.c
> @@ -22,6 +22,7 @@
>   #include "cpu.h"
>   #include "qemu/log.h"
>   #include "qemu/module.h"
> +#include "hw/core/cpu.h"
>   #include "hw/core/sysbus.h"
>   #include "migration/vmstate.h"
>   
> diff --git a/hw/misc/riscv_cpc.c b/hw/misc/riscv_cpc.c
> index 4bf2fd8db16..e04ccdf54fa 100644
> --- a/hw/misc/riscv_cpc.c
> +++ b/hw/misc/riscv_cpc.c
> @@ -18,6 +18,7 @@
>   #include "qemu/module.h"
>   #include "qemu/timer.h"
>   #include "qemu/bitops.h"
> +#include "hw/core/cpu.h"
>   #include "hw/core/sysbus.h"
>   #include "migration/vmstate.h"
>   

Reviewed-by: Thomas Huth <thuth@redhat.com>