Hi Eric,
On 3/16/2026 12:32 AM, Eric Auger wrote:
> Hi Nathan,
>
> On 3/12/26 10:03 PM, Nathan Chen wrote:
>> From: Nathan Chen<nathanc@nvidia.com>
>>
>> Compare the host SMMUv3 ATS support bit with the guest SMMUv3 ATS support
>> bit in IDR0 and fail the compatibility check if ATS support is opted as
>> enabled on the guest SMMUv3 when it is not supported on host SMMUv3.
> Miss
> Fixes: f7f5013a55a3 ("hw/arm/smmuv3-accel: Add support for ATS")
I'll include this in the next refresh.
>> Signed-off-by: Nathan Chen<nathanc@nvidia.com>
>> ---
>> hw/arm/smmuv3-accel.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/hw/arm/smmuv3-accel.c b/hw/arm/smmuv3-accel.c
>> index 17306cd04b..fe78ce69a5 100644
>> --- a/hw/arm/smmuv3-accel.c
>> +++ b/hw/arm/smmuv3-accel.c
>> @@ -101,6 +101,13 @@ smmuv3_accel_check_hw_compatible(SMMUv3State *s,
>> smmuv3_oas_bits(FIELD_EX32(s->idr[5], IDR5, OAS)));
>> return false;
>> }
>> + /* Check ATS value opted is compatible with Host SMMUv3 */
>> + if (FIELD_EX32(info->idr[0], IDR0, ATS) <
>> + FIELD_EX32(s->idr[0], IDR0, ATS)) {
>> + error_setg(errp, "Host SMMUv3 doesn't support Address Translation"
>> + " Services");
> I think you can keep it on the same line. Checkpatch will just issue a
> warning.
Ok, I will put this on the same line.
>> + return false;
>> + }
>>
>> /* QEMU SMMUv3 supports GRAN4K/GRAN16K/GRAN64K translation granules */
>> if (FIELD_EX32(info->idr[5], IDR5, GRAN4K) !=
> Otherwise
> Reviewed-by: Eric Auger<eric.auger@redhat.com>
Thanks for the feedback and R-by!
Nathan