On 3/12/26 12:16 AM, Arun Menon wrote:
> Replace manual bitwise operations with ARRAY_FIELD_DP32 macros
> No functional changes.
>
> Signed-off-by: Arun Menon <armenon@redhat.com>
> ---
> hw/tpm/tpm_crb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/tpm/tpm_crb.c b/hw/tpm/tpm_crb.c
> index 0a1c7ecdc6..bc55908786 100644
> --- a/hw/tpm/tpm_crb.c
> +++ b/hw/tpm/tpm_crb.c
> @@ -145,7 +145,7 @@ static void tpm_crb_mmio_write(void *opaque, hwaddr addr,
> tpm_crb_get_active_locty(s) == locty) {
> void *mem = memory_region_get_ram_ptr(&s->cmdmem);
>
> - s->regs[R_CRB_CTRL_START] |= CRB_START_INVOKE;
> + ARRAY_FIELD_DP32(s->regs, CRB_CTRL_START, invoke, 1);
> s->cmd = (TPMBackendCmd) {
> .in = mem,
> .in_len = MIN(tpm_cmd_get_size(mem), s->be_buffer_size),
> @@ -194,7 +194,7 @@ static void tpm_crb_request_completed(TPMIf *ti, int ret)
> {
> CRBState *s = CRB(ti);
>
> - s->regs[R_CRB_CTRL_START] &= ~CRB_START_INVOKE;
> + ARRAY_FIELD_DP32(s->regs, CRB_CTRL_START, invoke, 0);
> if (ret != 0) {
> ARRAY_FIELD_DP32(s->regs, CRB_CTRL_STS,
> tpmSts, 1); /* fatal error */
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>