[v4] Fix a few minor issues reported by Coverity

[PATCH v4 0/4] Fix a few minor issues reported by Coverity

Sergei Heifetz posted 4 patches 3 weeks, 6 days ago

Diff against v1 v2 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20260311131522.58600-1-heifetz@yandex-team.com

Maintainers: "Marc-André Lureau" <marcandre.lureau@redhat.com>, Ani Sinha <anisinha@redhat.com>, Peter Xu <peterx@redhat.com>, Fabiano Rosas <farosas@suse.de>, Paolo Bonzini <pbonzini@redhat.com>, "Philippe Mathieu-Daudé" <philmd@linaro.org>

dump/dump.c        | 2 +-
hw/usb/core.c      | 2 +-
migration/savevm.c | 3 ++-
system/physmem.c   | 2 --
4 files changed, 4 insertions(+), 5 deletions(-)

Expand all Fold all

[PATCH v4 0/4] Fix a few minor issues reported by Coverity

Posted by Sergei Heifetz 3 weeks, 6 days ago

Hi. This patch series fixes several minor issues reported by our local
Coverity installation.

Changes in v4:
- Included Peter's explanation why `assert` is redundant in the commit
  message of the third patch.
- Added `Reviewed-by` tags that I missed in v2 to the other three patches.

Changes in v3:
- Nothing. I sent the second version of the series without the corresponding
'v2' suffix by mistake. I apologise.

Changes in v2:
- Remove assert(block) in system/physmem.c instead of placing it
  before the dereference.

Sergei Heifetz (4):
  migration/savevm.c: reorder usage and assertion of mis->from_src_file
  dump/dump.c: reorder usage and assertion of block
  system/physmem.c: remove useless assertion of block
  hw/usb/core.c: reorder usage and assertion of p->ep

 dump/dump.c        | 2 +-
 hw/usb/core.c      | 2 +-
 migration/savevm.c | 3 ++-
 system/physmem.c   | 2 --
 4 files changed, 4 insertions(+), 5 deletions(-)

-- 
2.34.1

Re: [PATCH v4 0/4] Fix a few minor issues reported by Coverity

Posted by Peter Xu 3 weeks, 6 days ago

On Wed, Mar 11, 2026 at 06:15:18PM +0500, Sergei Heifetz wrote:
> Hi. This patch series fixes several minor issues reported by our local
> Coverity installation.
> 
> Changes in v4:
> - Included Peter's explanation why `assert` is redundant in the commit
>   message of the third patch.
> - Added `Reviewed-by` tags that I missed in v2 to the other three patches.
> 
> Changes in v3:
> - Nothing. I sent the second version of the series without the corresponding
> 'v2' suffix by mistake. I apologise.
> 
> Changes in v2:
> - Remove assert(block) in system/physmem.c instead of placing it
>   before the dereference.
> 
> Sergei Heifetz (4):
>   migration/savevm.c: reorder usage and assertion of mis->from_src_file
>   dump/dump.c: reorder usage and assertion of block
>   system/physmem.c: remove useless assertion of block
>   hw/usb/core.c: reorder usage and assertion of p->ep

Reviewed-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu